From 0b43dd2a62a1f90308fc422978c3120760a1b396 Mon Sep 17 00:00:00 2001 From: Hatake Kakashri Date: Tue, 13 Jan 2026 22:12:50 +0530 Subject: [PATCH] Bump minimum SDK version to API 23 - Updated the `minSdk` in `app/build.gradle.kts`. - Adjusted the api-level for the test-android min sdk CI workflow in `.github/workflows/ci.yml`. - Simplified the `getOsString()` method in `ErrorActivity.java` by removing the conditional check for `Build.VERSION_CODES.M`, as API 23 is now the minimum. --- .github/workflows/ci.yml | 2 +- app/build.gradle.kts | 2 +- app/src/main/java/org/schabi/newpipe/error/ErrorActivity.java | 3 +-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d42c5a0b4..91d0e8f76 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -69,7 +69,7 @@ jobs: strategy: matrix: include: - - api-level: 21 + - api-level: 23 target: default arch: x86 - api-level: 35 diff --git a/app/build.gradle.kts b/app/build.gradle.kts index 03841a7b2..517fb9ce5 100644 --- a/app/build.gradle.kts +++ b/app/build.gradle.kts @@ -44,7 +44,7 @@ android { defaultConfig { applicationId = "org.schabi.newpipe" resValue("string", "app_name", "NewPipe") - minSdk = 21 + minSdk = 23 targetSdk = 35 versionCode = System.getProperty("versionCodeOverride")?.toInt() ?: 1005 diff --git a/app/src/main/java/org/schabi/newpipe/error/ErrorActivity.java b/app/src/main/java/org/schabi/newpipe/error/ErrorActivity.java index 160dcca4d..94a2157fe 100644 --- a/app/src/main/java/org/schabi/newpipe/error/ErrorActivity.java +++ b/app/src/main/java/org/schabi/newpipe/error/ErrorActivity.java @@ -307,8 +307,7 @@ public class ErrorActivity extends AppCompatActivity { } private String getOsString() { - final String osBase = Build.VERSION.SDK_INT >= Build.VERSION_CODES.M - ? Build.VERSION.BASE_OS : "Android"; + final String osBase = Build.VERSION.BASE_OS; return System.getProperty("os.name") + " " + (osBase.isEmpty() ? "Android" : osBase) + " " + Build.VERSION.RELEASE