From 23b7f21d7c6582fb82793f06cd94b371e6a1b38a Mon Sep 17 00:00:00 2001 From: Siddhesh Dhainje Date: Sun, 4 Jan 2026 01:06:18 +0530 Subject: [PATCH] Fix crash on screen rotation while entering SoundCloud import URL --- .../subscription/ImportConfirmationDialog.java | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/app/src/main/java/org/schabi/newpipe/local/subscription/ImportConfirmationDialog.java b/app/src/main/java/org/schabi/newpipe/local/subscription/ImportConfirmationDialog.java index 03dd4a1cd..aa15b26d8 100644 --- a/app/src/main/java/org/schabi/newpipe/local/subscription/ImportConfirmationDialog.java +++ b/app/src/main/java/org/schabi/newpipe/local/subscription/ImportConfirmationDialog.java @@ -18,18 +18,17 @@ import org.schabi.newpipe.R; public class ImportConfirmationDialog extends DialogFragment { @State protected Intent resultServiceIntent; + static final String EXTRA_RESULT_SERVICE_INTENT = "extra_result_service_intent"; public static void show(@NonNull final Fragment fragment, @NonNull final Intent resultServiceIntent) { final ImportConfirmationDialog confirmationDialog = new ImportConfirmationDialog(); - confirmationDialog.setResultServiceIntent(resultServiceIntent); + final Bundle args = new Bundle(); + args.putParcelable(EXTRA_RESULT_SERVICE_INTENT, resultServiceIntent); + confirmationDialog.setArguments(args); confirmationDialog.show(fragment.getParentFragmentManager(), null); } - public void setResultServiceIntent(final Intent resultServiceIntent) { - this.resultServiceIntent = resultServiceIntent; - } - @NonNull @Override public Dialog onCreateDialog(@Nullable final Bundle savedInstanceState) { @@ -50,6 +49,10 @@ public class ImportConfirmationDialog extends DialogFragment { public void onCreate(@Nullable final Bundle savedInstanceState) { super.onCreate(savedInstanceState); + if (getArguments() != null) { + resultServiceIntent = getArguments().getParcelable(EXTRA_RESULT_SERVICE_INTENT); + } + if (resultServiceIntent == null) { throw new IllegalStateException("Result intent is null"); }