From e6daf45c835782cc034784186fc1c62788aae140 Mon Sep 17 00:00:00 2001 From: TobiGr Date: Fri, 6 Feb 2026 22:44:08 +0100 Subject: [PATCH 1/2] [DescriptionFragment] Fix thumbnail size: width x height height x width was used before which is an uncommon order. --- .../newpipe/fragments/detail/BaseDescriptionFragment.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/schabi/newpipe/fragments/detail/BaseDescriptionFragment.java b/app/src/main/java/org/schabi/newpipe/fragments/detail/BaseDescriptionFragment.java index 4789b02e6..bd174a121 100644 --- a/app/src/main/java/org/schabi/newpipe/fragments/detail/BaseDescriptionFragment.java +++ b/app/src/main/java/org/schabi/newpipe/fragments/detail/BaseDescriptionFragment.java @@ -216,9 +216,9 @@ public abstract class BaseDescriptionFragment extends BaseFragment { || image.getWidth() != Image.WIDTH_UNKNOWN // if even the resolution level is unknown, ?x? will be shown || image.getEstimatedResolutionLevel() == Image.ResolutionLevel.UNKNOWN) { - urls.append(imageSizeToText(image.getHeight())); - urls.append('x'); urls.append(imageSizeToText(image.getWidth())); + urls.append('x'); + urls.append(imageSizeToText(image.getHeight())); } else { switch (image.getEstimatedResolutionLevel()) { case LOW -> urls.append(getString(R.string.image_quality_low)); From e358867da8449ebe9a6fe338d2a67423437fa728 Mon Sep 17 00:00:00 2001 From: tobigr Date: Sat, 7 Feb 2026 12:35:45 +0100 Subject: [PATCH 2/2] Use dedicated constants for unknown image dimensions in ImageStrategy --- .../org/schabi/newpipe/util/image/ImageStrategy.kt | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/org/schabi/newpipe/util/image/ImageStrategy.kt b/app/src/main/java/org/schabi/newpipe/util/image/ImageStrategy.kt index c7e94c7f8..d9d7a3c07 100644 --- a/app/src/main/java/org/schabi/newpipe/util/image/ImageStrategy.kt +++ b/app/src/main/java/org/schabi/newpipe/util/image/ImageStrategy.kt @@ -186,7 +186,15 @@ object ImageStrategy { fun dbUrlToImageList(url: String?): List { return when (url) { null -> listOf() - else -> listOf(Image(url, -1, -1, ResolutionLevel.UNKNOWN)) + + else -> listOf( + Image( + url, + Image.HEIGHT_UNKNOWN, + Image.WIDTH_UNKNOWN, + ResolutionLevel.UNKNOWN + ) + ) } } }