From 9c03e4dcf56e1f3a96c5c61c698c841a112e14b3 Mon Sep 17 00:00:00 2001 From: "Yevhen Babiichuk (DustDFG)" Date: Tue, 10 Feb 2026 20:55:14 +0200 Subject: [PATCH] Show toast "checking for update..." every time user starts manual check When user toggles auto updates in settings it will firstly show "check for update..." toast as like if user presses to button of manual check. It adds consistency and allows to reuse manual check in other places of the app --- app/src/main/java/org/schabi/newpipe/NewVersionWorker.kt | 9 +++++++++ .../schabi/newpipe/settings/UpdateSettingsFragment.java | 2 -- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/schabi/newpipe/NewVersionWorker.kt b/app/src/main/java/org/schabi/newpipe/NewVersionWorker.kt index fb48d3f70..2967ca0a8 100644 --- a/app/src/main/java/org/schabi/newpipe/NewVersionWorker.kt +++ b/app/src/main/java/org/schabi/newpipe/NewVersionWorker.kt @@ -175,6 +175,15 @@ class NewVersionWorker( */ @JvmStatic fun enqueueNewVersionCheckingWork(context: Context, isManual: Boolean) { + if (isManual) { + ContextCompat.getMainExecutor(context).execute { + Toast.makeText( + context, + R.string.checking_updates_toast, + Toast.LENGTH_SHORT + ).show() + } + } val workRequest = OneTimeWorkRequestBuilder() .setInputData(workDataOf(IS_MANUAL to isManual)) .build() diff --git a/app/src/main/java/org/schabi/newpipe/settings/UpdateSettingsFragment.java b/app/src/main/java/org/schabi/newpipe/settings/UpdateSettingsFragment.java index 8923972b0..8a422ee9f 100644 --- a/app/src/main/java/org/schabi/newpipe/settings/UpdateSettingsFragment.java +++ b/app/src/main/java/org/schabi/newpipe/settings/UpdateSettingsFragment.java @@ -3,7 +3,6 @@ package org.schabi.newpipe.settings; import android.app.AlertDialog; import android.content.Context; import android.os.Bundle; -import android.widget.Toast; import androidx.preference.Preference; import androidx.preference.PreferenceManager; @@ -25,7 +24,6 @@ public class UpdateSettingsFragment extends BasePreferenceFragment { }; private final Preference.OnPreferenceClickListener manualUpdateClick = preference -> { - Toast.makeText(getContext(), R.string.checking_updates_toast, Toast.LENGTH_SHORT).show(); NewVersionWorker.enqueueNewVersionCheckingWork(requireContext(), true); return true; };