From fbc664d0dae79bafd0379ea48085b1a821985e88 Mon Sep 17 00:00:00 2001 From: jianing liu Date: Sun, 12 Oct 2025 02:03:38 +0800 Subject: [PATCH] [player] Prevent long audio track label from pushing controls off-screen MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - audioTrackTextView: layout_width=0dp + layout_weight=1 - Make it singleLine with ellipsize="end" - When not fullscreen, hide metadataView so an empty weighted container doesn’t reserve space - Result: controls stay visible on small screens; longer labels can use space on larger screens --- .../main/java/org/schabi/newpipe/player/ui/MainPlayerUi.java | 2 ++ app/src/main/res/layout/player.xml | 5 ++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/org/schabi/newpipe/player/ui/MainPlayerUi.java b/app/src/main/java/org/schabi/newpipe/player/ui/MainPlayerUi.java index d8efb30df..b79ef9235 100644 --- a/app/src/main/java/org/schabi/newpipe/player/ui/MainPlayerUi.java +++ b/app/src/main/java/org/schabi/newpipe/player/ui/MainPlayerUi.java @@ -289,6 +289,7 @@ public final class MainPlayerUi extends VideoPlayerUi implements View.OnLayoutCh binding.topControls.setClickable(true); binding.topControls.setFocusable(true); + binding.metadataView.setVisibility(isFullscreen ? View.VISIBLE : View.GONE); binding.titleTextView.setVisibility(isFullscreen ? View.VISIBLE : View.GONE); binding.channelTextView.setVisibility(isFullscreen ? View.VISIBLE : View.GONE); } @@ -934,6 +935,7 @@ public final class MainPlayerUi extends VideoPlayerUi implements View.OnLayoutCh } fragmentListener.onFullscreenStateChanged(isFullscreen); + binding.metadataView.setVisibility(isFullscreen ? View.VISIBLE : View.GONE); binding.titleTextView.setVisibility(isFullscreen ? View.VISIBLE : View.GONE); binding.channelTextView.setVisibility(isFullscreen ? View.VISIBLE : View.GONE); binding.playerCloseButton.setVisibility(isFullscreen ? View.GONE : View.VISIBLE); diff --git a/app/src/main/res/layout/player.xml b/app/src/main/res/layout/player.xml index 11a525632..4e5cd8533 100644 --- a/app/src/main/res/layout/player.xml +++ b/app/src/main/res/layout/player.xml @@ -160,12 +160,15 @@