Profpatsch
06cf511188
PlayerHolder: improve interface docstrings
2025-06-05 13:52:04 +02:00
Profpatsch
26050d808e
VideoPlayerUi: suppress warnings
...
The `R.id` link from the comment cannot be resolved, so let’s not link
it for now.
We are using some exoplayer2 resources, let’s silence the warning.
2025-06-05 13:52:04 +02:00
Profpatsch
0b32738d42
VideoDetailFragment: remove duplicate code in startLoading
2025-06-05 13:52:04 +02:00
Profpatsch
c37db85b97
VideoDetailFragment: apply more IDE suggestions
2025-06-05 13:52:04 +02:00
Profpatsch
4d6e1a4ecf
VideoDetailFragment: apply visibility suggestions
...
Because the class is final, protected does not make sense (Android
Studio auto-suggestions)
2025-06-05 13:52:04 +02:00
Profpatsch
b5dd49ecd3
PlayerService: simplify nullable calls, getters
2025-06-05 13:52:04 +02:00
Profpatsch
945fbd884b
PlayerService: Convert to kotlin (mechanical)
2025-06-05 13:52:04 +02:00
Profpatsch
545c4f078f
PlayerUIList: restrict superclasses a little
2025-06-05 13:52:04 +02:00
Isira Seneviratne
f41b34c090
Merge pull request #11759 from Isira-Seneviratne/Import-export-worker
...
Rewrite import and export subscriptions functionality using coroutines
2025-05-16 01:16:34 +05:30
Profpatsch
a8da9946d1
PlayerUiList: guard list actions with mutex
...
The new implementation would throw `ConcurrentModificationExceptions`
when destroying the UIs. So let’s play it safe and put the list behind
a mutex.
Adds a helper class `GuardedByMutex` that can be wrapped around a
property to force all use-sites to acquire the lock before doing
anything with the data.
2025-05-11 15:23:03 +02:00
Profpatsch
3d069cdf5b
PlayerUIList: rename get to getOpt and make get nullable
...
In Kotlin, dealing with nulls works better so we don’t need optional.
2025-05-11 15:12:37 +02:00
Profpatsch
eccedc0ab0
PlayerUIList: transform to kotlin
...
And simplify the code a little
2025-05-11 15:06:52 +02:00
Stypox
7cecda5713
Merge branch 'dev' into refactor
...
Had to make some adjustments to make https://github.com/TeamNewPipe/NewPipe/pull/12188 work
2025-05-08 15:34:00 +02:00
Profpatsch
862a8e8f26
Merge pull request #12188 from VougJo23/commentsfix
...
fix: support RTL usernames in comment header
2025-05-07 12:20:23 +02:00
VougJo23
8d679626f0
fix: support RTL usernames in comment header
...
The `@` gets added by the youtube API and thus is a fixed member of
the username, so we do some simple detection logic to handle that
case (otherwise the `@` will be at the right side of a RTL username,
which is different of how Youtube displays these usernames in the
browser).
Fixes https://github.com/TeamNewPipe/NewPipe/issues/12141
2025-05-07 12:05:09 +02:00
Andriana
e7f3750f5e
Fix timestamps not working in comment replies
...
Use LinkMovementMethodCompat for comment links
Co-authored-by: Isira Seneviratne <31027858+Isira-Seneviratne@users.noreply.github.com>
Update import
Use LongPressLinkMovementMethod
2025-05-06 17:12:17 +02:00
j-haldane
48e826e912
Fix header crash in History List view ( #12214 )
...
* Adapt header handling changes from other recyclerview adapters to fix issue #4475 in StatisticsPlaylistFragment
* Remove unneeded LayoutInflater
* Revert "Remove unneeded LayoutInflater"
This reverts commit ab73dc1e7290f9e133435222bf35dee54de837f4.
* Revert "Adapt header handling changes from other recyclerview adapters to fix issue #4475 in StatisticsPlaylistFragment"
This reverts commit 2abe71cc986114000ecdd14aaa17850f60b9549c.
* Remove header animation causing view recycling issue
2025-05-06 17:07:45 +02:00
Isira Seneviratne
b6144d01f3
Merge branch 'refactor' into Import-export-worker
2025-04-29 10:18:13 +05:30
Isira Seneviratne
cbe598182a
Merge branch 'refactor' into Import-export-worker
2025-04-20 07:10:07 +05:30
Isira Seneviratne
7615f79aca
Merge branch 'dev' into Merge-dev-to-refactor
...
# Conflicts:
# app/src/main/java/org/schabi/newpipe/settings/ContentSettingsFragment.java
2025-04-14 07:29:30 +05:30
Stypox
276bf390b2
Merge pull request #12117 from malania02/dev
...
Show download date of downloaded videos
2025-04-11 20:17:27 +02:00
Stypox
756327da39
Merge pull request #12093 from mileskrell/mileskrell/support-per-app-language-preferences
...
Support per-app language preferences
2025-04-08 23:13:07 +02:00
Isira Seneviratne
6486f2de56
Merge branch 'dev' into Merge-dev-to-refactor
...
# Conflicts:
# app/build.gradle
# app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java
# app/src/main/java/org/schabi/newpipe/local/feed/notifications/NotificationHelper.kt
# app/src/main/java/org/schabi/newpipe/player/PlayQueueActivity.java
# app/src/main/java/org/schabi/newpipe/player/PlayerService.java
# app/src/main/java/org/schabi/newpipe/player/event/PlayerServiceExtendedEventListener.java
# app/src/main/java/org/schabi/newpipe/player/helper/PlayerHolder.java
# app/src/main/res/values-is/strings.xml
2025-04-08 05:42:31 +05:30
FineFindus
e1dedd45ed
[YouTube] Access first element if array size is one
...
Fixes a regression, where if the challenge data array size was one, the second element
would be accessed, leading to a crash.
This was introduced when porting the challenge parsing from JS to
Kotlin.
Ref: 53b599b042
2025-04-02 22:14:01 +02:00
malania02
912f07a1dd
Missing lines added
2025-03-30 14:50:05 +02:00
Miles Krell
205466c56a
Move call to setApplicationLocales
2025-03-27 19:14:41 -04:00
Miles Krell
7f10312d0a
Move migration to NewPipeSettings
2025-03-23 17:39:21 -04:00
malania02
63be3220e7
Show download date
2025-03-22 16:19:26 +01:00
Stypox
196c27792b
Merge pull request #12044 from TeamNewPipe/android-auto
...
Add support for Android Auto *(season 2)*
2025-03-21 11:21:58 +01:00
Miles Krell
c7bf498c04
Don't show toast because of changing content language or country
2025-03-16 20:27:05 -04:00
Miles Krell
35abb99dac
Only show toast on Android <13
2025-03-16 20:15:38 -04:00
Miles Krell
70416e73f3
Move app language setting migration to SettingMigrations
2025-03-16 19:24:04 -04:00
Siddhesh Naik
f289bea6b3
Fix sonar warning
2025-03-16 12:44:05 +05:30
Harshita
48b200868a
BF-11894 : Fix the menu disappearing on performing backGesture
2025-03-16 12:44:05 +05:30
Harshita
54bf7f0ced
BF-11894 : Fix the Duplicate menu options in ChannelFragment
2025-03-16 12:44:05 +05:30
Miles Krell
980a35a708
Move migration to separate method
2025-03-15 23:00:31 -04:00
Miles Krell
da106e2361
Don't try to migrate "system" app language
2025-03-15 22:54:17 -04:00
Miles Krell
3532ac96b4
Migrate from pre-Android 13 app language pref
2025-03-15 22:13:01 -04:00
Miles Krell
87693a2ad1
Redirect to per-app language settings on Android 13+
2025-03-15 21:56:02 -04:00
Tobi
fb4a65a14a
Merge pull request #12043 from TeamNewPipe/hide-view-logs
...
Disable logs about view animations by default
2025-03-15 17:17:59 +01:00
Stypox
3047704e1c
Merge pull request #12089 from mileskrell/mileskrell/fix-audio-track-labels
...
Disambiguate audio track labels
2025-03-15 12:45:20 +01:00
Stypox
3dcfdaf510
Merge pull request #12065 from tfga/YouTubeTemporaryPlaylist
...
Share as YouTube temporary playlist
2025-03-15 10:11:59 +01:00
Thiago F. G. Albuquerque
2ceb70236e
sharePlaylist(): converting javadoc from Markdown back to "classic javadoc"
...
(request from @Stypox)
2025-03-14 21:56:42 -03:00
Thiago F. G. Albuquerque
be097f26c8
Deleting the "explanatory text" bellow the title
...
<string name="share_playlist_with_titles_message">Share playlist with details such as playlist name and video titles or as a simple list of video URLs</string>
Share playlist with details such as playlist name and video titles or as a simple list of video URLs</string>
(Discussion: https://github.com/TeamNewPipe/NewPipe/pull/12065#discussion_r1994349485 )
2025-03-13 19:10:26 -03:00
Thiago F. G. Albuquerque
098f60d593
Don't add the title when sharing as YouTube temp playlist
2025-03-13 18:16:09 -03:00
Thiago F. G. Albuquerque
f3b3d5c3e7
R.string.share_playlist_as_youtube_temporary_playlist
2025-03-12 19:08:09 -03:00
Thiago F. G. Albuquerque
599d86151a
Making ktLint happy
2025-03-11 21:26:58 -03:00
Thiago F. G. Albuquerque
f96b8f7b2a
Comment: maximum length of 50 items
...
(PR review from @Stypox)
2025-03-11 20:19:54 -03:00
Thiago F. G. Albuquerque
c28478ae53
getYouTubeId(): Changing implementation to use YoutubeStreamLinkHandler
...
(PR review from @Stypox)
2025-03-11 20:12:25 -03:00
Miles Krell
10110397fd
Use display name instead of only the language
2025-03-10 22:01:09 -04:00
