litetex
2886bc3b01
Merge pull request #4833 from vkay94/youtube-rewind-forward
...
YouTube's Fast Forward/Rewind behavior
2022-01-30 17:07:15 +01:00
Stypox
17c0fffd73
Merge pull request #7538 from ktprograms/fix-queue-channel-details-not-in-db
...
Load uploaderUrl when showing Channel Details from Play Queue
2022-01-26 09:58:32 +01:00
litetex
af79479716
Fixed "Changing the seeks duration does not update the displayed seconds"
2022-01-25 20:44:49 +01:00
ktprograms
1e652b159e
Load uploaderUrl when showing Channel Details from Play Queue
...
This checks if the uploaderUrl is in the database, if not it gets the
uploaderUrl and puts it in the database. This is similar to the fetching
of uploaderUrl when it doesn't exist done in #6919 .
Also use createNotification when error occurs in getStreamInfo.
2022-01-25 11:00:34 +08:00
TiA4f8R
ea07d7751b
Fix first item played in playlists when switching player type or resolution
...
The issue was caused by an ExoPlayer change, which when setting a media source, resets the current playback position and the current window index by default.
Also set player recovery in more places to fix playback position not propely set in some cases after a player type switch.
2022-01-24 21:40:16 +01:00
litetex
e127db6fa6
Simplified toast showing behavior
...
after feedback from the review
2022-01-23 15:34:11 +01:00
litetex
49b1649348
Revert "Merge pull request #7568 from vhouriet/vhouriet_feature_already-playing-in-backgroud"
...
This reverts commit ee19ea66b3f4f182f78634c2d791dab6cab77257, reversing
changes made to 6b490ee547879033ec3e7d9ca3433f35babbfa7b.
2022-01-23 15:34:11 +01:00
litetex
54ef604569
Improved docs
2022-01-21 22:49:25 +01:00
litetex
30ce906f72
Apply seek conditions based on direction
...
* When rewinding: Check if <0,5s
* When fast-forwarding: Check if player has completed or the current playback has ended
This allows rewinding on the endscreen
2022-01-21 22:49:25 +01:00
litetex
1c20eabb48
Code cleanup
2022-01-21 22:49:25 +01:00
litetex
f8c52c4dac
Fixed SonarLint problems
...
* Removed alphaRelativeDuration as there is no use for it
2022-01-21 22:49:24 +01:00
litetex
345ba74d58
Fixed naming
2022-01-21 22:49:24 +01:00
litetex
d2aaf152a0
Removed related import
2022-01-21 22:49:24 +01:00
litetex
7bf1f3dba6
Removed unused field
2022-01-21 22:49:24 +01:00
litetex
452fe3a8e2
Respect disabled animations
2022-01-21 22:49:24 +01:00
litetex
c25e523df6
Removed all animations to be consistent with the current behavior
2022-01-21 22:49:23 +01:00
litetex
65bb1dcdbf
Refactored code
2022-01-21 22:49:23 +01:00
litetex
fe42206e94
Code cleanup and minimization
...
* Deduplicated and simplified a lot of code
* Fixed ``invalidSeekConditions`` so that it's possible to seek while the player is loading (like currently the case)
2022-01-21 22:49:23 +01:00
TobiGr
dac47d9f52
Replace NotNull annotation with NonNull annotation
2022-01-21 22:49:23 +01:00
Stypox
83a3d11f38
Small improvements to player
2022-01-21 22:49:22 +01:00
Stypox
a454a41b51
Fix controls not hiding correctly when switching player
2022-01-21 22:49:22 +01:00
Stypox
95631dba46
Convert SecondsView from kotlin synthetics to view binding
2022-01-21 22:49:22 +01:00
vkay94
3aebfa22e9
SeekOverlay: Switch to merge for SecondsView and other adjustments
2022-01-21 22:49:21 +01:00
vkay94
72eb3b4415
SeekOverlay: Add seek overlay logic to player
2022-01-21 22:49:21 +01:00
vkay94
3a40759cd2
SeekOverlay: Add Views
2022-01-21 22:49:21 +01:00
XiangRongLin
cd265fc31f
Make SearchHistoryEntry.kt fields nullable to match java version ( #7674 )
2022-01-21 16:01:11 +00:00
litetex
f681b0bb5a
Merge pull request #7648 from mhmdanas/small-refactors
...
Fix false warning
2022-01-19 19:48:07 +01:00
XiangRongLin
d7fbddf6f8
Merge pull request #7668 from litetex/fix-video-reset-on-player-switch
...
Workaround: Set recovery before switching player
2022-01-19 16:45:10 +01:00
mhmdanas
402990dd9d
Fix false warning
2022-01-18 07:40:59 +03:00
litetex
41faf70da1
Workaround: Set recovery before switching player
...
Quick fix
2022-01-17 20:52:07 +01:00
litetex
15e3b6301c
Merge pull request #7662 from TiA4f8R/fix-npe-share-button-playlists
...
Fix crash when sharing a playlist which is loading
2022-01-16 19:47:55 +01:00
XiangRongLin
5b9c28b93b
Replace JUnit asserts with AssertJ in HistoryRecordManagerTest ( #7654 )
...
* Replace JUnit asserts with AssertJ in HistoryRecordManagerTest
They provide a wider range of assertions, which allow for more detailed error messages.
Also convert SearchHistoryEntry to kotlin data class for better error messages, since toString() is implemented.
Co-authored-by: Mohammed Anas <triallax@tutanota.com>
2022-01-16 09:10:45 +01:00
TiA4f8R
6672169707
Fix NullPointerException when sharing a playlist which is loading
...
Prevent a NullPointerException by adding a null check for currentInfo when sharing a playlist.
2022-01-15 21:19:04 +01:00
Stypox
7907182e7e
Merge pull request #7036 from Douile/fix/queue-metadata
...
Load full stream info when enqueuing a stream
2022-01-07 21:57:30 +01:00
Douile
064242d962
Remove unecessary interface InfoCallback
...
Co-authored-by: Stypox <stypox@pm.me>
Replace the unecessary callback interface InfoCallback in favour of the
standard type Consumer<SinglePlayQueue>
2022-01-03 17:52:27 +00:00
litetex
ddcbe27fd3
Fixed search not accepting key input after closing player overlay ( #7607 )
...
* Fixed search not accepting key input after closing player overlay
* Made comments easier to understand
* More comments
2022-01-03 11:52:08 +01:00
litetex
ee19ea66b3
Merge pull request #7568 from vhouriet/vhouriet_feature_already-playing-in-backgroud
...
Add Already playing in background toast
2021-12-31 14:54:05 +01:00
litetex
6b490ee547
Merge pull request #7582 from Jaspann/sub-channel-tumbnail-view-fix
...
Fixes view of sub-channel icon when not in use
2021-12-31 14:52:32 +01:00
Jaspann
558c9147a2
Move sub icon visibility line
2021-12-28 15:54:36 -05:00
litetex
fc0e709817
Fixed usage of wrong string
2021-12-27 00:14:04 +01:00
litetex
b67bf16d4f
Minified code
2021-12-26 23:57:54 +01:00
William Parker
fb3be544ce
Fixed code styling
2021-12-26 00:12:48 -05:00
Jaspann
53f5741317
Fixes view of sub-channel icon when not in use
2021-12-25 18:10:05 -05:00
David Kramer
07015973d2
Added ability to see pinned comment
2021-12-24 11:29:34 -06:00
Tobi
215880207e
Merge pull request #7562 from TeamNewPipe/code-quality
...
Small improvements to code quality and readability
2021-12-23 23:54:29 +01:00
vhouriet
989bcbf895
Add Already playing in background toast
2021-12-23 22:12:38 +01:00
XiangRongLin
05370dbb94
Merge pull request #7556 from Jaspann/improve-hashtags
...
Fixes hashtags that use non-English characters.
2021-12-23 11:45:52 +01:00
Robin
f6cad2d9cf
Merge pull request #7555 from litetex/remove-mediaparser
...
Remove/Revert MediaParser support (Android 11+) due to bugs
2021-12-22 17:32:28 +01:00
TobiGr
37b8a9375f
Small improvements to code quality and readability
...
Add annotations to methods and parameters.
Replace Jetbrains' @NotNull with Androidx' @NonNull annotatiation.
Make class variables static if possible.
Use constants for some Strings.
Simplify if conditions.
2021-12-21 20:55:41 +01:00
TobiGr
d71af9a625
Introduce constants for some Strings that indicate no data in Tab class
2021-12-21 20:53:17 +01:00