Profpatsch
fd24c08529
Player/handleIntent: de morgan samePlayQueue
...
Okay, so this is the … only? branch in this if-chain that will
conditionally fire if `playQueue` *is* `null`, sometimes.
This is why the unconditional `initPlayback` in `else` is not passed a
`null` in many cases … because `RESUME_PLAYBACK` is `true` and
`playQueue` is `null`.
It’s gonna be hard to figure out which parts of that are intentional,
I say.
2025-09-06 15:04:06 +02:00
Profpatsch
e14ec3a4f9
NavigationHelper: inline trivial getPlayerIntent use
2025-09-06 15:04:06 +02:00
Profpatsch
b592403a66
NavigationHelper: push out resumePlayback one layer
2025-09-06 15:04:06 +02:00
Profpatsch
90e1ac56ef
NavigationHelper: inline getPlayerEnqueueIntent
...
Funnily enough, I’m pretty sure that whole comment will be not
necessary, because we never check `resumePlayback` on handling the
intent anyway.
2025-09-06 15:04:06 +02:00
Profpatsch
32eb3afe16
Player/handleIntent: a few comments
2025-09-06 15:04:06 +02:00
Profpatsch
35c7f2f5d1
Player: Remove unused IS_MUTED intent key
...
The only use of the key was removed in commit
2a2c82e73bb2380c07ab848b185952ab183a5502
but the handling logic stayed around. So let’s get rid of it.
2025-09-05 16:57:27 +02:00
Stypox
f27ec53c08
Even more centralized error handling in ErrorInfo
2025-09-05 12:39:16 +02:00
Stypox
a3ddd616f9
Merge pull request #12578 from Stypox/better-error-messages
2025-09-04 13:18:40 +02:00
Stypox
79980e2078
Address PR reviews
2025-09-04 13:17:45 +02:00
Isira Seneviratne
b204fad9d5
Merge pull request #12471 from Isira-Seneviratne/Fix-notifications
...
Fix foreground service issues
2025-09-01 05:05:47 +05:30
Isira Seneviratne
08f51abefb
Added comments
2025-08-31 22:25:12 +05:30
Stypox
989c0cfd28
Fix REPORT in snackbar not opening ErrorActivity if MainActivity not shown
...
Bug caused by https://github.com/TeamNewPipe/NewPipe/pull/11789
2025-08-30 14:39:23 +02:00
Stypox
a369deeef4
Allow ErrorInfo messages with formatArgs
...
- ErrorInfo.getMessage() now returns an ErrorMessage instance that can be formatted into a string using a context (this allows the construction of an ErrorInfo to remain independent of a Context)
- now the service ID is used in ErrorInfo.getMessage() to customize some messages based on the currently selected service
- player HTTP invalid statuses are now included in the message
- building a custom error message for AccountTerminatedException was moved from ErrorPanelHelper to ErrorInfo
2025-08-30 14:36:27 +02:00
Stypox
1bde2dcd9f
Fix ordering of error messages conditions
2025-08-28 17:06:10 +02:00
Stypox
29a3ca83b5
Show better information about player errors
2025-08-28 17:06:09 +02:00
Stypox
38064be702
Add more specific error messages and deduplicate their handling
2025-08-28 17:05:52 +02:00
TobiGr
74562db965
Use androidx compat alert dialog
2025-08-27 11:45:31 +02:00
Profpatsch
386d5197d8
Permission: display explanatory dialog for Android > R
...
On Android > R, ACTION_MANAGE_OVERLAY_PERMISSION always brings the
user to the app selection screen.
https://developer.android.com/about/versions/11/privacy/permissions#manage_overlay
This is highly confusing behaviour from the system, so let’s add an
instruction before navigating to the settings menu.
2025-08-27 11:38:25 +02:00
Tobi
ff3526b28d
Merge pull request #12460 from Isira-Seneviratne/Short-count-refactor
...
Fix short count formatting for Android versions below 7.0
2025-08-01 10:56:41 -07:00
Stypox
124ab56c5f
Merge branch 'master' into dev
2025-07-31 23:52:01 +02:00
Stypox
b7b836e941
Update the names of YT kiosks
2025-07-31 23:43:19 +02:00
Stypox
d96c0aebb1
Show tabs above kiosks in drawer
2025-07-31 23:43:19 +02:00
Stypox
8400a9ae8e
Remove DEBUG statements and don't replace yt trending with live
...
You can use this command to test instead:
adb shell run-as org.schabi.newpipe.debug.pr12450 'sed -i '"'"'s#<int name="last_used_preferences_version" value="8" />#<int name="last_used_preferences_version" value="6" />#'"'"' shared_prefs/org.schabi.newpipe.debug.pr12450_preferences.xml' && adb shell run-as org.schabi.newpipe.debug.pr12450 'sed -i '"'"'s#\]}</string>#,{\"tab_id\":5,\"service_id\":0,\"kiosk_id\":\"Trending\"},{\"tab_id\":5,\"service_id\":1,\"kiosk_id\":\"Top 50\"}]}</string>#'"'"' shared_prefs/org.schabi.newpipe.debug.pr12450_preferences.xml'
2025-07-31 23:43:19 +02:00
Stypox
7cecd11f72
[YouTube] Add icons and strings for new trending pages
2025-07-31 23:43:19 +02:00
TobiGr
ed93603815
WIP: Add SettingsMigration to change YouTube trending kiosk tab
2025-07-31 23:43:19 +02:00
Stypox
56f79fac13
Merge branch 'release-0.28.0' into dev
2025-07-30 11:42:06 +02:00
Isira Seneviratne
ef29c318b0
Remove NewApi suppression
2025-07-29 06:18:27 +05:30
Stypox
e9922fe162
Merge pull request #12470 from litetex/cleanup-PlayerHelper-localization
2025-07-28 15:30:07 +02:00
Stypox
eea2b7417e
Fix player formatters resetting too early on language change
...
formatters() is called again by the player before the user has a chance to click on the language in the language chooser.
So the correct solution would probably be to attach to https://developer.android.com/reference/android/content/Intent#ACTION_LOCALE_CHANGED , but let's keep it simple. I added `PlayerHelper.resetFormat();` in `ContentSettingsFragment.onDestroy()` and it works. It will mean the player formatters will be reset every time the user exits content settings, but whatever.
2025-07-28 15:29:06 +02:00
litetex
893a1cb699
Encapsulate Formatters in PlayerHelper
...
and reset them when the language is changed/changing.
This way they will be re-initialized on the next call.
Also Remove a bunch of outdated/non-thread safe code (STRING_FORMATTER)
2025-07-28 15:11:27 +02:00
litetex
ebd5e1a318
Remove unused method
2025-07-28 15:11:27 +02:00
litetex
70841db92f
Cleanup `Localization` formatting
2025-07-28 15:11:27 +02:00
litetex
859555e129
Use regions
2025-07-28 15:11:27 +02:00
Stypox
c1cef19b33
Merge pull request #12455 from TobiGr/nextPage-nullable
2025-07-28 14:52:08 +02:00
Stypox
9ba30887f9
Improve null checking further in SearchFragment.handleNextItems
2025-07-28 14:43:46 +02:00
Isira Seneviratne
9f11db8e06
Improve scale display
2025-07-28 09:02:52 +05:30
Isira Seneviratne
fece0741e5
Suppress NewApi
2025-07-27 15:47:06 +05:30
TobiGr
a9ce2e9605
Update USER_AGENT to Firefox 140 ESR
2025-07-27 09:39:53 +02:00
Isira Seneviratne
b9b47fc520
Update manifest, startForeground call
2025-07-27 11:58:01 +05:30
Isira Seneviratne
59db955493
Fix new streams notification issue
2025-07-27 11:31:23 +05:30
Isira Seneviratne
9f526e8e8f
Fix short count formatting for Android versions below 7.0
2025-07-24 07:56:44 +05:30
Michael Zh
50caba6606
Fix compile
...
Co-Authored-By: Isira Seneviratne <31027858+Isira-Seneviratne@users.noreply.github.com>
2025-07-23 18:49:28 -04:00
Michael Zh
26443f9f14
WIP: Fix compile
2025-07-23 18:45:30 -04:00
Michael Zh
366129eee2
Fix error toast crash
2025-07-23 18:45:30 -04:00
Michael Zh
04ef608f7a
Specify RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED for sdk34
2025-07-23 18:45:30 -04:00
TobiGr
30e33d59e8
Use correct fix for nextPage being null while creating error report in SearchFragment.handleNextItems()
2025-07-22 16:12:02 +02:00
Kouki Badr
a4bd82be8a
fix: handle nullable nextPage behavior when searching albums #12401 ( #12408 )
...
* fix: handle nullable nextPage behavior when searching albums #12401
* feat: add nullable annotation to newPage attribute in SearchFragment
* Updated more usages of InfoItemsPage#getNextPage. Nullability is already handled in these areas so no other changes needed
---------
Co-authored-by: Siddhesh Naik <siddheshnaik20@protonmail.com>
2025-07-22 08:58:56 +05:30
litetex
f48e73eb2a
Cleaned up some code related to app language
...
* Use build constants when possible
* Inline variables
* Don't use var for normal-sized types (that way it's easier to review)
* Split code into methods
2025-07-20 21:52:07 +02:00
Isira Seneviratne
99003bab07
Clean up imports
2025-07-20 16:43:37 +05:30
Isira Seneviratne
9e14f93186
Properly handle when system language is selected
2025-07-20 16:27:07 +05:30
