Profpatsch
fd99c5e461
MainActivity: Fix onBackPressed handling for open player
...
The change
b9dd7078ad3ae2ac1c20969fdd8b97736026b7dc
accidentally moved the `return` into the `{}`, so the logic would fall
through to
```
if (fragmentManager.getBackStackEntryCount() == 1) {`
```
and close the app even though there are still items on the
`VideoFragmentDetail` stack.
To reproduce:
Start video, enqueue another video, then start a third video (which
adds one entry to the stack), and press `back` on the expanded video.
This should keep the player open and go back to the first 2-video
queue, but it actually closes the app before this fix.
2025-01-30 19:40:44 +01:00
Stypox
407d2d768d
Merge pull request #11539 from Isira-Seneviratne/Compose-theme-improvements
...
Compose theme improvements
2025-01-28 14:02:50 +01:00
Profpatsch
b109e4d3cc
Merge pull request #11867 from Profpatsch/player-holder-refactor
...
PlayerHolder refactor
2025-01-27 13:29:53 +01:00
Profpatsch
137ade24ff
Adjust javadoc format
2025-01-27 12:45:30 +01:00
Isira Seneviratne
b78e0b2da8
Merge branch 'refactor' into Compose-theme-improvements
2025-01-25 09:41:29 +05:30
Profpatsch
ce919215fb
PlayerHolder: Separate holder and service event interface
...
Should make it easier to seperate the two further later, both of them
are only implemented by VideoDetailFragment anyway, which is kind of a
code smell!
2024-12-26 01:31:17 +01:00
Profpatsch
6a4aaba431
PlayerHolder: add some more docstrings
2024-12-26 01:02:59 +01:00
Profpatsch
83d93e16e7
PlayerHolder: move unbind right next to stopService
2024-12-26 00:36:49 +01:00
Profpatsch
8d15a141b1
PlayerHolder: invert isBound
2024-12-26 00:26:59 +01:00
Profpatsch
a78bed700a
PlayerHolder: inline bind
...
Only used once. Now the code looks weird … why is the service started
twice??
2024-12-26 00:26:22 +01:00
Profpatsch
ef3c76645f
PlayerHolder/PlayerService: inline & remove duplicate player passing
...
The player in playerHolder is exactly the player inside the
`PlayerService`, which in turn is exactly passed through the IBinder
interface. Thus we don’t have to pass both.
Instead add `PlayerService.getPlayer()`.
Also inline a few methods of `PlayerHolder` and simplify.
2024-12-25 22:14:22 +01:00
Isira Seneviratne
d4ed18bf08
Merge branch 'dev' into Merge-dev
...
# Conflicts:
# app/build.gradle
# app/src/main/java/org/schabi/newpipe/App.java
# app/src/main/java/org/schabi/newpipe/about/AboutActivity.kt
# app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java
# app/src/main/java/org/schabi/newpipe/fragments/list/channel/ChannelFragment.java
# app/src/main/java/org/schabi/newpipe/fragments/list/comments/CommentRepliesFragment.java
# app/src/main/java/org/schabi/newpipe/fragments/list/videos/RelatedItemsFragment.java
# app/src/main/java/org/schabi/newpipe/local/bookmark/BookmarkFragment.java
# app/src/main/res/values-bg/strings.xml
# app/src/main/res/values-da/strings.xml
# app/src/main/res/values-is/strings.xml
# app/src/main/res/values-lv/strings.xml
# app/src/main/res/values-zh-rTW/strings.xml
# build.gradle
2024-12-21 07:45:20 +05:30
Isira Seneviratne
1547b50b4e
Merge branch 'refactor' into Compose-theme-improvements
2024-11-28 06:12:33 +05:30
Stypox
3f7ef49979
NewPipe license is GPLv3-or-later, not -only, in AboutScreen
2024-11-27 22:15:23 +01:00
Stypox
52942ffd30
Merge pull request #11738 from cillyvms/a13-player-notifs
...
Always allow changing player notification preferences on Android 13+
2024-11-27 19:12:19 +01:00
Stypox
e4b0245530
Merge pull request #11734 from Thompson3142/fix_timestamp_popup_time
...
Fix player resuming from start when clicking on a timestamp
2024-11-27 18:38:49 +01:00
Stypox
dab0148a78
Merge pull request #11750 from Isira-Seneviratne/Fix-image-loading
...
Fix image loading
2024-11-27 16:50:38 +01:00
Stypox
b21981a9c7
Add comments to explain why openAndTruncateStream()
2024-11-27 16:34:50 +01:00
Stypox
aaf337421d
Merge branch 'refactor' into pr11282
2024-11-27 16:20:49 +01:00
Stypox
d56eef6ece
Use content padding instead of padding on container
2024-11-27 15:59:20 +01:00
Stypox
72f054a4fa
Library should not be clickable if spdx is blank
2024-11-27 15:46:39 +01:00
Isira Seneviratne
137ef3fee4
Fix image loading
2024-11-26 10:08:27 +05:30
Stypox
a25034b898
Fix toolbar colors in light theme
2024-11-25 04:43:43 +01:00
Stypox
ae9e82b2c1
Implement showing libraries and licenses
2024-11-25 04:43:43 +01:00
Isira Seneviratne
08f3dba42c
Merge branch 'refactor' into Compose-theme-improvements
...
# Conflicts:
# app/src/main/java/org/schabi/newpipe/ui/components/common/NoItemsMessage.kt
# app/src/main/java/org/schabi/newpipe/ui/components/video/comment/CommentRepliesDialog.kt
2024-11-25 07:22:03 +05:30
Thompson3142
f9711a3402
Removed call to setRecovery() entirely
2024-11-24 22:12:25 +01:00
Stypox
df941670a8
Fix downloading/exporting when overwriting file would not truncate
2024-11-24 18:36:54 +01:00
Stypox
57e66b17c6
Merge branch 'master' into dev
2024-11-24 17:43:45 +01:00
AudricV
dc3f55674f
Add support for secondary audio track type
2024-11-24 16:43:22 +01:00
Stypox
726c12e934
Only throttle YouTube feed loading
2024-11-24 16:22:19 +01:00
Stypox
0cff3a6ecd
Improve AboutTab spacing
2024-11-24 16:06:21 +01:00
Stypox
33b96d238a
Throttle loading subscriptions feed to avoid YouTube rate limits
2024-11-24 14:06:53 +01:00
cillyvms
213f49f5c4
Allow changing player notification preferences regardless of system settings on Android 13 and above.
2024-11-22 14:21:46 +01:00
Thompson3142
16c79c8219
Fixed player resuming from start when clicking on a timestamp
2024-11-21 22:42:42 +01:00
Isira Seneviratne
e6eea8f851
Merge branch 'refactor' into Compose-theme-improvements
2024-11-21 21:26:03 +05:30
Isira Seneviratne
4e55f1bee6
Merge branch 'refactor' into About-Compose
2024-11-21 21:11:52 +05:30
Stypox
cff3834fde
Fix setEmptyStateComposable dark theme
2024-11-21 13:17:33 +01:00
Stypox
c8b01a06b0
Use empty state view in compose
2024-11-21 13:14:39 +01:00
Stypox
414b1a8344
Remove unused methods in EmptyStateUtil
2024-11-21 13:14:19 +01:00
Stypox
404d9f3fac
Use empty state view in a few more places
2024-11-21 12:42:58 +01:00
Stypox
55e4014036
Use custom EmptyStateSpec for bookmark fragment
2024-11-21 12:24:11 +01:00
Stypox
1cd5563b27
All empty states now have the same style
2024-11-21 12:14:40 +01:00
Stypox
1abced992b
Use normal colors for empty state view
2024-11-21 12:07:03 +01:00
Stypox
46b9243661
Remove unneeded empty state changes in ChannelFragment
2024-11-21 11:53:48 +01:00
toliuweijing
ad72b2cb31
boost error hint color
2024-11-21 11:52:42 +01:00
toliuweijing
8b79d0ee29
Migrate empty_state_view to Jetpack Compose
2024-11-21 11:52:42 +01:00
Stypox
b584353f4d
Small fixes to code style
2024-11-21 10:52:15 +01:00
Isira Seneviratne
d73314b4dd
Make App instance variable immutable outside class
2024-11-21 08:09:57 +05:30
Isira Seneviratne
9f4a33c7a8
Fix lint
2024-11-21 06:56:10 +05:30
Isira Seneviratne
3a9540b042
Update app/src/main/java/org/schabi/newpipe/App.kt
...
Co-authored-by: Tobi <TobiGr@users.noreply.github.com>
2024-11-20 16:04:39 +05:30
