neoris/core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix returning wrong value for HasLimits

Browse Source
This commit is contained in:
Ingo Oppermann 2023-07-12 11:38:40 +02:00
parent 72d56be9af
commit 519f39b217
No known key found for this signature in database
GPG Key ID: 2AB32426E9DD229E
2 changed files with 24 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
resources/resources.go
View File

@ -72,7 +72,7 @@ func New(config Config) (Resources, error) {
logger: config.Logger,
}
if config.MaxCPU == 1000 && config.MaxMemory == 1000 {
if config.MaxCPU == 100 && config.MaxMemory == 100 {
r.isUnlimited = true
}
@ -217,7 +217,7 @@ func (r *resources) observe(ctx context.Context, interval time.Duration) {
}
func (r *resources) HasLimits() bool {
return r.isUnlimited
return !r.isUnlimited
}
func (r *resources) Limits() (float64, uint64) {

22
resources/resources_test.go
View File

@ -165,3 +165,25 @@ func TestRequest(t *testing.T) {
err = r.Request(10, 10)
require.NoError(t, err)
}
func TestHasLimits(t *testing.T) {
r, err := New(Config{
MaxCPU: 70.,
MaxMemory: 170. / 200. * 100,
PSUtil: &util{},
Logger: nil,
})
require.NoError(t, err)
require.True(t, r.HasLimits())
r, err = New(Config{
MaxCPU: 0,
MaxMemory: 0,
PSUtil: &util{},
Logger: nil,
})
require.NoError(t, err)
require.False(t, r.HasLimits())
}