From e6ac84306606803a4eaccd962b96e331e0aa970e Mon Sep 17 00:00:00 2001 From: Austin Tinius Date: Tue, 19 May 2020 00:32:18 -0700 Subject: [PATCH 1/3] Create nodejs.yml trying to get automatic builds going --- .github/workflows/nodejs.yml | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 .github/workflows/nodejs.yml diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml new file mode 100644 index 0000000..4cce9cf --- /dev/null +++ b/.github/workflows/nodejs.yml @@ -0,0 +1,28 @@ +name: Node.js CI + +on: + push: + branches: [ development ] + pull_request: + branches: [ developemnt ] + +jobs: + build: + + runs-on: ${{ matrix.os }} + + strategy: + matrix: + node-version: [10.x, 12.x] + os: [ubuntu-latest, macos-latest, windows-latest] + + steps: + - uses: actions/checkout@v2 + - name: Use Node.js ${{ matrix.node-version }} + uses: actions/setup-node@v1 + with: + node-version: ${{ matrix.node-version }} + - run: npm ci + - run: npm run build --if-present + - run: npm run compile + - run: npm run package From b271ce905c46e6b6b87e987d37aab1cbf7871c0c Mon Sep 17 00:00:00 2001 From: Austin Tinius Date: Tue, 19 May 2020 00:32:56 -0700 Subject: [PATCH 2/3] Revert "Create nodejs.yml" --- .github/workflows/nodejs.yml | 28 ---------------------------- 1 file changed, 28 deletions(-) delete mode 100644 .github/workflows/nodejs.yml diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml deleted file mode 100644 index 4cce9cf..0000000 --- a/.github/workflows/nodejs.yml +++ /dev/null @@ -1,28 +0,0 @@ -name: Node.js CI - -on: - push: - branches: [ development ] - pull_request: - branches: [ developemnt ] - -jobs: - build: - - runs-on: ${{ matrix.os }} - - strategy: - matrix: - node-version: [10.x, 12.x] - os: [ubuntu-latest, macos-latest, windows-latest] - - steps: - - uses: actions/checkout@v2 - - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v1 - with: - node-version: ${{ matrix.node-version }} - - run: npm ci - - run: npm run build --if-present - - run: npm run compile - - run: npm run package From 311b133c1c04586bca6e687b47858d94bfc85951 Mon Sep 17 00:00:00 2001 From: Spruce Bondera Date: Tue, 19 May 2020 01:20:25 -0700 Subject: [PATCH 3/3] Fix crashes with a reference error to opts The variable is actually `this.opt` --- src/ffmpeg.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ffmpeg.js b/src/ffmpeg.js index 1ac6a86..b5d3a0a 100644 --- a/src/ffmpeg.js +++ b/src/ffmpeg.js @@ -165,7 +165,7 @@ class FFMPEG extends events.EventEmitter { else if (code === 255) this.emit('close', code) else - this.emit('error', { code: code, cmd: `${opts.ffmpegPath} ${tmpargs.join(' ')}` }) + this.emit('error', { code: code, cmd: `${this.opts.ffmpegPath} ${tmpargs.join(' ')}` }) }) } kill() {