From 0b02ebf1b6786cc051fdd1b518be8e5e38bc9a9f Mon Sep 17 00:00:00 2001 From: dakriy Date: Sat, 14 Jun 2025 08:56:06 -0700 Subject: [PATCH] feat(playout): don't clear liquidsoap queue on liquidsoap startup (#3163) ### Description When liquidsoap starts, it sends an API request to the legacy API which triggers a rabbitmq message to the playout service to update the liquidsoap queues and make sure they are correct. The removed line is not necessary and will cause issues if there is more than one liquidsoap service. It is not necessary because the playout service automatically prunes the queue and will add/remove only what is necessary and does not require the whole queue to be cleared. If the whole queue is cleared and there are multiple liquid soap services, every LQ service will go silent and then fade to normal volume in the middle of playout. Removing this line has no logical effect as all the work it does is immediately redone and removal fixes the re-cue-in issue when you have multiple liquidsoap services all running playout. So, this line in the best of cases is useless and does nothing, and in the worst of cases causes playout issues, hence its removal. **This is a new feature**: No **I have updated the documentation to reflect these changes**: Bug fix ### Testing Notes **What I did:** I setup multiple playout/liquidsoap service pairs, and heard that when one is restarted all of them go quiet and fade in from their current play cursor. I then made the change and verified that only the restarted service faded in. **How you can replicate my testing:** See above section ### **Links** Related to #3161 and #3162 --- playout/libretime_playout/player/fetch.py | 1 - 1 file changed, 1 deletion(-) diff --git a/playout/libretime_playout/player/fetch.py b/playout/libretime_playout/player/fetch.py index 8a664ca18..79453a4ef 100644 --- a/playout/libretime_playout/player/fetch.py +++ b/playout/libretime_playout/player/fetch.py @@ -154,7 +154,6 @@ class PypoFetch(Thread): except OSError as exception: logger.exception(exception) - self.liquidsoap.clear_all_queues() self.liquidsoap.clear_queue_tracker() def update_liquidsoap_stream_format(