From a3d6ea77e6db6582845ec5045c5782572b5fd39f Mon Sep 17 00:00:00 2001 From: Lucas Bickel Date: Mon, 29 Jul 2019 20:06:43 +0200 Subject: [PATCH] :bug: (pypo) disable fs block size based cache check --- python_apps/pypo/pypo/pypofile.py | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/python_apps/pypo/pypo/pypofile.py b/python_apps/pypo/pypo/pypofile.py index edad6ff92..85b3d642c 100644 --- a/python_apps/pypo/pypo/pypofile.py +++ b/python_apps/pypo/pypo/pypofile.py @@ -49,10 +49,13 @@ class PypoFile(Thread): do_copy = False if dst_exists: - if src_size != dst_size: - do_copy = True - else: - self.logger.debug("file %s already exists in local cache as %s, skipping copying..." % (src, dst)) + # TODO: Check if the locally cached variant of the file is sane. + # This used to be a filesize check that didn't end up working. + # Once we have watched folders updated files from them might + # become an issue here... This needs proper cache management. + # https://github.com/LibreTime/libretime/issues/756#issuecomment-477853018 + # https://github.com/LibreTime/libretime/pull/845 + self.logger.debug("file %s already exists in local cache as %s, skipping copying..." % (src, dst)) else: do_copy = True