From 02cbc9a062cbdddc739f181ed8efb12b07d125af Mon Sep 17 00:00:00 2001 From: juancarmore Date: Wed, 14 Aug 2024 17:54:43 +0200 Subject: [PATCH] Improve comments about URLs settings --- .../openvidu-angular/src/app/app.component.ts | 8 ++++---- .../openvidu-ionic/src/app/app.component.ts | 8 ++++---- application-client/openvidu-js/src/app.js | 8 ++++---- application-client/openvidu-react/src/App.tsx | 8 ++++---- application-client/openvidu-vue/src/App.vue | 8 ++++---- 5 files changed, 20 insertions(+), 20 deletions(-) diff --git a/application-client/openvidu-angular/src/app/app.component.ts b/application-client/openvidu-angular/src/app/app.component.ts index 31e39e11..fc86158a 100644 --- a/application-client/openvidu-angular/src/app/app.component.ts +++ b/application-client/openvidu-angular/src/app/app.component.ts @@ -18,8 +18,8 @@ type TrackInfo = { participantIdentity: string; }; -// For local development, leave these variables empty -// For production, configure them with correct URLs depending on your deployment +// When running OpenVidu locally, leave these variables empty +// For other deployment type, configure them with correct URLs depending on your deployment var APPLICATION_SERVER_URL = ''; var LIVEKIT_URL = ''; @@ -45,7 +45,7 @@ export class AppComponent implements OnDestroy { } configureUrls() { - // If APPLICATION_SERVER_URL is not configured, use default value from local development + // If APPLICATION_SERVER_URL is not configured, use default value from OpenVidu Local deployment if (!APPLICATION_SERVER_URL) { if (window.location.hostname === 'localhost') { APPLICATION_SERVER_URL = 'http://localhost:6080/'; @@ -54,7 +54,7 @@ export class AppComponent implements OnDestroy { } } - // If LIVEKIT_URL is not configured, use default value from local development + // If LIVEKIT_URL is not configured, use default value from OpenVidu Local deployment if (!LIVEKIT_URL) { if (window.location.hostname === 'localhost') { LIVEKIT_URL = 'ws://localhost:7880/'; diff --git a/application-client/openvidu-ionic/src/app/app.component.ts b/application-client/openvidu-ionic/src/app/app.component.ts index d7897e8f..63aada00 100644 --- a/application-client/openvidu-ionic/src/app/app.component.ts +++ b/application-client/openvidu-ionic/src/app/app.component.ts @@ -35,8 +35,8 @@ type TrackInfo = { participantIdentity: string; }; -// For local development launching app in web browser, leave these variables empty -// For production or when launching app in a mobile device, configure them with correct URLs +// When running OpenVidu locally and launching app in web browser, leave these variables empty +// For other deployment type or when launching app in a mobile device, configure them with correct URLs // If you leave them empty when launching app in a mobile device, the user will be prompted to enter the URLs var APPLICATION_SERVER_URL = ''; var LIVEKIT_URL = ''; @@ -101,7 +101,7 @@ export class AppComponent implements OnDestroy { } } else { // If APPLICATION_SERVER_URL is not configured and app is not launched in a mobile device, - // use default value from local development + // use default value from OpenVidu Local deployment if (!APPLICATION_SERVER_URL) { if (window.location.hostname === 'localhost') { APPLICATION_SERVER_URL = 'http://localhost:6080/'; @@ -111,7 +111,7 @@ export class AppComponent implements OnDestroy { } // If LIVEKIT_URL is not configured and app is not launched in a mobile device, - // use default value from local development + // use default value from OpenVidu Local deployment if (!LIVEKIT_URL) { if (window.location.hostname === 'localhost') { LIVEKIT_URL = 'ws://localhost:7880/'; diff --git a/application-client/openvidu-js/src/app.js b/application-client/openvidu-js/src/app.js index 36a8cff8..ed8d1ee2 100644 --- a/application-client/openvidu-js/src/app.js +++ b/application-client/openvidu-js/src/app.js @@ -1,5 +1,5 @@ -// For local development, leave these variables empty -// For production, configure them with correct URLs depending on your deployment +// When running OpenVidu locally, leave these variables empty +// For other deployment type, configure them with correct URLs depending on your deployment var APPLICATION_SERVER_URL = ""; var LIVEKIT_URL = ""; configureUrls(); @@ -8,7 +8,7 @@ const LivekitClient = window.LivekitClient; var room; function configureUrls() { - // If APPLICATION_SERVER_URL is not configured, use default value from local development + // If APPLICATION_SERVER_URL is not configured, use default value from OpenVidu Local deployment if (!APPLICATION_SERVER_URL) { if (window.location.hostname === "localhost") { APPLICATION_SERVER_URL = "http://localhost:6080/"; @@ -17,7 +17,7 @@ function configureUrls() { } } - // If LIVEKIT_URL is not configured, use default value from local development + // If LIVEKIT_URL is not configured, use default value from OpenVidu Local deployment if (!LIVEKIT_URL) { if (window.location.hostname === "localhost") { LIVEKIT_URL = "ws://localhost:7880/"; diff --git a/application-client/openvidu-react/src/App.tsx b/application-client/openvidu-react/src/App.tsx index affb1a0d..d70f76b7 100644 --- a/application-client/openvidu-react/src/App.tsx +++ b/application-client/openvidu-react/src/App.tsx @@ -16,14 +16,14 @@ type TrackInfo = { participantIdentity: string; }; -// For local development, leave these variables empty -// For production, configure them with correct URLs depending on your deployment +// When running OpenVidu locally, leave these variables empty +// For other deployment type, configure them with correct URLs depending on your deployment let APPLICATION_SERVER_URL = ""; let LIVEKIT_URL = ""; configureUrls(); function configureUrls() { - // If APPLICATION_SERVER_URL is not configured, use default value from local development + // If APPLICATION_SERVER_URL is not configured, use default value from OpenVidu Local deployment if (!APPLICATION_SERVER_URL) { if (window.location.hostname === "localhost") { APPLICATION_SERVER_URL = "http://localhost:6080/"; @@ -32,7 +32,7 @@ function configureUrls() { } } - // If LIVEKIT_URL is not configured, use default value from local development + // If LIVEKIT_URL is not configured, use default value from OpenVidu Local deployment if (!LIVEKIT_URL) { if (window.location.hostname === "localhost") { LIVEKIT_URL = "ws://localhost:7880/"; diff --git a/application-client/openvidu-vue/src/App.vue b/application-client/openvidu-vue/src/App.vue index 4eff8551..7888dfcd 100644 --- a/application-client/openvidu-vue/src/App.vue +++ b/application-client/openvidu-vue/src/App.vue @@ -16,14 +16,14 @@ type TrackInfo = { participantIdentity: string; }; -// For local development, leave these variables empty -// For production, configure them with correct URLs depending on your deployment +// When running OpenVidu locally, leave these variables empty +// For other deployment type, configure them with correct URLs depending on your deployment let APPLICATION_SERVER_URL = ''; let LIVEKIT_URL = ''; configureUrls(); function configureUrls() { - // If APPLICATION_SERVER_URL is not configured, use default value from local development + // If APPLICATION_SERVER_URL is not configured, use default value from OpenVidu Local deployment if (!APPLICATION_SERVER_URL) { if (window.location.hostname === 'localhost') { APPLICATION_SERVER_URL = 'http://localhost:6080/'; @@ -32,7 +32,7 @@ function configureUrls() { } } - // If LIVEKIT_URL is not configured, use default value from local development + // If LIVEKIT_URL is not configured, use default value from OpenVidu Local deployment if (!LIVEKIT_URL) { if (window.location.hostname === 'localhost') { LIVEKIT_URL = 'ws://localhost:7880/';