From 10b1eb8188bb61d9a9e2c9ac8d8c6ea522bae839 Mon Sep 17 00:00:00 2001 From: pabloFuente Date: Fri, 16 Jun 2017 15:02:01 +0200 Subject: [PATCH] Minor changes --- openvidu-insecure-angular/README.md | 2 +- openvidu-insecure-angular/src/app/app.component.ts | 2 +- openvidu-insecure-js/README.md | 2 +- openvidu-insecure-js/web/app.js | 2 +- openvidu-js-java/README.md | 8 ++++---- openvidu-js-java/src/main/resources/static/app.js | 2 +- openvidu-js-node/README.md | 10 +++++----- openvidu-js-node/public/app.js | 2 +- openvidu-mvc-java/README.md | 4 ++-- openvidu-mvc-node/README.md | 6 +++--- 10 files changed, 20 insertions(+), 20 deletions(-) diff --git a/openvidu-insecure-angular/README.md b/openvidu-insecure-angular/README.md index 04d863eb..a3a7ac1f 100644 --- a/openvidu-insecure-angular/README.md +++ b/openvidu-insecure-angular/README.md @@ -142,7 +142,7 @@ Let's see how `app.component.ts` uses `openvidu-browser`: // If the connection is successful... if (!error) { - // --- 4) Get your own camera stream with the desired resolution and publish it --- + // --- 4) Get your own camera stream with the desired resolution --- // Both audio and video will be active. HTML video element will be appended to element with 'publisher' id let publisher = this.OV.initPublisher('', { diff --git a/openvidu-insecure-angular/src/app/app.component.ts b/openvidu-insecure-angular/src/app/app.component.ts index f35892a3..d0d4699b 100644 --- a/openvidu-insecure-angular/src/app/app.component.ts +++ b/openvidu-insecure-angular/src/app/app.component.ts @@ -55,7 +55,7 @@ export class AppComponent { // If the connection is successful, initialize a publisher and publish to the session if (!error) { - // 4) Get your own camera stream with the desired resolution and publish it + // 4) Get your own camera stream with the desired resolution let publisher = this.OV.initPublisher('', { audio: true, video: true, diff --git a/openvidu-insecure-js/README.md b/openvidu-insecure-js/README.md index 409da205..fa47ae8c 100644 --- a/openvidu-insecure-js/README.md +++ b/openvidu-insecure-js/README.md @@ -123,7 +123,7 @@ Let's see how `app.js` uses `OpenVidu.js`: // If the connection is successful, initialize a publisher and publish to the session if (!error) { - // --- 4) Get your own camera stream with the desired resolution and publish it --- + // --- 4) Get your own camera stream with the desired resolution --- // Both audio and video will be active. HTML video element will be appended to element with 'publisher' id var publisher = OV.initPublisher('publisher', { diff --git a/openvidu-insecure-js/web/app.js b/openvidu-insecure-js/web/app.js index 6c98f68c..cd07dcb7 100644 --- a/openvidu-insecure-js/web/app.js +++ b/openvidu-insecure-js/web/app.js @@ -91,7 +91,7 @@ function joinSession() { // If the connection is successful, initialize a publisher and publish to the session if (!error) { - // --- 4) Get your own camera stream with the desired resolution and publish it --- + // --- 4) Get your own camera stream with the desired resolution --- var publisher = OV.initPublisher('publisher', { audio: true, diff --git a/openvidu-js-java/README.md b/openvidu-js-java/README.md index 2675242f..c048537d 100644 --- a/openvidu-js-java/README.md +++ b/openvidu-js-java/README.md @@ -74,7 +74,7 @@ Let's describe the code following this scenario: a user logs in to the app and c ### 1) User logs in -We have implemented a method for making HTTP requests to the backend, as we will need to make at least three of them: one for logging in, one for getting the sessionId and a valid token from openvidu-server and a one for letting know our backend when any user leaves the video-call. The header of the method looks like this: +We have implemented a method for making HTTP requests to the backend, as we will need to make at least three of them: one for logging in, one for getting the sessionId and a valid token from openvidu-server and one for letting know our backend when any user leaves the video-call. The header of the method looks like this: ```javascript function httpRequest(method, url, body, errorMsg, callback) @@ -136,7 +136,7 @@ public ResponseEntity login(@RequestBody String userPass, HttpSession ht ### 2) User connects to "TUTORIAL" video-call -HTML will display now the user has logged in a different form, asking for the video-call to connect and the nickname the user wants to have in it. So our 'publisher1' user would write TUTORIAL in "Session" field and press "Join!" button: +HTML will display now the user has logged a different form, asking for the video-call to connect and the nickname the user wants to have in it. So our 'publisher1' user would write TUTORIAL in "Session" field and press "Join!" button:

@@ -288,11 +288,11 @@ session.connect(token, '{"clientData": "' + $("#participantName").val() + '"}', // Here we check somehow if the user has at least 'PUBLISHER' role before // trying to publish its stream. Even if someone modified the client's code and - // published the stream, it won't work if the token sent in Session.connect + // published the stream, it wouldn't work if the token sent in Session.connect // method doesn't belong to a 'PUBLIHSER' role if (isPublisher()) { - // --- 4) Get your own camera stream and publish it --- + // --- 4) Get your own camera stream --- var publisher = OV.initPublisher('publisher', { audio: true, diff --git a/openvidu-js-java/src/main/resources/static/app.js b/openvidu-js-java/src/main/resources/static/app.js index db9cc23b..722b2853 100644 --- a/openvidu-js-java/src/main/resources/static/app.js +++ b/openvidu-js-java/src/main/resources/static/app.js @@ -159,7 +159,7 @@ function joinSession() { // If the user has enough permissions if (isPublisher()) { - // 4) Get your own camera stream with the desired resolution and publish it + // 4) Get your own camera stream with the desired resolution var publisher = OV.initPublisher('publisher', { audio: true, diff --git a/openvidu-js-node/README.md b/openvidu-js-node/README.md index 05cde09a..77c93b7b 100644 --- a/openvidu-js-node/README.md +++ b/openvidu-js-node/README.md @@ -50,7 +50,7 @@ OpenVidu is composed by the modules displayed on the image above. ## Understanding the code -This is a very basic web application with a pretty simple vanilla JS/HTML/CSS frontend and a straightforward Node backend with [_express_](http://expressjs.com/es/). OpenVidu assumes you can identify your users so you can tell which users can connect to which video-calls, and what role (and therefore what permissions) each one of them will have in the calls. You can do this as you prefer. Here our backend will manage the users and their sessions with the easy-to-use and non-intrusive [_express-session_](https://github.com/expressjs/session) API. +This is a very basic web application with a pretty simple vanilla JS/HTML/CSS frontend and a straightforward Node backend with [_express_](http://expressjs.com). OpenVidu assumes you can identify your users so you can tell which users can connect to which video-calls, and what role (and therefore what permissions) each one of them will have in the calls. You can do this as you prefer. Here our backend will manage the users and their sessions with the easy-to-use and non-intrusive [_express-session_](https://github.com/expressjs/session) API. - **Backend**: node server - `server.js` : single file which handles all operations of server. @@ -74,7 +74,7 @@ Let's describe the code following this scenario: a user logs in to the app and c ### 1) User logs in -We have implemented a method for making HTTP requests to the backend, as we will need to make at least three of them: one for logging in, one for getting the sessionId and a valid token from openvidu-server and a one for letting know our backend when any user leaves the video-call. The header of the method looks like this: +We have implemented a method for making HTTP requests to the backend, as we will need to make at least three of them: one for logging in, one for getting the sessionId and a valid token from openvidu-server and one for letting know our backend when any user leaves the video-call. The header of the method looks like this: ```javascript function httpRequest(method, url, body, errorMsg, callback) @@ -133,7 +133,7 @@ app.post('/api-login/login', function (req, res) { ### 2) User connects to "TUTORIAL" video-call -HTML will display now the user has logged in a different form, asking for the video-call to connect and the nickname the user wants to have in it. So our 'publisher1' user would write TUTORIAL in "Session" field and press "Join!" button: +HTML will display now the user has logged a different form, asking for the video-call to connect and the nickname the user wants to have in it. So our 'publisher1' user would write TUTORIAL in "Session" field and press "Join!" button:

@@ -281,11 +281,11 @@ session.connect(token, '{"clientData": "' + $("#participantName").val() + '"}', // Here we check somehow if the user has at least 'PUBLISHER' role before // trying to publish its stream. Even if someone modified the client's code and - // published the stream, it won't work if the token sent in Session.connect + // published the stream, it wouldn't work if the token sent in Session.connect // method doesn't belong to a 'PUBLIHSER' role if (isPublisher()) { - // --- 4) Get your own camera stream and publish it --- + // --- 4) Get your own camera stream --- var publisher = OV.initPublisher('publisher', { audio: true, diff --git a/openvidu-js-node/public/app.js b/openvidu-js-node/public/app.js index db9cc23b..722b2853 100644 --- a/openvidu-js-node/public/app.js +++ b/openvidu-js-node/public/app.js @@ -159,7 +159,7 @@ function joinSession() { // If the user has enough permissions if (isPublisher()) { - // 4) Get your own camera stream with the desired resolution and publish it + // 4) Get your own camera stream with the desired resolution var publisher = OV.initPublisher('publisher', { audio: true, diff --git a/openvidu-mvc-java/README.md b/openvidu-mvc-java/README.md index cb42cb14..6331b9d1 100644 --- a/openvidu-mvc-java/README.md +++ b/openvidu-mvc-java/README.md @@ -282,11 +282,11 @@ session.connect(token, '{"clientData": "' + nickName + '"}', function (err) { // Here we check somehow if the user has at least 'PUBLISHER' role before // trying to publish its stream. Even if someone modified the client's code and - // published the stream, it won't work if the token sent in Session.connect + // published the stream, it wouldn't work if the token sent in Session.connect // method doesn't belong to a 'PUBLIHSER' role if (isPublisher(userName)) { - // --- 4) Get your own camera stream and publish it --- + // --- 4) Get your own camera stream --- var publisher = OV.initPublisher('publisher', { audio: true, diff --git a/openvidu-mvc-node/README.md b/openvidu-mvc-node/README.md index 63c384d2..77ac7704 100644 --- a/openvidu-mvc-node/README.md +++ b/openvidu-mvc-node/README.md @@ -52,7 +52,7 @@ OpenVidu is composed by the modules displayed on the image above. ## Understanding the code -This is a very basic web application with a pretty simple vanilla JS/HTML/CSS frontend and a straightforward Node backend built with [_express_](http://expressjs.com/es/) that serves HTML files with a MVC approach, building the templates with the help of [Embedded JavaScript](http://www.embeddedjs.com/). +This is a very basic web application with a pretty simple vanilla JS/HTML/CSS frontend and a straightforward Node backend built with [_express_](http://expressjs.com) that serves HTML files with a MVC approach, building the templates with the help of [Embedded JavaScript](http://www.embeddedjs.com/). OpenVidu assumes you can identify your users so you can tell which users can connect to which video-calls, and what role (and therefore what permissions) each one of them will have in the calls. You can do this as you prefer. Here our backend will manage the users and their sessions with the easy-to-use and non-intrusive [_express-session_](https://github.com/expressjs/session) API. @@ -290,11 +290,11 @@ session.connect(token, '{"clientData": "' + nickName + '"}', function (err) { // Here we check somehow if the user has at least 'PUBLISHER' role before // trying to publish its stream. Even if someone modified the client's code and - // published the stream, it won't work if the token sent in Session.connect + // published the stream, it wouldn't work if the token sent in Session.connect // method doesn't belong to a 'PUBLIHSER' role if (isPublisher(userName)) { - // --- 4) Get your own camera stream and publish it --- + // --- 4) Get your own camera stream --- var publisher = OV.initPublisher('publisher', { audio: true,