From 3b7ab62b4c2a2aa54b7a926fde5d433edf24f9e0 Mon Sep 17 00:00:00 2001 From: csantosm <4a.santos@gmail.com> Date: Mon, 18 Jul 2022 17:29:03 +0200 Subject: [PATCH] openvidu-call: Fixed wrong status response --- .../src/controllers/SessionController.ts | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/openvidu-call/openvidu-call-back/src/controllers/SessionController.ts b/openvidu-call/openvidu-call-back/src/controllers/SessionController.ts index 5c5642d9..b814e286 100644 --- a/openvidu-call/openvidu-call-back/src/controllers/SessionController.ts +++ b/openvidu-call/openvidu-call-back/src/controllers/SessionController.ts @@ -51,18 +51,30 @@ app.post('/', async (req: Request, res: Response) => { if(IS_RECORDING_ENABLED){ date = date || openviduService.getDateFromCookie(req.cookies); - response.recordings = await openviduService.listRecordingsBySessionIdAndDate(sessionId, date); + try { + response.recordings = await openviduService.listRecordingsBySessionIdAndDate(sessionId, date); + } catch (error) { + if(error.message === '501'){ + console.log('Recording is diasbled in OpenVidu Server. Disabling it in OpenVidu Call'); + response.recordings = []; + response.recordingEnabled = false; + } + } } res.status(200).send(JSON.stringify(response)); } catch (error) { console.error(error); let message = 'Cannot connect with OpenVidu Server'; + let code = Number(error?.message); if(error.message === 500){ message = 'Unexpected error when creating the Connection object.' } else if (error.message === 404){ message = 'No session exists'; } - res.status(error?.message || 503).send({ message }); + if(typeof code !== 'number') { + code = 503 + } + res.status(code).send({ message }); } });