From c7491223bf60fc304e6666f4a4fd7da105858981 Mon Sep 17 00:00:00 2001 From: david Date: Mon, 31 May 2021 16:49:49 +0200 Subject: [PATCH 1/3] modification to disable join button after click --- openvidu-recording-java/src/main/resources/static/app.js | 8 ++++++++ openvidu-recording-node/public/app.js | 8 ++++++++ 2 files changed, 16 insertions(+) diff --git a/openvidu-recording-java/src/main/resources/static/app.js b/openvidu-recording-java/src/main/resources/static/app.js index 55378f83..6956e105 100644 --- a/openvidu-recording-java/src/main/resources/static/app.js +++ b/openvidu-recording-java/src/main/resources/static/app.js @@ -9,6 +9,12 @@ var numVideos = 0; /* OPENVIDU METHODS */ function joinSession() { + + // --- 0) Change the button --- + + document.getElementById("join-btn").disabled = true; + document.getElementById("join-btn").innerHTML = "Joining..."; + getToken(function () { // --- 1) Get an OpenVidu object --- @@ -178,6 +184,8 @@ function leaveSession() { // --- 9) Leave the session by calling 'disconnect' method over the Session object --- session.disconnect(); + document.getElementById("join-btn").disabled = false; + document.getElementById("join-btn").innerHTML = "Join!"; } diff --git a/openvidu-recording-node/public/app.js b/openvidu-recording-node/public/app.js index 55378f83..76498391 100644 --- a/openvidu-recording-node/public/app.js +++ b/openvidu-recording-node/public/app.js @@ -9,6 +9,12 @@ var numVideos = 0; /* OPENVIDU METHODS */ function joinSession() { + + // --- 0) Change the button --- + + document.getElementById("join-btn").disabled = true; + document.getElementById("join-btn").innerHTML = "Joining..."; + getToken(function () { // --- 1) Get an OpenVidu object --- @@ -178,6 +184,8 @@ function leaveSession() { // --- 9) Leave the session by calling 'disconnect' method over the Session object --- session.disconnect(); + document.getElementById("join-btn").disabled = false; + document.getElementById("join-btn").innerHTML = "Join!"; } From 1e91ae177084d0d435ceae3a8eaf76a83608ffee Mon Sep 17 00:00:00 2001 From: david Date: Wed, 2 Jun 2021 11:32:04 +0200 Subject: [PATCH 2/3] enable the join button when an error requesting the token occurs --- openvidu-recording-java/src/main/resources/static/app.js | 2 ++ openvidu-recording-node/public/app.js | 2 ++ 2 files changed, 4 insertions(+) diff --git a/openvidu-recording-java/src/main/resources/static/app.js b/openvidu-recording-java/src/main/resources/static/app.js index 6956e105..711073e0 100644 --- a/openvidu-recording-java/src/main/resources/static/app.js +++ b/openvidu-recording-java/src/main/resources/static/app.js @@ -174,6 +174,8 @@ function joinSession() { }) .catch(error => { console.warn('There was an error connecting to the session:', error.code, error.message); + document.getElementById("join-btn").disabled = false; + document.getElementById("join-btn").innerHTML = "Join!"; }); return false; diff --git a/openvidu-recording-node/public/app.js b/openvidu-recording-node/public/app.js index 76498391..ff8f5ca0 100644 --- a/openvidu-recording-node/public/app.js +++ b/openvidu-recording-node/public/app.js @@ -174,6 +174,8 @@ function joinSession() { }) .catch(error => { console.warn('There was an error connecting to the session:', error.code, error.message); + document.getElementById("join-btn").disabled = false; + document.getElementById("join-btn").innerHTML = "Join!"; }); return false; From 5243cd49d625886ae8170940823d68c5a58d0251 Mon Sep 17 00:00:00 2001 From: david Date: Wed, 2 Jun 2021 12:19:38 +0200 Subject: [PATCH 3/3] add function for enable the join button when an error requesting the token occurs --- .../src/main/resources/static/app.js | 11 ++++++----- openvidu-recording-node/public/app.js | 11 ++++++----- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/openvidu-recording-java/src/main/resources/static/app.js b/openvidu-recording-java/src/main/resources/static/app.js index 711073e0..23d2d03b 100644 --- a/openvidu-recording-java/src/main/resources/static/app.js +++ b/openvidu-recording-java/src/main/resources/static/app.js @@ -174,8 +174,7 @@ function joinSession() { }) .catch(error => { console.warn('There was an error connecting to the session:', error.code, error.message); - document.getElementById("join-btn").disabled = false; - document.getElementById("join-btn").innerHTML = "Join!"; + enableBtn(); }); return false; @@ -186,14 +185,16 @@ function leaveSession() { // --- 9) Leave the session by calling 'disconnect' method over the Session object --- session.disconnect(); - document.getElementById("join-btn").disabled = false; - document.getElementById("join-btn").innerHTML = "Join!"; + enableBtn(); } /* OPENVIDU METHODS */ - +function enableBtn (){ + document.getElementById("join-btn").disabled = false; + document.getElementById("join-btn").innerHTML = "Join!"; +} /* APPLICATION REST METHODS */ diff --git a/openvidu-recording-node/public/app.js b/openvidu-recording-node/public/app.js index ff8f5ca0..c8d1c1c3 100644 --- a/openvidu-recording-node/public/app.js +++ b/openvidu-recording-node/public/app.js @@ -174,8 +174,7 @@ function joinSession() { }) .catch(error => { console.warn('There was an error connecting to the session:', error.code, error.message); - document.getElementById("join-btn").disabled = false; - document.getElementById("join-btn").innerHTML = "Join!"; + enableBtn(); }); return false; @@ -186,14 +185,16 @@ function leaveSession() { // --- 9) Leave the session by calling 'disconnect' method over the Session object --- session.disconnect(); - document.getElementById("join-btn").disabled = false; - document.getElementById("join-btn").innerHTML = "Join!"; + enableBtn(); } /* OPENVIDU METHODS */ - +function enableBtn (){ + document.getElementById("join-btn").disabled = false; + document.getElementById("join-btn").innerHTML = "Join!"; +} /* APPLICATION REST METHODS */