From 81b7c492d14ea587440b5d80b92d36e555743023 Mon Sep 17 00:00:00 2001 From: Juan Navarro Date: Wed, 18 May 2022 13:10:40 +0200 Subject: [PATCH] android: CustomSdpObserver: Drop custom method "log"; use Log.e for failures Having a custom "log()" method didn't bring many advantages, and actually lacked needed flexibility. We'd like to log success messages to "debug", but failure messages to the "error" level. --- .../observers/CustomSdpObserver.java | 20 ++++++++----------- 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/openvidu-android/app/src/main/java/io/openvidu/openvidu_android/observers/CustomSdpObserver.java b/openvidu-android/app/src/main/java/io/openvidu/openvidu_android/observers/CustomSdpObserver.java index c6824a3c..ca34a21d 100644 --- a/openvidu-android/app/src/main/java/io/openvidu/openvidu_android/observers/CustomSdpObserver.java +++ b/openvidu-android/app/src/main/java/io/openvidu/openvidu_android/observers/CustomSdpObserver.java @@ -7,33 +7,29 @@ import org.webrtc.SessionDescription; public class CustomSdpObserver implements SdpObserver { - private String tag; + private final String tag; public CustomSdpObserver(String tag) { this.tag = "SdpObserver-" + tag; } - private void log(String s) { - Log.d(tag, s); - } - @Override - public void onCreateSuccess(SessionDescription sessionDescription) { - log("onCreateSuccess " + sessionDescription); + public void onCreateSuccess(SessionDescription sdp) { + Log.d(this.tag, "onCreateSuccess, SDP: " + sdp.toString()); } @Override public void onSetSuccess() { - log("onSetSuccess "); + Log.d(this.tag, "onSetSuccess"); } @Override - public void onCreateFailure(String s) { - log("onCreateFailure " + s); + public void onCreateFailure(String error) { + Log.e(this.tag, "onCreateFailure, error: " + error); } @Override - public void onSetFailure(String s) { - log("onSetFailure " + s); + public void onSetFailure(String error) { + Log.e(this.tag, "onSetFailure, error: " + error); } }