Secret declared in insecure tutorials for better understanding

This commit is contained in:
pabloFuente 2018-07-23 15:02:21 +02:00
parent a45b905250
commit a8700ebcd7
5 changed files with 15 additions and 10 deletions

View File

@ -267,6 +267,7 @@ function updateLayout() {
*/ */
var OPENVIDU_SERVER_URL = "https://" + location.hostname + ":4443"; var OPENVIDU_SERVER_URL = "https://" + location.hostname + ":4443";
var OPENVIDU_SERVER_SECRET = "MY_SECRET";
function getToken(mySessionId) { function getToken(mySessionId) {
return createSession(mySessionId).then(sId => createToken(sId)); return createSession(mySessionId).then(sId => createToken(sId));
@ -279,7 +280,7 @@ function createSession(sId) {
url: OPENVIDU_SERVER_URL + "/api/sessions", url: OPENVIDU_SERVER_URL + "/api/sessions",
data: JSON.stringify({ customSessionId: sId }), data: JSON.stringify({ customSessionId: sId }),
headers: { headers: {
"Authorization": "Basic " + btoa("OPENVIDUAPP:MY_SECRET"), "Authorization": "Basic " + btoa("OPENVIDUAPP:" + OPENVIDU_SERVER_SECRET),
"Content-Type": "application/json" "Content-Type": "application/json"
}, },
success: response => resolve(response.id), success: response => resolve(response.id),
@ -305,7 +306,7 @@ function createToken(sId) {
url: OPENVIDU_SERVER_URL + "/api/tokens", url: OPENVIDU_SERVER_URL + "/api/tokens",
data: JSON.stringify({ session: sId }), data: JSON.stringify({ session: sId }),
headers: { headers: {
"Authorization": "Basic " + btoa("OPENVIDUAPP:MY_SECRET"), "Authorization": "Basic " + btoa("OPENVIDUAPP:" + OPENVIDU_SERVER_SECRET),
"Content-Type": "application/json" "Content-Type": "application/json"
}, },
success: response => resolve(response.token), success: response => resolve(response.token),

View File

@ -54,6 +54,7 @@ window.onbeforeunload = function () {
*/ */
var OPENVIDU_SERVER_URL = "https://" + location.hostname + ":4443"; var OPENVIDU_SERVER_URL = "https://" + location.hostname + ":4443";
var OPENVIDU_SERVER_SECRET = "MY_SECRET";
function getToken(mySessionId) { function getToken(mySessionId) {
return createSession(mySessionId).then(sessionId => createToken(sessionId)); return createSession(mySessionId).then(sessionId => createToken(sessionId));
@ -66,7 +67,7 @@ function createSession(sessionId) {
url: OPENVIDU_SERVER_URL + "/api/sessions", url: OPENVIDU_SERVER_URL + "/api/sessions",
data: JSON.stringify({ customSessionId: sessionId }), data: JSON.stringify({ customSessionId: sessionId }),
headers: { headers: {
"Authorization": "Basic " + btoa("OPENVIDUAPP:MY_SECRET"), "Authorization": "Basic " + btoa("OPENVIDUAPP:" + OPENVIDU_SERVER_SECRET),
"Content-Type": "application/json" "Content-Type": "application/json"
}, },
success: response => resolve(response.id), success: response => resolve(response.id),
@ -92,7 +93,7 @@ function createToken(sessionId) {
url: OPENVIDU_SERVER_URL + "/api/tokens", url: OPENVIDU_SERVER_URL + "/api/tokens",
data: JSON.stringify({ session: sessionId }), data: JSON.stringify({ session: sessionId }),
headers: { headers: {
"Authorization": "Basic " + btoa("OPENVIDUAPP:MY_SECRET"), "Authorization": "Basic " + btoa("OPENVIDUAPP:" + OPENVIDU_SERVER_SECRET),
"Content-Type": "application/json" "Content-Type": "application/json"
}, },
success: response => resolve(response.token), success: response => resolve(response.token),

View File

@ -13,6 +13,7 @@ import { OpenVidu, Session, StreamManager, Publisher, Subscriber, StreamEvent }
export class AppComponent implements OnDestroy { export class AppComponent implements OnDestroy {
OPENVIDU_SERVER_URL = 'https://' + location.hostname + ':4443'; OPENVIDU_SERVER_URL = 'https://' + location.hostname + ':4443';
OPENVIDU_SERVER_SECRET = 'MY_SECRET';
// OpenVidu objects // OpenVidu objects
OV: OpenVidu; OV: OpenVidu;
@ -170,7 +171,7 @@ export class AppComponent implements OnDestroy {
const body = JSON.stringify({ customSessionId: sessionId }); const body = JSON.stringify({ customSessionId: sessionId });
const options = { const options = {
headers: new HttpHeaders({ headers: new HttpHeaders({
'Authorization': 'Basic ' + btoa('OPENVIDUAPP:MY_SECRET'), 'Authorization': 'Basic ' + btoa('OPENVIDUAPP:' + this.OPENVIDU_SERVER_SECRET),
'Content-Type': 'application/json' 'Content-Type': 'application/json'
}) })
}; };
@ -203,7 +204,7 @@ export class AppComponent implements OnDestroy {
const body = JSON.stringify({ session: sessionId }); const body = JSON.stringify({ session: sessionId });
const options = { const options = {
headers: new HttpHeaders({ headers: new HttpHeaders({
'Authorization': 'Basic ' + btoa('OPENVIDUAPP:MY_SECRET'), 'Authorization': 'Basic ' + btoa('OPENVIDUAPP:' + this.OPENVIDU_SERVER_SECRET),
'Content-Type': 'application/json' 'Content-Type': 'application/json'
}) })
}; };

View File

@ -187,6 +187,7 @@ function initMainVideo(videoElement, userData) {
*/ */
var OPENVIDU_SERVER_URL = "https://" + location.hostname + ":4443"; var OPENVIDU_SERVER_URL = "https://" + location.hostname + ":4443";
var OPENVIDU_SERVER_SECRET = "MY_SECRET";
function getToken(mySessionId) { function getToken(mySessionId) {
return createSession(mySessionId).then(sessionId => createToken(sessionId)); return createSession(mySessionId).then(sessionId => createToken(sessionId));
@ -199,7 +200,7 @@ function createSession(sessionId) {
url: OPENVIDU_SERVER_URL + "/api/sessions", url: OPENVIDU_SERVER_URL + "/api/sessions",
data: JSON.stringify({ customSessionId: sessionId }), data: JSON.stringify({ customSessionId: sessionId }),
headers: { headers: {
"Authorization": "Basic " + btoa("OPENVIDUAPP:MY_SECRET"), "Authorization": "Basic " + btoa("OPENVIDUAPP:" + OPENVIDU_SERVER_SECRET),
"Content-Type": "application/json" "Content-Type": "application/json"
}, },
success: response => resolve(response.id), success: response => resolve(response.id),
@ -225,7 +226,7 @@ function createToken(sessionId) {
url: OPENVIDU_SERVER_URL + "/api/tokens", url: OPENVIDU_SERVER_URL + "/api/tokens",
data: JSON.stringify({ session: sessionId }), data: JSON.stringify({ session: sessionId }),
headers: { headers: {
"Authorization": "Basic " + btoa("OPENVIDUAPP:MY_SECRET"), "Authorization": "Basic " + btoa("OPENVIDUAPP:" + OPENVIDU_SERVER_SECRET),
"Content-Type": "application/json" "Content-Type": "application/json"
}, },
success: response => resolve(response.token), success: response => resolve(response.token),

View File

@ -38,6 +38,7 @@ function joinSession() {
*/ */
var OPENVIDU_SERVER_URL = 'https://' + location.hostname + ':4443'; var OPENVIDU_SERVER_URL = 'https://' + location.hostname + ':4443';
var OPENVIDU_SERVER_SECRET = "MY_SECRET";
function getToken(sessionName) { function getToken(sessionName) {
return createSession(sessionName).then((sessionId) => createToken(sessionId)); return createSession(sessionName).then((sessionId) => createToken(sessionId));
@ -50,7 +51,7 @@ function createSession(sessionName) {
url: OPENVIDU_SERVER_URL + '/api/sessions', url: OPENVIDU_SERVER_URL + '/api/sessions',
data: JSON.stringify({ customSessionId: sessionName }), data: JSON.stringify({ customSessionId: sessionName }),
headers: { headers: {
Authorization: 'Basic ' + btoa('OPENVIDUAPP:MY_SECRET'), Authorization: 'Basic ' + btoa('OPENVIDUAPP:' + OPENVIDU_SERVER_SECRET),
'Content-Type': 'application/json', 'Content-Type': 'application/json',
}, },
success: (response) => resolve(response.id), success: (response) => resolve(response.id),
@ -84,7 +85,7 @@ function createToken(sessionId) {
url: OPENVIDU_SERVER_URL + '/api/tokens', url: OPENVIDU_SERVER_URL + '/api/tokens',
data: JSON.stringify({ session: sessionId }), data: JSON.stringify({ session: sessionId }),
headers: { headers: {
Authorization: 'Basic ' + btoa('OPENVIDUAPP:MY_SECRET'), Authorization: 'Basic ' + btoa('OPENVIDUAPP:' + OPENVIDU_SERVER_SECRET),
'Content-Type': 'application/json', 'Content-Type': 'application/json',
}, },
success: (response) => resolve(response.token), success: (response) => resolve(response.token),