neoris/openvidu-livekit-tutorials
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

android: add stored remote ICE candidates after SDP Offer/Answer finishes

Browse Source 
ICE candidates are emitted asynchronously, so by the time that SDP messages
have been exchanged, some remote candidates might have already arrived and
stored in temporary variables.

These candidates must be added to the PeerConnection, to make sure that none
is left out!

Corresponds to equivalent code in OpenVidu-Browser:
https://github.com/OpenVidu/openvidu/blob/v2.20.0/openvidu-browser/src/OpenViduInternal/WebRtcPeer/WebRtcPeer.ts#L140-L148
This commit is contained in:
Juan Navarro 2021-11-05 15:46:09 +01:00
parent 0f64ad7a62
commit aac2f5e80c
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
openvidu-android/app/src/main/java/io/openvidu/openvidu_android/openvidu/Session.java
View File

@ -13,6 +13,7 @@ import io.openvidu.openvidu_android.websocket.CustomWebSocket;
import org.webrtc.IceCandidate;
import org.webrtc.MediaConstraints;
import org.webrtc.MediaStream;
import org.webrtc.MediaStreamTrack;
import org.webrtc.PeerConnection;
import org.webrtc.PeerConnectionFactory;
import org.webrtc.RtpReceiver;
@ -88,6 +89,19 @@ public class Session {
super.onIceCandidate(iceCandidate);
websocket.onIceCandidate(iceCandidate, localParticipant.getConnectionId());
}
@Override
public void onSignalingChange(PeerConnection.SignalingState signalingState) {
if (PeerConnection.SignalingState.STABLE.equals(signalingState)) {
// SDP Offer/Answer finished. Add stored remote candidates.
Iterator<IceCandidate> it = localParticipant.getIceCandidateList().iterator();
while (it.hasNext()) {
IceCandidate candidate = it.next();
localParticipant.getPeerConnection().addIceCandidate(candidate);
it.remove();
}
}
}
});
if (localParticipant.getAudioTrack() != null) {
@ -132,6 +146,7 @@ public class Session {
@Override
public void onSignalingChange(PeerConnection.SignalingState signalingState) {
if (PeerConnection.SignalingState.STABLE.equals(signalingState)) {
// SDP Offer/Answer finished. Add stored remote candidates.
final RemoteParticipant remoteParticipant = remoteParticipants.get(connectionId);
Iterator<IceCandidate> it = remoteParticipant.getIceCandidateList().iterator();
while (it.hasNext()) {