neoris/openvidu-meet
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

backend: simplify update room methods to use merge for partial updates

Browse Source
This commit is contained in:
juancarmore 2026-01-19 11:48:57 +01:00
parent 4b183fe02c
commit 1855755cd6
3 changed files with 9 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
meet-ce/backend/src/models/mongoose-schemas/room.schema.ts
View File

@ -53,7 +53,7 @@ const MeetRecordingConfigSchema = new Schema(
layout: {
type: String,
enum: Object.values(MeetRecordingLayout),
required: true
required: false
}
},
{ _id: false }

28
meet-ce/backend/src/services/room.service.ts
View File

@ -251,7 +251,7 @@ export class RoomService {
* Updates the roles permissions of a specific meeting room.
*
* @param roomId - The unique identifier of the meeting room to update
* @param roles - The new roles permissions
* @param roles - Partial roles config with the fields to update
* @returns A Promise that resolves to the updated MeetRoom object
*/
async updateMeetRoomRoles(roomId: string, roles: MeetRoomRolesConfig): Promise<MeetRoom> {
@ -261,19 +261,8 @@ export class RoomService {
throw errorRoomActiveMeeting(roomId);
}
if (roles.moderator) {
room.roles.moderator.permissions = {
...room.roles.moderator.permissions,
...roles.moderator.permissions
};
}
if (roles.speaker) {
room.roles.speaker.permissions = {
...room.roles.speaker.permissions,
...roles.speaker.permissions
};
}
// Merge existing roles with new roles (partial update)
room.roles = merge({}, room.roles, roles);
await this.roomRepository.update(room);
return room;
@ -283,7 +272,7 @@ export class RoomService {
* Updates the anonymous access configuration of a specific meeting room.
*
* @param roomId - The unique identifier of the meeting room to update
* @param anonymous - The new anonymous access configuration
* @param anonymous - Partial anonymous config with the fields to update
* @returns A Promise that resolves to the updated MeetRoom object
*/
async updateMeetRoomAnonymous(roomId: string, anonymous: MeetRoomAnonymousConfig): Promise<MeetRoom> {
@ -293,13 +282,8 @@ export class RoomService {
throw errorRoomActiveMeeting(roomId);
}
if (anonymous.moderator) {
room.anonymous.moderator.enabled = anonymous.moderator.enabled;
}
if (anonymous.speaker) {
room.anonymous.speaker.enabled = anonymous.speaker.enabled;
}
// Merge existing anonymous config with new anonymous config (partial update)
room.anonymous = merge({}, room.anonymous, anonymous);
await this.roomRepository.update(room);
return room;

3
meet-ce/typings/src/recording.model.ts
View File

@ -9,10 +9,11 @@ export enum MeetRecordingStatus {
ABORTED = 'aborted',
LIMIT_REACHED = 'limit_reached'
}
export enum MeetRecordingLayout {
GRID = 'grid',
SPEAKER = 'speaker',
SINGLE_SPEAKER = 'single-speaker',
SINGLE_SPEAKER = 'single-speaker'
// GRID_LIGHT = 'grid-light',
// SPEAKER_LIGHT = 'speaker-light',
// SINGLE_SPEAKER_LIGHT = 'single-speaker-light'