From 30bd4b5a418b7ccb6b77610a28db9e27775b865b Mon Sep 17 00:00:00 2001 From: CSantosM <4a.santos@gmail.com> Date: Wed, 28 Jan 2026 14:50:32 +0100 Subject: [PATCH] Enable captions by default in room configurations and related tests --- .../components/responses/success-get-room.yaml | 2 +- .../components/responses/success-get-rooms.yaml | 2 +- .../components/schemas/meet-room-config.yaml | 4 ++-- .../src/models/mongoose-schemas/room.schema.ts | 2 +- .../backend/src/models/zod-schemas/room.schema.ts | 4 ++-- meet-ce/backend/tests/helpers/assertion-helpers.ts | 2 +- .../integration/api/rooms/create-room.test.ts | 2 +- .../integration/api/rooms/e2ee-room-config.test.ts | 14 +++++++------- .../integration/api/rooms/get-room-config.test.ts | 2 +- .../api/rooms/recording-layout-room-config.test.ts | 6 +++--- .../api/rooms/update-room-config.test.ts | 2 +- .../domains/rooms/services/wizard-state.service.ts | 2 +- .../webcomponent/tests/helpers/function-helpers.ts | 2 +- 13 files changed, 23 insertions(+), 23 deletions(-) diff --git a/meet-ce/backend/openapi/components/responses/success-get-room.yaml b/meet-ce/backend/openapi/components/responses/success-get-room.yaml index 6fcb7a69..5d3cdf4b 100644 --- a/meet-ce/backend/openapi/components/responses/success-get-room.yaml +++ b/meet-ce/backend/openapi/components/responses/success-get-room.yaml @@ -27,7 +27,7 @@ content: e2ee: enabled: false captions: - enabled: false + enabled: true roles: moderator: permissions: diff --git a/meet-ce/backend/openapi/components/responses/success-get-rooms.yaml b/meet-ce/backend/openapi/components/responses/success-get-rooms.yaml index fb54e370..66463add 100644 --- a/meet-ce/backend/openapi/components/responses/success-get-rooms.yaml +++ b/meet-ce/backend/openapi/components/responses/success-get-rooms.yaml @@ -36,7 +36,7 @@ content: e2ee: enabled: false captions: - enabled: false + enabled: true roles: moderator: permissions: diff --git a/meet-ce/backend/openapi/components/schemas/meet-room-config.yaml b/meet-ce/backend/openapi/components/schemas/meet-room-config.yaml index 9c794afa..d0e03fac 100644 --- a/meet-ce/backend/openapi/components/schemas/meet-room-config.yaml +++ b/meet-ce/backend/openapi/components/schemas/meet-room-config.yaml @@ -88,8 +88,8 @@ MeetCaptionsConfig: properties: enabled: type: boolean - default: false - example: false + default: true + example: true description: > If true, the room will have live captions enabled.
This allows participants to see real-time captions of the all participants' speech during the meeting.
diff --git a/meet-ce/backend/src/models/mongoose-schemas/room.schema.ts b/meet-ce/backend/src/models/mongoose-schemas/room.schema.ts index c09cdf0d..93b6db92 100644 --- a/meet-ce/backend/src/models/mongoose-schemas/room.schema.ts +++ b/meet-ce/backend/src/models/mongoose-schemas/room.schema.ts @@ -113,7 +113,7 @@ const MeetCaptionsConfigSchema = new Schema( enabled: { type: Boolean, required: true, - default: false + default: true } }, { _id: false } diff --git a/meet-ce/backend/src/models/zod-schemas/room.schema.ts b/meet-ce/backend/src/models/zod-schemas/room.schema.ts index 06a7b998..15c2e624 100644 --- a/meet-ce/backend/src/models/zod-schemas/room.schema.ts +++ b/meet-ce/backend/src/models/zod-schemas/room.schema.ts @@ -130,7 +130,7 @@ const CreateRoomConfigSchema = z chat: ChatConfigSchema.optional().default(() => ({ enabled: true })), virtualBackground: VirtualBackgroundConfigSchema.optional().default(() => ({ enabled: true })), e2ee: E2EEConfigSchema.optional().default(() => ({ enabled: false })), - captions: CaptionsConfigSchema.optional().default(() => ({ enabled: false })) + captions: CaptionsConfigSchema.optional().default(() => ({ enabled: true })) // appearance: AppearanceConfigSchema, }) .transform((data) => { @@ -215,7 +215,7 @@ export const RoomOptionsSchema: z.ZodType = z.object({ chat: { enabled: true }, virtualBackground: { enabled: true }, e2ee: { enabled: false }, - captions: { enabled: false } + captions: { enabled: true } }) // maxParticipants: z // .number() diff --git a/meet-ce/backend/tests/helpers/assertion-helpers.ts b/meet-ce/backend/tests/helpers/assertion-helpers.ts index eb1d59d6..64583e53 100644 --- a/meet-ce/backend/tests/helpers/assertion-helpers.ts +++ b/meet-ce/backend/tests/helpers/assertion-helpers.ts @@ -162,7 +162,7 @@ export const expectValidRoom = ( chat: { enabled: true }, virtualBackground: { enabled: true }, e2ee: { enabled: false }, - captions: { enabled: false } + captions: { enabled: true } }); } diff --git a/meet-ce/backend/tests/integration/api/rooms/create-room.test.ts b/meet-ce/backend/tests/integration/api/rooms/create-room.test.ts index 310454b4..c4b83aac 100644 --- a/meet-ce/backend/tests/integration/api/rooms/create-room.test.ts +++ b/meet-ce/backend/tests/integration/api/rooms/create-room.test.ts @@ -138,7 +138,7 @@ describe('Room API Tests', () => { chat: { enabled: false }, virtualBackground: { enabled: false }, e2ee: { enabled: false }, // Default value - captions: { enabled: false } // Default value + captions: { enabled: true } // Default value }; expectValidRoom(room, 'Partial Config Room', 'partial_config_room', expectedConfig, validAutoDeletionDate); }); diff --git a/meet-ce/backend/tests/integration/api/rooms/e2ee-room-config.test.ts b/meet-ce/backend/tests/integration/api/rooms/e2ee-room-config.test.ts index a5484375..db97320e 100644 --- a/meet-ce/backend/tests/integration/api/rooms/e2ee-room-config.test.ts +++ b/meet-ce/backend/tests/integration/api/rooms/e2ee-room-config.test.ts @@ -54,7 +54,7 @@ describe('E2EE Room Configuration Tests', () => { chat: { enabled: true }, virtualBackground: { enabled: true }, e2ee: { enabled: true }, - captions: { enabled: false } + captions: { enabled: true } } }; @@ -94,7 +94,7 @@ describe('E2EE Room Configuration Tests', () => { chat: { enabled: true }, virtualBackground: { enabled: true }, e2ee: { enabled: false }, - captions: { enabled: false } + captions: { enabled: true } } }); @@ -130,7 +130,7 @@ describe('E2EE Room Configuration Tests', () => { chat: { enabled: true }, virtualBackground: { enabled: true }, e2ee: 'invalid-e2ee', // Should be an object - captions: { enabled: false } + captions: { enabled: true } } }; @@ -154,7 +154,7 @@ describe('E2EE Room Configuration Tests', () => { chat: { enabled: true }, virtualBackground: { enabled: true }, e2ee: { enabled: 'yes' }, // Should be a boolean - captions: { enabled: false } + captions: { enabled: true } } }; @@ -184,7 +184,7 @@ describe('E2EE Room Configuration Tests', () => { chat: { enabled: true }, virtualBackground: { enabled: true }, e2ee: { enabled: true }, - captions: { enabled: false } + captions: { enabled: true } }); expect(status).toBe(200); @@ -212,7 +212,7 @@ describe('E2EE Room Configuration Tests', () => { chat: { enabled: true }, virtualBackground: { enabled: true }, e2ee: { enabled: true }, - captions: { enabled: false } + captions: { enabled: true } } }); @@ -226,7 +226,7 @@ describe('E2EE Room Configuration Tests', () => { chat: { enabled: true }, virtualBackground: { enabled: true }, e2ee: { enabled: false }, - captions: { enabled: false } + captions: { enabled: true } } }); diff --git a/meet-ce/backend/tests/integration/api/rooms/get-room-config.test.ts b/meet-ce/backend/tests/integration/api/rooms/get-room-config.test.ts index a3549e9e..7f54f46b 100644 --- a/meet-ce/backend/tests/integration/api/rooms/get-room-config.test.ts +++ b/meet-ce/backend/tests/integration/api/rooms/get-room-config.test.ts @@ -15,7 +15,7 @@ describe('Room API Tests', () => { chat: { enabled: true }, virtualBackground: { enabled: true }, e2ee: { enabled: false }, - captions: { enabled: false } + captions: { enabled: true } }; beforeAll(async () => { diff --git a/meet-ce/backend/tests/integration/api/rooms/recording-layout-room-config.test.ts b/meet-ce/backend/tests/integration/api/rooms/recording-layout-room-config.test.ts index c32552b3..f302b707 100644 --- a/meet-ce/backend/tests/integration/api/rooms/recording-layout-room-config.test.ts +++ b/meet-ce/backend/tests/integration/api/rooms/recording-layout-room-config.test.ts @@ -33,7 +33,7 @@ describe('Room API Tests', () => { chat: { enabled: true }, virtualBackground: { enabled: true }, e2ee: { enabled: false }, - captions: { enabled: false } + captions: { enabled: true } }; expectValidRoom(room, 'Room with Default Layout', 'room_with_default_layout', expectedConfig); }); @@ -61,7 +61,7 @@ describe('Room API Tests', () => { chat: { enabled: true }, virtualBackground: { enabled: true }, e2ee: { enabled: false }, - captions: { enabled: false } + captions: { enabled: true } }; expectValidRoom(room, 'Speaker Layout Room', 'speaker_layout_room', expectedConfig); }); @@ -89,7 +89,7 @@ describe('Room API Tests', () => { chat: { enabled: true }, virtualBackground: { enabled: true }, e2ee: { enabled: false }, - captions: { enabled: false } + captions: { enabled: true } }; expectValidRoom(room, 'Single Speaker Layout Room', 'single_speaker_layout_room', expectedConfig); }); diff --git a/meet-ce/backend/tests/integration/api/rooms/update-room-config.test.ts b/meet-ce/backend/tests/integration/api/rooms/update-room-config.test.ts index 68c90e0f..d8a1a51c 100644 --- a/meet-ce/backend/tests/integration/api/rooms/update-room-config.test.ts +++ b/meet-ce/backend/tests/integration/api/rooms/update-room-config.test.ts @@ -41,7 +41,7 @@ describe('Room API Tests', () => { chat: { enabled: true }, virtualBackground: { enabled: true }, e2ee: { enabled: false }, - captions: { enabled: false } + captions: { enabled: true } } }); diff --git a/meet-ce/frontend/projects/shared-meet-components/src/lib/domains/rooms/services/wizard-state.service.ts b/meet-ce/frontend/projects/shared-meet-components/src/lib/domains/rooms/services/wizard-state.service.ts index 31d00ea2..602934e8 100644 --- a/meet-ce/frontend/projects/shared-meet-components/src/lib/domains/rooms/services/wizard-state.service.ts +++ b/meet-ce/frontend/projects/shared-meet-components/src/lib/domains/rooms/services/wizard-state.service.ts @@ -20,7 +20,7 @@ const DEFAULT_CONFIG: MeetRoomConfig = { chat: { enabled: true }, virtualBackground: { enabled: true }, e2ee: { enabled: false }, - captions: { enabled: false } + captions: { enabled: true } }; /** diff --git a/meet-ce/frontend/webcomponent/tests/helpers/function-helpers.ts b/meet-ce/frontend/webcomponent/tests/helpers/function-helpers.ts index 7406480e..36cbfa43 100644 --- a/meet-ce/frontend/webcomponent/tests/helpers/function-helpers.ts +++ b/meet-ce/frontend/webcomponent/tests/helpers/function-helpers.ts @@ -164,7 +164,7 @@ const getDefaultRoomConfig = (): MeetRoomConfig => ({ chat: { enabled: true }, virtualBackground: { enabled: true }, e2ee: { enabled: false }, - captions: { enabled: false } + captions: { enabled: true } }); // Helper function to create a room for testing