From 770a330e7a077a448347d6777b9f04000e299f0a Mon Sep 17 00:00:00 2001
From: juancarmore <juancar_more2@hotmail.com>
Date: Mon, 12 Jan 2026 12:54:21 +0100
Subject: [PATCH] backend: implement bulk cleanup of user resources, deleting
 all memberships for a user and transfering ownership to the global admin

---
 .../repositories/room-member.repository.ts    | 11 ++++
 meet-ce/backend/src/services/user.service.ts  | 65 ++++++++++++++++++-
 2 files changed, 75 insertions(+), 1 deletion(-)

diff --git a/meet-ce/backend/src/repositories/room-member.repository.ts b/meet-ce/backend/src/repositories/room-member.repository.ts
index 889340bc..962b2012 100644
--- a/meet-ce/backend/src/repositories/room-member.repository.ts
+++ b/meet-ce/backend/src/repositories/room-member.repository.ts
@@ -274,6 +274,17 @@ export class RoomMemberRepository extends BaseRepository<MeetRoomMember, MeetRoo
 		await this.deleteMany({ roomId });
 	}
 
+	/**
+	 * Removes all room memberships for a specific member across all rooms.
+	 * This is useful when deleting a user account.
+	 *
+	 * @param memberId - The ID of the member whose memberships should be deleted
+	 * @throws Error if members could not be deleted
+	 */
+	async deleteAllByMemberId(memberId: string): Promise<void> {
+		await this.deleteMany({ memberId });
+	}
+
 	// ==========================================
 	// PRIVATE HELPER METHODS
 	// ==========================================
diff --git a/meet-ce/backend/src/services/user.service.ts b/meet-ce/backend/src/services/user.service.ts
index 07f2f389..702a8a00 100644
--- a/meet-ce/backend/src/services/user.service.ts
+++ b/meet-ce/backend/src/services/user.service.ts
@@ -3,6 +3,8 @@ import { inject, injectable } from 'inversify';
 import { MEET_ENV } from '../environment.js';
 import { PasswordHelper } from '../helpers/password.helper.js';
 import { errorInvalidPassword, errorUserAlreadyExists, errorUserNotFound } from '../models/error.model.js';
+import { RoomMemberRepository } from '../repositories/room-member.repository.js';
+import { RoomRepository } from '../repositories/room.repository.js';
 import { UserRepository } from '../repositories/user.repository.js';
 import { LoggerService } from './logger.service.js';
 
@@ -10,7 +12,9 @@ import { LoggerService } from './logger.service.js';
 export class UserService {
 	constructor(
 		@inject(LoggerService) protected logger: LoggerService,
-		@inject(UserRepository) protected userRepository: UserRepository
+		@inject(UserRepository) protected userRepository: UserRepository,
+		@inject(RoomRepository) protected roomRepository: RoomRepository,
+		@inject(RoomMemberRepository) protected roomMemberRepository: RoomMemberRepository
 	) {}
 
 	/**
@@ -107,7 +111,12 @@ export class UserService {
 			throw errorUserNotFound(userId);
 		}
 
+		// Clean up user resources using bulk method
+		await this.bulkCleanupUserResources([userId]);
+
+		// Finally, delete the user
 		await this.userRepository.deleteByUserId(userId);
+		this.logger.info(`User '${userId}' deleted successfully`);
 	}
 
 	async bulkDeleteUsers(
@@ -121,7 +130,12 @@ export class UserService {
 			.map((id) => ({ userId: id, error: 'User not found' }));
 
 		if (foundUserIds.length > 0) {
+			// Clean up resources for all users in batches
+			await this.bulkCleanupUserResources(foundUserIds);
+
+			// Delete all users after cleanup
 			await this.userRepository.deleteByUserIds(foundUserIds);
+			this.logger.info(`Bulk deleted ${foundUserIds.length} user(s) successfully`);
 		}
 
 		return {
@@ -130,6 +144,55 @@ export class UserService {
 		};
 	}
 
+	/**
+	 * Cleans up resources for multiple users in batches:
+	 * - Deletes all room memberships
+	 * - Transfers ownership of owned rooms to the global admin
+	 *
+	 * @param userIds - Array of user IDs to clean up
+	 */
+	private async bulkCleanupUserResources(userIds: string[]): Promise<void> {
+		const adminUserId = MEET_ENV.INITIAL_ADMIN_USER;
+		const USER_BATCH_SIZE = 10; // Process users in batches of 10
+		const ROOM_UPDATE_BATCH_SIZE = 50; // Update rooms in batches of 50
+
+		// Process users in batches
+		for (let i = 0; i < userIds.length; i += USER_BATCH_SIZE) {
+			const userBatch = userIds.slice(i, i + USER_BATCH_SIZE);
+
+			// Delete all memberships and fetch all owned rooms for this batch in parallel
+			const [, ownedRoomsPerUser] = await Promise.all([
+				// Delete memberships for all users in this batch in parallel
+				Promise.all(userBatch.map((userId) => this.roomMemberRepository.deleteAllByMemberId(userId))),
+				// Fetch owned rooms for all users in this batch in parallel
+				Promise.all(userBatch.map((userId) => this.roomRepository.findByOwner(userId)))
+			]);
+
+			// Flatten all owned rooms from this batch
+			const batchOwnedRooms = ownedRoomsPerUser.flat();
+
+			if (batchOwnedRooms.length > 0) {
+				// Update rooms in sub-batches to avoid overwhelming the database
+				for (let j = 0; j < batchOwnedRooms.length; j += ROOM_UPDATE_BATCH_SIZE) {
+					const roomBatch = batchOwnedRooms.slice(j, j + ROOM_UPDATE_BATCH_SIZE);
+
+					await Promise.all(
+						roomBatch.map((room) => {
+							room.owner = adminUserId;
+							return this.roomRepository.update(room);
+						})
+					);
+				}
+
+				this.logger.info(
+					`Processed batch: Transferred ownership of ${batchOwnedRooms.length} room(s) from ${userBatch.length} user(s) to admin '${adminUserId}'`
+				);
+			}
+		}
+
+		this.logger.info(`Completed cleanup for ${userIds.length} user(s)`);
+	}
+
 	// Convert user to UserDTO to remove sensitive information
 	convertToDTO(user: MeetUser): MeetUserDTO {
 		// eslint-disable-next-line @typescript-eslint/no-unused-vars