neoris/openvidu-meet
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

frontend: Improves HTTP error handling

Browse Source 
Refactors error handling to allow handlers to directly return a response.

Updates the error handler service to return null when no handler can process an error.
This commit is contained in:
Carlos Santos 2026-01-15 13:11:18 +01:00
parent d9e064e971
commit b24992ad24
2 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
meet-ce/frontend/projects/shared-meet-components/src/lib/shared/interceptors/http.interceptor.ts
View File

@ -52,17 +52,17 @@ export const httpInterceptor: HttpInterceptorFn = (req: HttpRequest<unknown>, ne
return next(req).pipe(
catchError((error: HttpErrorResponse) => {
// Attempt recovery through registered domain handlers
const recovery$ = httpErrorNotifier.handle({
const responseHandler$ = httpErrorNotifier.handle({
error,
request: req,
pageUrl,
next
});
// If a handler provided a recovery strategy, use it
// If a handler provided a response Observable, return it
// Otherwise, rethrow the error
if (recovery$) {
return recovery$;
if (responseHandler$) {
return responseHandler$;
}
return throwError(() => error);

10
meet-ce/frontend/projects/shared-meet-components/src/lib/shared/services/http-error-notifier.service.ts
View File

@ -1,6 +1,6 @@
import { HttpErrorResponse, HttpEvent, HttpHandlerFn, HttpRequest } from '@angular/common/http';
import { Injectable } from '@angular/core';
import { EMPTY, Observable } from 'rxjs';
import { Observable } from 'rxjs';
/**
* Context information about an HTTP error
@ -51,12 +51,12 @@ export class HttpErrorNotifierService {
/**
* Attempts to recover from an HTTP error by consulting registered handlers.
* Returns an Observable from the first handler that can recover, or EMPTY if none can handle it.
* Returns an Observable from the first handler that can recover, or null if none can handle it.
*
* @param context The error context
* @returns Observable to retry the request, or EMPTY if no handler can recover
* @returns Observable to retry the request, or null if no handler can recover
*/
public handle(context: HttpErrorContext): Observable<HttpEvent<unknown>> {
public handle(context: HttpErrorContext): Observable<HttpEvent<unknown>> | null {
for (const handler of this.handlers) {
if (handler.canHandle(context)) {
return handler.handle(context);
@ -64,6 +64,6 @@ export class HttpErrorNotifierService {
}
// No handler could handle this error
return EMPTY;
return null;
}
}