From db279faee4f5a82e34288ca83eda3cbee1285c62 Mon Sep 17 00:00:00 2001
From: juancarmore <juancar_more2@hotmail.com>
Date: Thu, 26 Feb 2026 22:07:37 +0100
Subject: [PATCH] backend: update deleteRecording method to return void and
 improve hasRoomRecordings query efficiency

---
 meet-ce/backend/src/services/recording.service.ts | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/meet-ce/backend/src/services/recording.service.ts b/meet-ce/backend/src/services/recording.service.ts
index 20d40144..02deb404 100644
--- a/meet-ce/backend/src/services/recording.service.ts
+++ b/meet-ce/backend/src/services/recording.service.ts
@@ -504,7 +504,7 @@ export class RecordingService {
 	 * @param recordingId - The unique identifier of the recording to delete.
 	 * @returns The recording information that was deleted.
 	 */
-	async deleteRecording(recordingId: string): Promise<MeetRecordingInfo> {
+	async deleteRecording(recordingId: string): Promise<void> {
 		try {
 			// Get the recording metadata from MongoDB
 			const recordingInfo = await this.recordingRepository.findByRecordingId(recordingId);
@@ -523,8 +523,6 @@ export class RecordingService {
 			]);
 
 			this.logger.info(`Successfully deleted recording ${recordingId}`);
-
-			return recordingInfo;
 		} catch (error) {
 			this.logger.error(`Error deleting recording ${recordingId}: ${error}`);
 			throw error;
@@ -576,11 +574,12 @@ export class RecordingService {
 	 */
 	async hasRoomRecordings(roomId: string): Promise<boolean> {
 		try {
-			const response = await this.recordingRepository.find({
+			const { recordings } = await this.recordingRepository.find({
 				roomId,
-				maxItems: 1
+				maxItems: 1,
+				fields: ['recordingId']
 			});
-			return response.recordings.length > 0;
+			return recordings.length > 0;
 		} catch (error) {
 			this.logger.warn(`Error checking recordings for room '${roomId}': ${error}`);
 			return false;