neoris/openvidu
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

backend: Refactor getRooms and assertEmptyRooms functions to remove app parameter

Browse Source
This commit is contained in:
Carlos Santos 2025-04-11 11:46:51 +02:00
parent f0092b9d04
commit 0f9e3bcf0a
2 changed files with 28 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
backend/tests/integration/api/rooms/get-rooms.test.ts
View File

@ -32,17 +32,17 @@ describe('OpenVidu Meet Room API Tests', () => {
describe('List Rooms Tests', () => { describe('List Rooms Tests', () => {
it('should return an empty list of rooms', async () => { it('should return an empty list of rooms', async () => {
await assertEmptyRooms(app); await assertEmptyRooms();
}); });
it('should return a list of rooms', async () => { it('should return a list of rooms', async () => {
await assertEmptyRooms(app); await assertEmptyRooms();
await createRoom(app, { await createRoom({
roomIdPrefix: 'test-room' roomIdPrefix: 'test-room'
}); });
const body = await getRooms(app); const body = await getRooms();
const { rooms } = body; const { rooms } = body;
assertRoomsResponse(body, 1, 10, false, false); assertRoomsResponse(body, 1, 10, false, false);
@ -57,14 +57,14 @@ describe('OpenVidu Meet Room API Tests', () => {
}); });
it('should return a list of rooms applying fields filter', async () => { it('should return a list of rooms applying fields filter', async () => {
await assertEmptyRooms(app); await assertEmptyRooms();
await createRoom(app, { await createRoom({
roomIdPrefix: 'test-room', roomIdPrefix: 'test-room',
autoDeletionDate: validAutoDeletionDate autoDeletionDate: validAutoDeletionDate
}); });
const body = await getRooms(app, { fields: 'roomId,createdAt' }); const body = await getRooms({ fields: 'roomId,createdAt' });
const { rooms } = body; const { rooms } = body;
assertRoomsResponse(body, 1, 10, false, false); assertRoomsResponse(body, 1, 10, false, false);
@ -83,34 +83,34 @@ describe('OpenVidu Meet Room API Tests', () => {
}); });
it('should return a list of rooms with pagination', async () => { it('should return a list of rooms with pagination', async () => {
await assertEmptyRooms(app); await assertEmptyRooms();
const promises = [1, 2, 3, 4, 5, 6].map((i) => { const promises = [1, 2, 3, 4, 5, 6].map((i) => {
return createRoom(app, { return createRoom({
roomIdPrefix: `test-room-${i}`, roomIdPrefix: `test-room-${i}`,
autoDeletionDate: validAutoDeletionDate autoDeletionDate: validAutoDeletionDate
}); });
}); });
await Promise.all(promises); await Promise.all(promises);
let body = await getRooms(app, { maxItems: 3 }); let body = await getRooms({ maxItems: 3 });
const { pagination } = body; const { pagination } = body;
assertRoomsResponse(body, 3, 3, true, true); assertRoomsResponse(body, 3, 3, true, true);
const nextPageToken = pagination.nextPageToken; const nextPageToken = pagination.nextPageToken;
body = await getRooms(app, { maxItems: 3, nextPageToken }); body = await getRooms({ maxItems: 3, nextPageToken });
assertRoomsResponse(body, 3, 3, false, false); assertRoomsResponse(body, 3, 3, false, false);
}); });
it('should capped maxItems to the maximum allowed', async () => { it('should capped maxItems to the maximum allowed', async () => {
const body = await getRooms(app, { maxItems: 101 }); const body = await getRooms({ maxItems: 101 });
assertRoomsResponse(body, 0, 100, false, false); assertRoomsResponse(body, 0, 100, false, false);
}); });
it('should coerce a floating number to an integer for maxItems', async () => { it('should coerce a floating number to an integer for maxItems', async () => {
const body = await getRooms(app, { maxItems: 12.78 }); const body = await getRooms({ maxItems: 12.78 });
assertRoomsResponse(body, 0, 12, false, false); assertRoomsResponse(body, 0, 12, false, false);
}); });

18
backend/tests/utils/helpers.ts
View File

@ -77,6 +77,10 @@ export const stopTestServer = async (): Promise<void> => {
console.log('Test server stopped.'); console.log('Test server stopped.');
resolve(); resolve();
} }
// Clear the app instance
app = undefined as unknown as Express;
server = undefined as unknown as Server;
}); });
}); });
}; };
@ -149,7 +153,11 @@ export const createRoom = async (options: MeetRoomOptions): Promise<MeetRoom> =>
* Performs a GET /rooms request with provided query parameters. * Performs a GET /rooms request with provided query parameters.
* Returns the parsed response. * Returns the parsed response.
*/ */
export const getRooms = async (app: Express, query: Record<string, any> = {}) => { export const getRooms = async (query: Record<string, any> = {}) => {
if (!app) {
throw new Error('App instance is not defined');
}
const response = await request(app) const response = await request(app)
.get(`${MEET_API_BASE_PATH_V1}/rooms`) .get(`${MEET_API_BASE_PATH_V1}/rooms`)
.set(API_KEY_HEADER, MEET_API_KEY) .set(API_KEY_HEADER, MEET_API_KEY)
@ -190,8 +198,12 @@ export const assertRoomsResponse = (
expect(body.pagination.maxItems).toBe(expectedMaxItems); expect(body.pagination.maxItems).toBe(expectedMaxItems);
}; };
export const assertEmptyRooms = async (app: Express) => { export const assertEmptyRooms = async () => {
const body = await getRooms(app); if (!app) {
throw new Error('App instance is not defined');
}
const body = await getRooms();
assertRoomsResponse(body, 0, 10, false, false); assertRoomsResponse(body, 0, 10, false, false);
}; };