neoris/openvidu
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

backend: Simplify lock duration calculation in TaskSchedulerService and remove unused cron interval method

Browse Source
This commit is contained in:
Carlos Santos 2025-04-08 09:54:33 +02:00
parent f64f200e88
commit 1747c138b4
1 changed files with 1 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
backend/src/services/task-scheduler.service.ts
View File

@ -5,7 +5,6 @@ import { CronJob } from 'cron';
import { MutexService } from './mutex.service.js';
import { MeetLock } from '../helpers/redis.helper.js';
import ms from 'ms';
import { CronExpressionParser } from 'cron-parser';
export type TaskType = 'cron' | 'timeout';
@ -65,7 +64,7 @@ export class TaskSchedulerService {
if (type === 'cron') {
this.logger.debug(`Scheduling cron task "${name}" with schedule "${scheduleOrDelay}"`);
const cronExpression = this.msStringToCronExpression(scheduleOrDelay);
const lockDuration = this.getCronIntervalDuration(cronExpression);
const lockDuration = Math.max(ms(scheduleOrDelay) - ms('1m'), ms('59s'));
const job = new CronJob(cronExpression, async () => {
try {
@ -123,27 +122,6 @@ export class TaskSchedulerService {
}
}
protected getCronIntervalDuration(cronExpression: string): number {
try {
// Parse the cron expression using cron-parser
const interval = CronExpressionParser.parse(cronExpression);
// Get the next interval time
const next = interval.next().getTime();
// Get the current time
const afterNext = interval.next().getTime();
// Calculate the interval duration in milliseconds
const intervalMs = afterNext - next;
// Return the interval duration minus 1 minute for ensuring the lock expires before the next iteration
return Math.max(intervalMs - ms('1m'), ms('10s'));
} catch (error) {
this.logger.error('Error parsing cron expression:', error);
throw new Error('Invalid cron expression');
}
}
/**
* Converts a human-readable time string to a cron expression.
*