From 185d6e9def60ec42333cdda7e9b90dde3b7e4ca1 Mon Sep 17 00:00:00 2001
From: Carlos Santos <4a.santos@gmail.com>
Date: Wed, 7 May 2025 13:00:48 +0200
Subject: [PATCH] tests: Enhance race conditions tests for recording API with
 additional consistency checks

---
 .../api/recordings/race-conditions.test.ts    | 26 ++++++++++++++++---
 1 file changed, 23 insertions(+), 3 deletions(-)

diff --git a/backend/tests/integration/api/recordings/race-conditions.test.ts b/backend/tests/integration/api/recordings/race-conditions.test.ts
index 4bcf085..4a814a4 100644
--- a/backend/tests/integration/api/recordings/race-conditions.test.ts
+++ b/backend/tests/integration/api/recordings/race-conditions.test.ts
@@ -11,6 +11,7 @@ import {
 	deleteAllRecordings,
 	deleteAllRooms,
 	deleteRecording,
+	getRecording,
 	getRecordingMedia,
 	sleep,
 	startRecording,
@@ -191,10 +192,29 @@ describe('Recording API Race Conditions Tests', () => {
 
 		const deleteSuccessful = deleteResponse.status === 'fulfilled' && deleteResponse.value.status === 204;
 
-		expect(streamSuccessful || deleteSuccessful).toBe(true);
+		console.log(`Stream successful: ${streamSuccessful}, Delete successful: ${deleteSuccessful}`);
 
-		// If both operations are successful, it means that the logic has a problem
-		expect(streamSuccessful && deleteSuccessful).toBe(false);
+		if (deleteSuccessful) {
+			// If delete was successful, verify that a new streaming request fails
+			// This ensures the recording was actually deleted
+			const verificationStreamResponse = await getRecordingMedia(recordingId);
+			expect(verificationStreamResponse.status).not.toEqual(200);
+			expect(verificationStreamResponse.status).not.toEqual(206);
+		}
+
+		if (streamSuccessful && deleteSuccessful) {
+			// Both operations succeeded - this is possible if streaming started first
+			// and had an open connection when delete happened
+			// The system should still be in a consistent state where the recording is gone
+
+			console.log('Both operations succeeded - checking system consistency');
+
+			// Verify the recording doesn't exist in storage anymore
+			const verificationRecordingResponse = await getRecording(recordingId);
+			expect(verificationRecordingResponse.status).toBe(404);
+		}
+
+		expect(streamSuccessful || deleteSuccessful).toBe(true);
 	});
 
 	it('should handle race condition between bulk delete and recording start', async () => {