neoris/openvidu
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

backend: Update validation error messages and add room ID validation middleware

Browse Source
This commit is contained in:
Carlos Santos 2025-04-07 18:11:45 +02:00
parent 990f23f7b2
commit 546e17f1e5
6 changed files with 20 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
backend/src/middlewares/request-validators/auth-validator.middleware.ts
View File

@ -17,7 +17,7 @@ export const validateLoginRequest = (req: Request, res: Response, next: NextFunc
return res.status(422).json({
error: 'Unprocessable Entity',
message: 'Invalid request body',
message: 'Invalid request',
details: errors
});
}

2
backend/src/middlewares/request-validators/participant-validator.middleware.ts
View File

@ -44,7 +44,7 @@ const rejectRequest = (res: Response, error: z.ZodError) => {
return res.status(422).json({
error: 'Unprocessable Entity',
message: 'Invalid request body',
message: 'Invalid request',
details: errors
});
};

2
backend/src/middlewares/request-validators/preferences-validator.middleware.ts
View File

@ -75,7 +75,7 @@ const rejectRequest = (res: Response, error: z.ZodError) => {
return res.status(422).json({
error: 'Unprocessable Entity',
message: 'Invalid request body',
message: 'Invalid request',
details: errors
});
};

2
backend/src/middlewares/request-validators/recording-validator.middleware.ts
View File

@ -110,7 +110,7 @@ const rejectRequest = (res: Response, error: z.ZodError) => {
return res.status(422).json({
error: 'Unprocessable Entity',
message: 'Invalid request body',
message: 'Invalid request',
details: errors
});
};

15
backend/src/middlewares/request-validators/room-validator.middleware.ts
View File

@ -101,7 +101,7 @@ const BulkDeleteRoomsSchema = z.object({
return arg;
},
z.array(nonEmptySanitizedString('recordingId')).default([])
z.array(nonEmptySanitizedString('roomId')).default([])
)
});
@ -142,6 +142,17 @@ export const withValidRoomPreferences = (req: Request, res: Response, next: Next
next();
};
export const withValidRoomId = (req: Request, res: Response, next: NextFunction) => {
const { success, error, data } = nonEmptySanitizedString('roomId').safeParse(req.params.roomId);
if (!success) {
return rejectRequest(res, error);
}
req.params.roomId = data;
next();
};
export const withValidRoomBulkDeleteRequest = (req: Request, res: Response, next: NextFunction) => {
const { success, error, data } = BulkDeleteRoomsSchema.safeParse(req.query);
@ -172,7 +183,7 @@ const rejectRequest = (res: Response, error: z.ZodError) => {
return res.status(422).json({
error: 'Unprocessable Entity',
message: 'Invalid request body',
message: 'Invalid request',
details: errors
});
};

4
backend/src/routes/room.routes.ts
View File

@ -12,7 +12,8 @@ import {
configureCreateRoomAuth,
configureRoomAuthorization,
withValidRoomPreferences,
withValidRoomBulkDeleteRequest
withValidRoomBulkDeleteRequest,
withValidRoomId
} from '../middlewares/index.js';
import { UserRole } from '@typings-ce';
@ -39,6 +40,7 @@ roomRouter.get(
'/:roomId',
withAuth(apiKeyValidator, tokenAndRoleValidator(UserRole.ADMIN), participantTokenValidator),
configureRoomAuthorization,
withValidRoomId,
roomCtrl.getRoom
);
roomRouter.delete('/:roomId', withAuth(apiKeyValidator, tokenAndRoleValidator(UserRole.ADMIN)), roomCtrl.deleteRoom);