From 686af46102212e894aa95551f75818099e978876 Mon Sep 17 00:00:00 2001 From: juancarmore Date: Tue, 9 Sep 2025 20:01:48 +0200 Subject: [PATCH] Refactor webcomponent events to use camelCase and enums to use snake_case naming conventions --- .../parameters/recording-status.yaml | 16 +++--- .../internal/success-start-recording.yaml | 2 +- .../internal/success-stop-recording.yaml | 2 +- .../responses/success-get-recording.yaml | 4 +- .../responses/success-get-recordings.yaml | 8 +-- .../internal/security-preferences.yaml | 8 +-- .../components/schemas/meet-recording.yaml | 4 +- .../schemas/meet-room-preferences.yaml | 12 ++-- .../openapi/paths/internal/recordings.yaml | 2 +- backend/openapi/paths/recordings.yaml | 2 +- backend/openapi/webhooks/webhooks.yaml | 16 +++--- backend/tests/helpers/assertion-helpers.ts | 2 +- .../api/global-preferences/security.test.ts | 2 +- .../rooms/generate-recording-token.test.ts | 8 +-- .../api/security/recording-security.test.ts | 56 +++++++++---------- .../view-recording.component.html | 2 +- .../view-recording.component.scss | 10 ++-- .../tests/e2e/core/events.test.ts | 30 +++++----- .../tests/helpers/function-helpers.ts | 2 +- .../webcomponent/tests/unit/events.test.ts | 6 +- .../webcomponent/tests/unit/lifecycle.test.ts | 4 +- testapp/public/ts/webcomponent.ts | 18 +++--- testapp/public/views/index.mustache | 4 +- testapp/src/controllers/homeController.ts | 2 +- typings/src/auth-preferences.ts | 6 +- typings/src/recording.model.ts | 16 +++--- typings/src/room-preferences.ts | 4 +- typings/src/webcomponent/command.model.ts | 8 +-- typings/src/webcomponent/event.model.ts | 8 +-- 29 files changed, 132 insertions(+), 132 deletions(-) diff --git a/backend/openapi/components/parameters/recording-status.yaml b/backend/openapi/components/parameters/recording-status.yaml index ddd39b6..ee469ce 100644 --- a/backend/openapi/components/parameters/recording-status.yaml +++ b/backend/openapi/components/parameters/recording-status.yaml @@ -4,16 +4,16 @@ required: false description: | Filter recordings by their status. - You can provide multiple statuses as a comma-separated list (e.g., `status=ACTIVE,FAILED`). + You can provide multiple statuses as a comma-separated list (e.g., `status=active,failed`). > ⚠️ **Note:** Using this filter may impact performance for large datasets. schema: type: string enum: - - STARTING - - ACTIVE - - ENDING - - COMPLETE - - FAILED - - ABORTED - - LIMIT_REACHED + - starting + - active + - ending + - complete + - failed + - aborted + - limit_reached diff --git a/backend/openapi/components/responses/internal/success-start-recording.yaml b/backend/openapi/components/responses/internal/success-start-recording.yaml index 769e252..6710d0b 100644 --- a/backend/openapi/components/responses/internal/success-start-recording.yaml +++ b/backend/openapi/components/responses/internal/success-start-recording.yaml @@ -7,7 +7,7 @@ content: recordingId: 'room-123--EG_XYZ--XX445' roomId: 'room-123' roomName: 'room' - status: 'ACTIVE' + status: 'active' filename: 'room-123--XX445.mp4' startDate: 1600000000000 headers: diff --git a/backend/openapi/components/responses/internal/success-stop-recording.yaml b/backend/openapi/components/responses/internal/success-stop-recording.yaml index b606e96..0e05e00 100644 --- a/backend/openapi/components/responses/internal/success-stop-recording.yaml +++ b/backend/openapi/components/responses/internal/success-stop-recording.yaml @@ -13,7 +13,7 @@ content: recordingId: 'room-123--EG_XYZ--XX445' roomId: 'room-123' roomName: 'room' - status: 'ENDING' + status: 'ending' filename: 'room-123--XX445.mp4' startDate: 1600000000000 details: 'End reason: StopEgress API' diff --git a/backend/openapi/components/responses/success-get-recording.yaml b/backend/openapi/components/responses/success-get-recording.yaml index f992114..d2bd885 100644 --- a/backend/openapi/components/responses/success-get-recording.yaml +++ b/backend/openapi/components/responses/success-get-recording.yaml @@ -10,7 +10,7 @@ content: recordingId: 'room-123--EG_XYZ--XX445' roomId: 'room-123' roomName: 'room' - status: 'COMPLETE' + status: 'complete' filename: 'room-123--XX445.mp4' startDate: 1600000000000 endDate: 1600000003600 @@ -24,6 +24,6 @@ content: recordingId: 'room-456--EG_ABC--QR789' roomId: 'room-456' roomName: 'room' - status: 'ACTIVE' + status: 'active' filename: 'room-456--QR789.mp4' startDate: 1682500000000 diff --git a/backend/openapi/components/responses/success-get-recordings.yaml b/backend/openapi/components/responses/success-get-recordings.yaml index 8c86117..897772a 100644 --- a/backend/openapi/components/responses/success-get-recordings.yaml +++ b/backend/openapi/components/responses/success-get-recordings.yaml @@ -18,7 +18,7 @@ content: - recordingId: 'room-123--EG_XYZ--XX445' roomId: 'room-123' roomName: 'room' - status: 'ACTIVE' + status: 'active' filename: 'room-123--XX445.mp4' startDate: 1620000000000 endDate: 1620000003600 @@ -28,7 +28,7 @@ content: - recordingId: 'room-456--EG_ZYX--XX678' roomId: 'room-456' roomName: 'room' - status: 'COMPLETE' + status: 'complete' filename: 'room-456--XX678.mp4' startDate: 1625000000000 endDate: 1625000007200 @@ -54,11 +54,11 @@ content: recordings: - recordingId: 'room-123--EG_XYZ--XX445' roomId: 'room-123' - status: 'ACTIVE' + status: 'active' size: 1024 - recordingId: 'room-456--EG_ZYX--XX678' roomId: 'room-456' - status: 'COMPLETE' + status: 'complete' size: 2048 pagination: isTruncated: false diff --git a/backend/openapi/components/schemas/internal/security-preferences.yaml b/backend/openapi/components/schemas/internal/security-preferences.yaml index 777cc45..3a2adbc 100644 --- a/backend/openapi/components/schemas/internal/security-preferences.yaml +++ b/backend/openapi/components/schemas/internal/security-preferences.yaml @@ -13,12 +13,12 @@ AuthenticationPreferences: type: type: string enum: - - single-user - default: single-user - example: single-user + - single_user + default: single_user + example: single_user description: | Specifies the authentication method used to access the application. - - `single-user`: Only one user account exists, which has administrative privileges and is used for all access. + - `single_user`: Only one user account exists, which has administrative privileges and is used for all access. authModeToAccessRoom: type: string enum: diff --git a/backend/openapi/components/schemas/meet-recording.yaml b/backend/openapi/components/schemas/meet-recording.yaml index 3764b23..709bde2 100644 --- a/backend/openapi/components/schemas/meet-recording.yaml +++ b/backend/openapi/components/schemas/meet-recording.yaml @@ -19,8 +19,8 @@ properties: # The output mode of the recording. Possible value: "COMPOSED". status: type: string - enum: ['STARTING', 'ACTIVE', 'ENDING', 'COMPLETE', 'FAILED', 'ABORTED', 'LIMIT_REACHED'] - example: 'ACTIVE' + enum: ['starting', 'active', 'ending', 'complete', 'failed', 'aborted', 'limit_reached'] + example: 'active' description: The status of the recording. filename: type: string diff --git a/backend/openapi/components/schemas/meet-room-preferences.yaml b/backend/openapi/components/schemas/meet-room-preferences.yaml index 0962193..5f77419 100644 --- a/backend/openapi/components/schemas/meet-room-preferences.yaml +++ b/backend/openapi/components/schemas/meet-room-preferences.yaml @@ -30,15 +30,15 @@ MeetRecordingPreferences: type: string enum: - admin - - admin-moderator - - admin-moderator-speaker - default: admin-moderator-speaker - example: admin-moderator-speaker + - admin_moderator + - admin_moderator_speaker + default: admin_moderator_speaker + example: admin_moderator_speaker description: | Defines who can access the recording. Options are: - `admin`: Only administrators can access the recording. - - `admin-moderator`: Administrators and moderators can access the recording. - - `admin-moderator-speaker`: Administrators, moderators and speakers can access the recording. + - `admin_moderator`: Administrators and moderators can access the recording. + - `admin_moderator_speaker`: Administrators, moderators and speakers can access the recording. MeetVirtualBackgroundPreferences: type: object properties: diff --git a/backend/openapi/paths/internal/recordings.yaml b/backend/openapi/paths/internal/recordings.yaml index 3a20e66..6448ce4 100644 --- a/backend/openapi/paths/internal/recordings.yaml +++ b/backend/openapi/paths/internal/recordings.yaml @@ -38,7 +38,7 @@ description: | Stops a recording with the specified recording ID. - > **Note:** The recording must be in an `ACTIVE` state; otherwise, a 409 error is returned. + > **Note:** The recording must be in an `active` state; otherwise, a 409 error is returned. tags: - Internal API - Recordings security: diff --git a/backend/openapi/paths/recordings.yaml b/backend/openapi/paths/recordings.yaml index 782d434..1ab8a32 100644 --- a/backend/openapi/paths/recordings.yaml +++ b/backend/openapi/paths/recordings.yaml @@ -146,7 +146,7 @@ Deletes a recording with the specified recording ID. > ⚠️ **Note:** The recording will only be deleted if it exists and is not in progress - > (i.e., not in a state such as `ACTIVE`, `STARTING`, or `ENDING`). + > (i.e., not in a state such as `active`, `starting`, or `ending`). tags: - OpenVidu Meet - Recordings security: diff --git a/backend/openapi/webhooks/webhooks.yaml b/backend/openapi/webhooks/webhooks.yaml index 748fcec..b0cc9cd 100644 --- a/backend/openapi/webhooks/webhooks.yaml +++ b/backend/openapi/webhooks/webhooks.yaml @@ -4,7 +4,7 @@ recordingStarted: description: | This webhook is triggered when a recording starts. - > The recording can be in the `STARTING` status for a few seconds before it becomes `ACTIVE`. + > The recording can be in the `starting` status for a few seconds before it becomes `active`. operationId: recordingStartedWebhook parameters: - $ref: ../components/parameters/x-timestamp.yaml @@ -26,8 +26,8 @@ recordingStarted: - $ref: ../components/schemas/recording-base.yaml - properties: status: - enum: [STARTING, ACTIVE] - example: STARTING + enum: [starting, active] + example: starting responses: '200': $ref: ../components/responses/webhook-success.yaml @@ -38,7 +38,7 @@ recordingUpdated: description: | This webhook is triggered when a recording update occurs. - > This update can be due to a change in the recording status (e.g., from `STARTING` to `ACTIVE`). + > This update can be due to a change in the recording status (e.g., from `starting` to `active`). operationId: recordingUpdatedWebhook parameters: - $ref: ../components/parameters/x-timestamp.yaml @@ -60,8 +60,8 @@ recordingUpdated: - $ref: ../components/schemas/recording-base.yaml - properties: status: - enum: [ACTIVE, ENDING] - example: ACTIVE + enum: [active, ending] + example: active responses: '200': $ref: ../components/responses/webhook-success.yaml @@ -100,8 +100,8 @@ recordingEnded: - $ref: ../components/schemas/recording-base.yaml - properties: status: - enum: [COMPLETE, FAILED, ABORTED, LIMIT_REACHED] - example: COMPLETE + enum: [complete, failed, aborted, limit_reached] + example: complete endDate: type: number description: The date when the recording ended (milliseconds since the Unix epoch). diff --git a/backend/tests/helpers/assertion-helpers.ts b/backend/tests/helpers/assertion-helpers.ts index 3db2147..15b0065 100644 --- a/backend/tests/helpers/assertion-helpers.ts +++ b/backend/tests/helpers/assertion-helpers.ts @@ -361,7 +361,7 @@ export const expectValidStartRecordingResponse = (response: any, roomId: string, expect(response.body).toHaveProperty('roomId', roomId); expect(response.body).toHaveProperty('roomName', roomName); expect(response.body).toHaveProperty('startDate'); - expect(response.body).toHaveProperty('status', 'ACTIVE'); + expect(response.body).toHaveProperty('status', 'active'); expect(response.body).toHaveProperty('filename'); expect(response.body).not.toHaveProperty('duration'); expect(response.body).not.toHaveProperty('endDate'); diff --git a/backend/tests/integration/api/global-preferences/security.test.ts b/backend/tests/integration/api/global-preferences/security.test.ts index ee5f3ae..1a37a1b 100644 --- a/backend/tests/integration/api/global-preferences/security.test.ts +++ b/backend/tests/integration/api/global-preferences/security.test.ts @@ -84,7 +84,7 @@ describe('Security Preferences API Tests', () => { expectValidationError( response, 'authentication.authMethod.type', - "Invalid enum value. Expected 'single-user', received 'invalid'" + "Invalid enum value. Expected 'single_user', received 'invalid'" ); }); diff --git a/backend/tests/integration/api/rooms/generate-recording-token.test.ts b/backend/tests/integration/api/rooms/generate-recording-token.test.ts index a294a01..51bdcd4 100644 --- a/backend/tests/integration/api/rooms/generate-recording-token.test.ts +++ b/backend/tests/integration/api/rooms/generate-recording-token.test.ts @@ -27,14 +27,14 @@ describe('Room API Tests', () => { }); describe('Generate Recording Token Tests', () => { - it('should generate a recording token with canRetrieve and canDelete permissions when using the moderator secret and recording access is admin-moderator', async () => { + it('should generate a recording token with canRetrieve and canDelete permissions when using the moderator secret and recording access is admin_moderator', async () => { await updateRecordingAccessPreferencesInRoom(roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR); const response = await generateRecordingToken(roomData.room.roomId, roomData.moderatorSecret); expectValidRecordingTokenResponse(response, roomData.room.roomId, ParticipantRole.MODERATOR, true, true); }); - it('should generate a recording token with canRetrieve and canDelete permissions when using the moderator secret and recording access is admin-moderator-speaker', async () => { + it('should generate a recording token with canRetrieve and canDelete permissions when using the moderator secret and recording access is admin_moderator_speaker', async () => { await updateRecordingAccessPreferencesInRoom( roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR_SPEAKER @@ -44,14 +44,14 @@ describe('Room API Tests', () => { expectValidRecordingTokenResponse(response, roomData.room.roomId, ParticipantRole.MODERATOR, true, true); }); - it('should generate a recording token without any permissions when using the speaker secret and recording access is admin-moderator', async () => { + it('should generate a recording token without any permissions when using the speaker secret and recording access is admin_moderator', async () => { await updateRecordingAccessPreferencesInRoom(roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR); const response = await generateRecordingToken(roomData.room.roomId, roomData.speakerSecret); expectValidRecordingTokenResponse(response, roomData.room.roomId, ParticipantRole.SPEAKER, false, false); }); - it('should generate a recording token with canRetrieve permission but not canDelete when using the speaker secret and recording access is admin-moderator-speaker', async () => { + it('should generate a recording token with canRetrieve permission but not canDelete when using the speaker secret and recording access is admin_moderator_speaker', async () => { await updateRecordingAccessPreferencesInRoom( roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR_SPEAKER diff --git a/backend/tests/integration/api/security/recording-security.test.ts b/backend/tests/integration/api/security/recording-security.test.ts index 3f8427a..dfd0dca 100644 --- a/backend/tests/integration/api/security/recording-security.test.ts +++ b/backend/tests/integration/api/security/recording-security.test.ts @@ -169,7 +169,7 @@ describe('Recording API Security Tests', () => { expect(response.status).toBe(200); }); - it('should succeed when recording access is admin-moderator-speaker and participant is speaker', async () => { + it('should succeed when recording access is admin_moderator_speaker and participant is speaker', async () => { await updateRecordingAccessPreferencesInRoom( roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR_SPEAKER @@ -183,7 +183,7 @@ describe('Recording API Security Tests', () => { expect(response.status).toBe(200); }); - it('should succeed when recording access is admin-moderator-speaker and participant is moderator', async () => { + it('should succeed when recording access is admin_moderator_speaker and participant is moderator', async () => { await updateRecordingAccessPreferencesInRoom( roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR_SPEAKER @@ -197,7 +197,7 @@ describe('Recording API Security Tests', () => { expect(response.status).toBe(200); }); - it('should fail when recording access is admin-moderator and participant is speaker', async () => { + it('should fail when recording access is admin_moderator and participant is speaker', async () => { await updateRecordingAccessPreferencesInRoom(roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR); const recordingCookie = await generateRecordingTokenCookie( roomData.room.roomId, @@ -208,7 +208,7 @@ describe('Recording API Security Tests', () => { expect(response.status).toBe(403); }); - it('should succeed when recording access is admin-moderator and participant is moderator', async () => { + it('should succeed when recording access is admin_moderator and participant is moderator', async () => { await updateRecordingAccessPreferencesInRoom(roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR); const recordingCookie = await generateRecordingTokenCookie( roomData.room.roomId, @@ -233,7 +233,7 @@ describe('Recording API Security Tests', () => { expect(response.status).toBe(200); }); - it('should succeed when recording access is admin-moderator-speaker and participant is speaker', async () => { + it('should succeed when recording access is admin_moderator_speaker and participant is speaker', async () => { await updateRecordingAccessPreferencesInRoom( roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR_SPEAKER @@ -249,7 +249,7 @@ describe('Recording API Security Tests', () => { expect(response.status).toBe(200); }); - it('should succeed when recording access is admin-moderator-speaker and participant is moderator', async () => { + it('should succeed when recording access is admin_moderator_speaker and participant is moderator', async () => { await updateRecordingAccessPreferencesInRoom( roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR_SPEAKER @@ -265,7 +265,7 @@ describe('Recording API Security Tests', () => { expect(response.status).toBe(200); }); - it('should fail when recording access is admin-moderator and participant is speaker', async () => { + it('should fail when recording access is admin_moderator and participant is speaker', async () => { await updateRecordingAccessPreferencesInRoom(roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR); const recordingCookie = await generateRecordingTokenCookie( roomData.room.roomId, @@ -278,7 +278,7 @@ describe('Recording API Security Tests', () => { expect(response.status).toBe(403); }); - it('should succeed when recording access is admin-moderator and participant is moderator', async () => { + it('should succeed when recording access is admin_moderator and participant is moderator', async () => { await updateRecordingAccessPreferencesInRoom(roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR); const recordingCookie = await generateRecordingTokenCookie( roomData.room.roomId, @@ -362,7 +362,7 @@ describe('Recording API Security Tests', () => { expect(response.status).toBe(404); }); - it('should fail when recording access is admin-moderator-speaker and participant is speaker', async () => { + it('should fail when recording access is admin_moderator_speaker and participant is speaker', async () => { await updateRecordingAccessPreferencesInRoom( roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR_SPEAKER @@ -378,7 +378,7 @@ describe('Recording API Security Tests', () => { expect(response.status).toBe(403); }); - it('should succeed when recording access is admin-moderator-speaker and participant is moderator', async () => { + it('should succeed when recording access is admin_moderator_speaker and participant is moderator', async () => { await updateRecordingAccessPreferencesInRoom( roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR_SPEAKER @@ -394,7 +394,7 @@ describe('Recording API Security Tests', () => { expect(response.status).toBe(404); }); - it('should fail when recording access is admin-moderator and participant is speaker', async () => { + it('should fail when recording access is admin_moderator and participant is speaker', async () => { await updateRecordingAccessPreferencesInRoom(roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR); const recordingCookie = await generateRecordingTokenCookie( roomData.room.roomId, @@ -407,7 +407,7 @@ describe('Recording API Security Tests', () => { expect(response.status).toBe(403); }); - it('should succeed when recording access is admin-moderator and participant is moderator', async () => { + it('should succeed when recording access is admin_moderator and participant is moderator', async () => { await updateRecordingAccessPreferencesInRoom(roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR); const recordingCookie = await generateRecordingTokenCookie( roomData.room.roomId, @@ -449,7 +449,7 @@ describe('Recording API Security Tests', () => { expect(response.status).toBe(400); }); - it('should fail when recording access is admin-moderator-speaker and participant is speaker', async () => { + it('should fail when recording access is admin_moderator_speaker and participant is speaker', async () => { await updateRecordingAccessPreferencesInRoom( roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR_SPEAKER @@ -466,7 +466,7 @@ describe('Recording API Security Tests', () => { expect(response.status).toBe(403); }); - it('should succeed when recording access is admin-moderator-speaker and participant is moderator', async () => { + it('should succeed when recording access is admin_moderator_speaker and participant is moderator', async () => { await updateRecordingAccessPreferencesInRoom( roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR_SPEAKER @@ -483,7 +483,7 @@ describe('Recording API Security Tests', () => { expect(response.status).toBe(400); }); - it('should fail when recording access is admin-moderator and participant is speaker', async () => { + it('should fail when recording access is admin_moderator and participant is speaker', async () => { await updateRecordingAccessPreferencesInRoom(roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR); const recordingCookie = await generateRecordingTokenCookie( roomData.room.roomId, @@ -497,7 +497,7 @@ describe('Recording API Security Tests', () => { expect(response.status).toBe(403); }); - it('should succeed when recording access is admin-moderator and participant is moderator', async () => { + it('should succeed when recording access is admin_moderator and participant is moderator', async () => { await updateRecordingAccessPreferencesInRoom(roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR); const recordingCookie = await generateRecordingTokenCookie( roomData.room.roomId, @@ -527,7 +527,7 @@ describe('Recording API Security Tests', () => { expect(response.status).toBe(200); }); - it('should succeed when recording access is admin-moderator-speaker and participant is speaker', async () => { + it('should succeed when recording access is admin_moderator_speaker and participant is speaker', async () => { await updateRecordingAccessPreferencesInRoom( roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR_SPEAKER @@ -543,7 +543,7 @@ describe('Recording API Security Tests', () => { expect(response.status).toBe(200); }); - it('should succeed when recording access is admin-moderator-speaker and participant is moderator', async () => { + it('should succeed when recording access is admin_moderator_speaker and participant is moderator', async () => { await updateRecordingAccessPreferencesInRoom( roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR_SPEAKER @@ -559,7 +559,7 @@ describe('Recording API Security Tests', () => { expect(response.status).toBe(200); }); - it('should fail when recording access is admin-moderator and participant is speaker', async () => { + it('should fail when recording access is admin_moderator and participant is speaker', async () => { await updateRecordingAccessPreferencesInRoom(roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR); const recordingCookie = await generateRecordingTokenCookie( roomData.room.roomId, @@ -572,7 +572,7 @@ describe('Recording API Security Tests', () => { expect(response.status).toBe(403); }); - it('should succeed when recording access is admin-moderator and participant is moderator', async () => { + it('should succeed when recording access is admin_moderator and participant is moderator', async () => { await updateRecordingAccessPreferencesInRoom(roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR); const recordingCookie = await generateRecordingTokenCookie( roomData.room.roomId, @@ -651,7 +651,7 @@ describe('Recording API Security Tests', () => { expect(response.status).toBe(200); }); - it('should succeed when recording access is admin-moderator-speaker and participant is speaker', async () => { + it('should succeed when recording access is admin_moderator_speaker and participant is speaker', async () => { await updateRecordingAccessPreferencesInRoom( roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR_SPEAKER @@ -667,7 +667,7 @@ describe('Recording API Security Tests', () => { expect(response.status).toBe(200); }); - it('should succeed when recording access is admin-moderator-speaker and participant is moderator', async () => { + it('should succeed when recording access is admin_moderator_speaker and participant is moderator', async () => { await updateRecordingAccessPreferencesInRoom( roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR_SPEAKER @@ -683,7 +683,7 @@ describe('Recording API Security Tests', () => { expect(response.status).toBe(200); }); - it('should fail when recording access is admin-moderator and participant is speaker', async () => { + it('should fail when recording access is admin_moderator and participant is speaker', async () => { await updateRecordingAccessPreferencesInRoom(roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR); const recordingCookie = await generateRecordingTokenCookie( roomData.room.roomId, @@ -696,7 +696,7 @@ describe('Recording API Security Tests', () => { expect(response.status).toBe(403); }); - it('should succeed when recording access is admin-moderator and participant is moderator', async () => { + it('should succeed when recording access is admin_moderator and participant is moderator', async () => { await updateRecordingAccessPreferencesInRoom(roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR); const recordingCookie = await generateRecordingTokenCookie( roomData.room.roomId, @@ -727,7 +727,7 @@ describe('Recording API Security Tests', () => { expect(response.status).toBe(200); }); - it('should succeed when recording access is admin-moderator-speaker and participant is speaker', async () => { + it('should succeed when recording access is admin_moderator_speaker and participant is speaker', async () => { await updateRecordingAccessPreferencesInRoom( roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR_SPEAKER @@ -744,7 +744,7 @@ describe('Recording API Security Tests', () => { expect(response.status).toBe(200); }); - it('should succeed when recording access is admin-moderator-speaker and participant is moderator', async () => { + it('should succeed when recording access is admin_moderator_speaker and participant is moderator', async () => { await updateRecordingAccessPreferencesInRoom( roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR_SPEAKER @@ -761,7 +761,7 @@ describe('Recording API Security Tests', () => { expect(response.status).toBe(200); }); - it('should fail when recording access is admin-moderator and participant is speaker', async () => { + it('should fail when recording access is admin_moderator and participant is speaker', async () => { await updateRecordingAccessPreferencesInRoom(roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR); const recordingCookie = await generateRecordingTokenCookie( roomData.room.roomId, @@ -775,7 +775,7 @@ describe('Recording API Security Tests', () => { expect(response.status).toBe(403); }); - it('should succeed when recording access is admin-moderator and participant is moderator', async () => { + it('should succeed when recording access is admin_moderator and participant is moderator', async () => { await updateRecordingAccessPreferencesInRoom(roomData.room.roomId, MeetRecordingAccess.ADMIN_MODERATOR); const recordingCookie = await generateRecordingTokenCookie( roomData.room.roomId, diff --git a/frontend/projects/shared-meet-components/src/lib/pages/view-recording/view-recording.component.html b/frontend/projects/shared-meet-components/src/lib/pages/view-recording/view-recording.component.html index a04d24a..eabb91c 100644 --- a/frontend/projects/shared-meet-components/src/lib/pages/view-recording/view-recording.component.html +++ b/frontend/projects/shared-meet-components/src/lib/pages/view-recording/view-recording.component.html @@ -125,7 +125,7 @@
{{ getStatusIcon() }}

{{ getStatusMessage() }}

- @if (['STARTING', 'ACTIVE', 'ENDING'].includes(recording.status)) { + @if (['starting', 'active', 'ending'].includes(recording.status)) {

The recording is still being processed. Please check back in a few minutes.