neoris/openvidu
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

backend: Refactor recording timeout handling to properly register and unregister event listeners

Browse Source
This commit is contained in:
Carlos Santos 2025-04-21 17:32:31 +02:00
parent 28fb0a594e
commit 74d1b542b6
1 changed files with 13 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
backend/src/services/recording.service.ts
View File

@ -85,25 +85,28 @@ export class RecordingService {
const { recordingId } = recordingInfo; const { recordingId } = recordingInfo;
const recordingPromise = new Promise<MeetRecordingInfo>((resolve, reject) => { const recordingPromise = new Promise<MeetRecordingInfo>((resolve, reject) => {
this.taskSchedulerService.registerTask({ const eventListener = (info: Record<string, unknown>) => {
name: `${roomId}_recording_timeout`,
type: 'timeout',
scheduleOrDelay: INTERNAL_CONFIG.RECORDING_STARTED_TIMEOUT,
callback: this.handleRecordingLockTimeout.bind(this, recordingId, roomId, reject)
});
this.systemEventService.once(SystemEventType.RECORDING_ACTIVE, (info: Record<string, unknown>) => {
// This listener is triggered only for the instance that started the recording. // This listener is triggered only for the instance that started the recording.
// Check if the recording ID matches the one that was started // Check if the recording ID matches the one that was started
const isEventForCurrentRecording = info?.recordingId === recordingId && info?.roomId === roomId; const isEventForCurrentRecording = info?.recordingId === recordingId && info?.roomId === roomId;
if (isEventForCurrentRecording) { if (isEventForCurrentRecording) {
this.taskSchedulerService.cancelTask(`${roomId}_recording_timeout`); this.taskSchedulerService.cancelTask(`${roomId}_recording_timeout`);
this.systemEventService.off(SystemEventType.RECORDING_ACTIVE, eventListener);
resolve(info as unknown as MeetRecordingInfo); resolve(info as unknown as MeetRecordingInfo);
} else { } else {
this.logger.error('Received recording active event with mismatched recording ID:', info); this.logger.error('Received recording active event with mismatched recording ID:', info);
} }
};
this.taskSchedulerService.registerTask({
name: `${roomId}_recording_timeout`,
type: 'timeout',
scheduleOrDelay: INTERNAL_CONFIG.RECORDING_STARTED_TIMEOUT,
callback: this.handleRecordingLockTimeout.bind(this, recordingId, roomId, eventListener, reject)
}); });
this.systemEventService.on(SystemEventType.RECORDING_ACTIVE, eventListener);
}); });
return await recordingPromise; return await recordingPromise;
@ -128,8 +131,6 @@ export class RecordingService {
// Cancel the recording cleanup timer if it is running // Cancel the recording cleanup timer if it is running
this.taskSchedulerService.cancelTask(`${roomId}_recording_timeout`); this.taskSchedulerService.cancelTask(`${roomId}_recording_timeout`);
// Remove the listener for the EGRESS_STARTED event.
this.systemEventService.off(SystemEventType.RECORDING_ACTIVE);
switch (egress.status) { switch (egress.status) {
case EgressStatus.EGRESS_ACTIVE: case EgressStatus.EGRESS_ACTIVE:
@ -491,8 +492,10 @@ export class RecordingService {
protected async handleRecordingLockTimeout( protected async handleRecordingLockTimeout(
recordingId: string, recordingId: string,
roomId: string, roomId: string,
listener: (info: Record<string, unknown>) => void,
rejectRequest: (reason?: unknown) => void rejectRequest: (reason?: unknown) => void
) { ) {
this.systemEventService.off(SystemEventType.RECORDING_ACTIVE, listener);
this.logger.debug(`Recording cleanup timer triggered for room '${roomId}'.`); this.logger.debug(`Recording cleanup timer triggered for room '${roomId}'.`);
let shouldReleaseLock = false; let shouldReleaseLock = false;