From 7b443ca8d3c3dc62638abf1c99440f60e8087272 Mon Sep 17 00:00:00 2001 From: Carlos Santos <4a.santos@gmail.com> Date: Thu, 10 Apr 2025 12:30:33 +0200 Subject: [PATCH] backend: Remove deleteObject method from S3Service and update S3StorageProvider to use deleteObjects --- backend/src/services/s3.service.ts | 23 ------------------- .../storage/providers/s3-storage.provider.ts | 2 +- 2 files changed, 1 insertion(+), 24 deletions(-) diff --git a/backend/src/services/s3.service.ts b/backend/src/services/s3.service.ts index 1387394..c926dd5 100644 --- a/backend/src/services/s3.service.ts +++ b/backend/src/services/s3.service.ts @@ -92,29 +92,6 @@ export class S3Service { } } - /** - * Deletes an object from an S3 bucket. - * - * @param name - The name of the object to delete. - * @param bucket - The name of the S3 bucket (optional, defaults to the `${MEET_S3_BUCKET}/${MEET_S3_SUBBUCKET}` - * @returns A promise that resolves to the result of the delete operation. - * @throws Throws an error if there was an error deleting the object. - */ - async deleteObject(name: string, bucket: string = MEET_S3_BUCKET): Promise { - const fullKey = this.getFullKey(name); - - try { - this.logger.verbose(`S3 deleteObject: attempting to delete object ${fullKey} in bucket ${bucket}`); - const command = new DeleteObjectCommand({ Bucket: bucket, Key: name }); - const result = await this.run(command); - this.logger.info(`S3 deleteObject: successfully deleted object ${fullKey} in bucket ${bucket}`); - return result; - } catch (error) { - this.logger.error(`S3 deleteObject: error deleting object ${fullKey} in bucket ${bucket}: ${error}`); - throw internalError(error); - } - } - /** * Bulk deletes objects from S3. * @param keys Array of object keys to delete. Estos keys deben incluir el subbucket (se obtiene con getFullKey). diff --git a/backend/src/services/storage/providers/s3-storage.provider.ts b/backend/src/services/storage/providers/s3-storage.provider.ts index 54b8927..0373a98 100644 --- a/backend/src/services/storage/providers/s3-storage.provider.ts +++ b/backend/src/services/storage/providers/s3-storage.provider.ts @@ -337,7 +337,7 @@ export class S3StorageProvider { if (s3Result.status === 'fulfilled') { try { - await this.s3Service.deleteObject(s3Path); + await this.s3Service.deleteObjects([s3Path]); } catch (rollbackError) { this.logger.error(`Error rolling back S3 save for room ${roomId}: ${rollbackError}`); }