neoris/openvidu
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

backend: Include room existence check in endMeeting function

Browse Source
This commit is contained in:
juancarmore 2025-04-14 12:47:08 +02:00
parent e3ee41c827
commit 7bcb3be1dd
3 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
backend/openapi/paths/internal/meetings.yaml
View File

@ -19,8 +19,8 @@
$ref: '../../components/responses/unauthorized-error.yaml' $ref: '../../components/responses/unauthorized-error.yaml'
'403': '403':
$ref: '../../components/responses/forbidden-error.yaml' $ref: '../../components/responses/forbidden-error.yaml'
# '404': '404':
# $ref: '../../components/responses/error-room-not-found.yaml' $ref: '../../components/responses/error-room-not-found.yaml'
'500': '500':
$ref: '../../components/responses/internal-server-error.yaml' $ref: '../../components/responses/internal-server-error.yaml'
/meetings/{roomId}/participants/{participantName}: /meetings/{roomId}/participants/{participantName}:

13
backend/src/controllers/meeting.controller.ts
View File

@ -1,14 +1,23 @@
import { container } from '../config/dependency-injector.config.js'; import { container } from '../config/dependency-injector.config.js';
import { Request, Response } from 'express'; import { Request, Response } from 'express';
import { LoggerService } from '../services/logger.service.js';
import { OpenViduMeetError } from '../models/index.js'; import { OpenViduMeetError } from '../models/index.js';
import { LiveKitService } from '../services/livekit.service.js'; import { LoggerService, RoomService, LiveKitService } from '../services/index.js';
export const endMeeting = async (req: Request, res: Response) => { export const endMeeting = async (req: Request, res: Response) => {
const logger = container.get(LoggerService); const logger = container.get(LoggerService);
const roomService = container.get(RoomService);
const livekitService = container.get(LiveKitService); const livekitService = container.get(LiveKitService);
const { roomId } = req.params; const { roomId } = req.params;
// Check if the room exists
try {
await roomService.getMeetRoom(roomId);
} catch (error) {
logger.error(`Error getting room '${roomId}'`);
return handleError(res, error);
}
try { try {
// To end a meeting, we need to delete the room from LiveKit // To end a meeting, we need to delete the room from LiveKit
await livekitService.deleteRoom(roomId); await livekitService.deleteRoom(roomId);

3
backend/src/controllers/room.controller.ts
View File

@ -123,8 +123,7 @@ export const getRoomRolesAndPermissions = async (req: Request, res: Response) =>
await roomService.getMeetRoom(roomId); await roomService.getMeetRoom(roomId);
} catch (error) { } catch (error) {
logger.error(`Error getting room '${roomId}'`); logger.error(`Error getting room '${roomId}'`);
handleError(res, error); return handleError(res, error);
return;
} }
logger.verbose(`Getting roles and associated permissions for room '${roomId}'`); logger.verbose(`Getting roles and associated permissions for room '${roomId}'`);