neoris/openvidu
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

backend: Add recording lock TTL configuration and refactor lock acquisition method

Browse Source
This commit is contained in:
Carlos Santos 2025-03-25 10:35:43 +01:00
parent 03adcf6a91
commit 7d8417be53
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
backend/src/environment.ts
View File

@ -70,6 +70,8 @@ export const ACCESS_TOKEN_COOKIE_NAME = 'OvMeetAccessToken';
export const REFRESH_TOKEN_COOKIE_NAME = 'OvMeetRefreshToken';
export const MEET_S3_ROOMS_PREFIX = 'rooms';
export const MEET_S3_RECORDINGS_PREFIX = 'recordings';
// Time to live for the active recording lock in Redis
export const MEET_RECORDING_LOCK_TTL = '6h';
export function checkModuleEnabled() {
if (MODULES_FILE) {

11
backend/src/services/recording.service.ts
View File

@ -16,7 +16,7 @@ import { S3Service } from './s3.service.js';
import { LoggerService } from './logger.service.js';
import { MeetRecordingFilters, MeetRecordingInfo, MeetRecordingStatus } from '@typings-ce';
import { RecordingHelper } from '../helpers/recording.helper.js';
import { MEET_S3_BUCKET, MEET_S3_RECORDINGS_PREFIX, MEET_S3_SUBBUCKET } from '../environment.js';
import { MEET_RECORDING_LOCK_TTL, MEET_S3_BUCKET, MEET_S3_RECORDINGS_PREFIX, MEET_S3_SUBBUCKET } from '../environment.js';
import { RoomService } from './room.service.js';
import { inject, injectable } from '../config/dependency-injector.config.js';
import { MutexService, RedisLock } from './mutex.service.js';
@ -272,14 +272,13 @@ export class RecordingService {
*
* The active recording lock will be released when the recording ends (handleEgressEnded) or when the room is finished (handleMeetingFinished).
*
* @param roomName - The name of the room to acquire the lock for.
* @param roomId - The name of the room to acquire the lock for.
*/
async acquireRoomRecordingActiveLock(roomName: string): Promise<RedisLock | null> {
const lockName = `${roomName}_${RedisLockName.RECORDING_ACTIVE}`;
const LOCK_TTL = ms('6h');
async acquireRoomRecordingActiveLock(roomId: string): Promise<RedisLock | null> {
const lockName = `${roomId}_${RedisLockName.RECORDING_ACTIVE}`;
try {
const lock = await this.mutexService.acquire(lockName, LOCK_TTL);
const lock = await this.mutexService.acquire(lockName, ms(MEET_RECORDING_LOCK_TTL));
return lock;
} catch (error) {
this.logger.warn(`Error acquiring lock ${lockName} on egress started: ${error}`);