From 9e3644ab0697513b6bdcf9b9a6681de8727b2186 Mon Sep 17 00:00:00 2001
From: Carlos Santos <4a.santos@gmail.com>
Date: Thu, 3 Apr 2025 17:20:03 +0200
Subject: [PATCH] backend: Reorder middleware for recording routes to improve
 validation flow

---
 backend/src/routes/recording.routes.ts | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/backend/src/routes/recording.routes.ts b/backend/src/routes/recording.routes.ts
index 6319151..fb6d653 100644
--- a/backend/src/routes/recording.routes.ts
+++ b/backend/src/routes/recording.routes.ts
@@ -22,42 +22,42 @@ recordingRouter.use(bodyParser.json());
 // Recording Routes
 recordingRouter.post(
 	'/',
-	withValidStartRecordingRequest,
 	withRecordingEnabled,
 	withAuth(participantTokenValidator),
 	withCorrectPermissions,
+	withValidStartRecordingRequest,
 	recordingCtrl.startRecording
 );
 recordingRouter.put(
 	'/:recordingId',
-	withValidRecordingId,
 	withRecordingEnabled,
 	withAuth(participantTokenValidator),
 	withCorrectPermissions,
+	withValidRecordingId,
 	recordingCtrl.stopRecording
 );
 recordingRouter.delete(
 	'/:recordingId',
-	withValidRecordingId,
 	withAuth(apiKeyValidator, tokenAndRoleValidator(UserRole.ADMIN)),
+	withValidRecordingId,
 	recordingCtrl.deleteRecording
 );
 recordingRouter.get(
 	'/:recordingId',
-	withValidRecordingId,
 	withAuth(apiKeyValidator, tokenAndRoleValidator(UserRole.ADMIN)),
+	withValidRecordingId,
 	recordingCtrl.getRecording
 );
 recordingRouter.get(
 	'/',
-	withValidGetRecordingsRequest,
 	withAuth(apiKeyValidator, tokenAndRoleValidator(UserRole.ADMIN)),
+	withValidGetRecordingsRequest,
 	recordingCtrl.getRecordings
 );
 recordingRouter.delete(
 	'/',
-	withValidRecordingBulkDeleteRequest,
 	withAuth(apiKeyValidator, tokenAndRoleValidator(UserRole.ADMIN)),
+	withValidRecordingBulkDeleteRequest,
 	recordingCtrl.bulkDeleteRecordings
 );
 
@@ -68,7 +68,7 @@ internalRecordingRouter.use(bodyParser.json());
 
 internalRecordingRouter.get(
 	'/:recordingId/stream',
-	withValidRecordingId,
 	withAuth(tokenAndRoleValidator(UserRole.ADMIN)),
+	withValidRecordingId,
 	recordingCtrl.streamRecording
 );