backend: Add update room integration tests

backend/src/routes/room.routes.ts

@@ -58,6 +58,7 @@ internalRoomRouter.use(bodyParser.json());
 internalRoomRouter.put(
 	'/:roomId',
 	withAuth(tokenAndRoleValidator(UserRole.ADMIN)),
+	withValidRoomId,
 	withValidRoomPreferences,
 	roomCtrl.updateRoomPreferences
 );

backend/tests/integration/api/rooms/update-room.test.ts

@@ -0,0 +1,169 @@
+import { describe, it, expect, beforeAll, afterAll, afterEach } from '@jest/globals';
+import {
+	createRoom,
+	deleteAllRooms,
+	startTestServer,
+	stopTestServer,
+	getRoom,
+	updateRoomPreferences
+} from '../../../utils/helpers.js';
+
+describe('OpenVidu Meet Room API Tests', () => {
+	beforeAll(async () => {
+		await startTestServer();
+	});
+
+	afterAll(async () => {
+		await stopTestServer();
+	});
+
+	afterEach(async () => {
+		// Remove all rooms created
+		await deleteAllRooms();
+	});
+
+	describe('Update Room Tests', () => {
+		it('should successfully update room preferences', async () => {
+			const createdRoom = await createRoom({
+				roomIdPrefix: 'update-test',
+				preferences: {
+					recordingPreferences: { enabled: true },
+					chatPreferences: { enabled: true },
+					virtualBackgroundPreferences: { enabled: true }
+				}
+			});
+
+			// Update the room preferences
+			const updatedPreferences = {
+				recordingPreferences: { enabled: false },
+				chatPreferences: { enabled: false },
+				virtualBackgroundPreferences: { enabled: false }
+			};
+
+			const updateResponse = await updateRoomPreferences(createdRoom.roomId, updatedPreferences);
+
+			// Verify update response
+			expect(updateResponse.status).toBe(200);
+			expect(updateResponse.body).toBeDefined();
+			expect(updateResponse.body.preferences).toEqual(updatedPreferences);
+
+			// Verify with a get request
+			const getResponse = await getRoom(createdRoom.roomId);
+			expect(getResponse.status).toBe(200);
+			expect(getResponse.body.preferences).toEqual(updatedPreferences);
+		});
+
+		it('should allow partial preference updates', async () => {
+			// Create a room first with all preferences enabled
+			const createdRoom = await createRoom({
+				roomIdPrefix: 'partial-update',
+				preferences: {
+					recordingPreferences: { enabled: true },
+					chatPreferences: { enabled: true },
+					virtualBackgroundPreferences: { enabled: true }
+				}
+			});
+
+			// Update only one preference
+			const partialPreferences = {
+				recordingPreferences: { enabled: false },
+				chatPreferences: { enabled: true },
+				virtualBackgroundPreferences: { enabled: true }
+			};
+
+			const updateResponse = await updateRoomPreferences(createdRoom.roomId, partialPreferences);
+
+			// Verify update response
+			expect(updateResponse.status).toBe(200);
+			expect(updateResponse.body.preferences).toEqual(partialPreferences);
+
+			// Verify with a get request
+			const getResponse = await getRoom(createdRoom.roomId);
+			expect(getResponse.status).toBe(200);
+			expect(getResponse.body.preferences).toEqual(partialPreferences);
+		});
+	});
+
+	describe('Update Room Validation failures', () => {
+		it('should fail when preferences have incorrect structure', async () => {
+			const { roomId } = await createRoom({
+				roomIdPrefix: 'validation-test'
+			});
+
+			// Invalid preferences (missing required fields)
+			const invalidPreferences = {
+				recordingPreferences: { enabled: false },
+				// Missing chatPreferences
+				virtualBackgroundPreferences: { enabled: false }
+			};
+
+			const response = await updateRoomPreferences(roomId, invalidPreferences);
+
+			expect(response.status).toBe(422);
+			expect(response.body.error).toContain('Unprocessable Entity');
+			expect(JSON.stringify(response.body.details)).toContain('chatPreferences');
+		});
+
+		it('should fail when preferences have incorrect types', async () => {
+			const createdRoom = await createRoom({
+				roomIdPrefix: 'type-test'
+			});
+
+			// Invalid preferences (wrong types)
+			const invalidPreferences = {
+				recordingPreferences: { enabled: 'true' }, // String instead of boolean
+				chatPreferences: { enabled: false },
+				virtualBackgroundPreferences: { enabled: false }
+			};
+
+			const response = await updateRoomPreferences(createdRoom.roomId, invalidPreferences);
+
+			expect(response.status).toBe(422);
+			expect(response.body.error).toContain('Unprocessable Entity');
+			expect(JSON.stringify(response.body.details)).toContain('recordingPreferences.enabled');
+		});
+
+		it('should fail when preferences are missing required properties', async () => {
+			const createdRoom = await createRoom({
+				roomIdPrefix: 'missing-props'
+			});
+
+			const emptyPreferences = {};
+
+			const response = await updateRoomPreferences(createdRoom.roomId, emptyPreferences);
+
+			expect(response.status).toBe(422);
+			expect(response.body.error).toContain('Unprocessable Entity');
+		});
+
+		it('should fail when room ID contains invalid characters', async () => {
+			const invalidRoomId = '!@#$%^&*()';
+
+			const preferences = {
+				recordingPreferences: { enabled: false },
+				chatPreferences: { enabled: false },
+				virtualBackgroundPreferences: { enabled: false }
+			};
+
+			const response = await updateRoomPreferences(invalidRoomId, preferences);
+
+			expect(response.status).toBe(422);
+			expect(JSON.stringify(response.body.details)).toContain('roomId cannot be empty after sanitization');
+		});
+
+		it('should return 404 when updating non-existent room', async () => {
+			const nonExistentRoomId = 'non-existent-room';
+
+			const preferences = {
+				recordingPreferences: { enabled: false },
+				chatPreferences: { enabled: false },
+				virtualBackgroundPreferences: { enabled: false }
+			};
+
+			const response = await updateRoomPreferences(nonExistentRoomId, preferences);
+
+			expect(response.status).toBe(404);
+			expect(response.body.message).toContain(`'${nonExistentRoomId}' does not exist`);
+		});
+	});
+});

backend/tests/utils/helpers.ts

@@ -167,6 +167,18 @@ export const getRooms = async (query: Record<string, any> = {}) => {
 		.query(query);
 };
 
+export const updateRoomPreferences = async (roomId: string, preferences: any) => {
+	if (!app) {
+		throw new Error('App instance is not defined');
+	}
+
+	const userCookie = await loginUserAsRole(UserRole.ADMIN);
+	return await request(app)
+		.put(`${INTERNAL_CONFIG.INTERNAL_API_BASE_PATH_V1}/rooms/${roomId}`)
+		.set('Cookie', userCookie)
+		.send(preferences);
+};
+
 /**
  * Asserts that a rooms response matches the expected values for testing purposes.
  * Validates the room array length and pagination properties.