From a5024fccf2610df18b3f1751eaed1cc8cc36811e Mon Sep 17 00:00:00 2001
From: Carlos Santos <4a.santos@gmail.com>
Date: Wed, 7 May 2025 11:36:15 +0200
Subject: [PATCH] tests: Enhance room deletion tests with custom
 MEETING_DEPARTURE_TIMEOUT and LiveKit room creation

---
 .../integration/api/rooms/delete-room.test.ts | 13 ++++++++++++
 .../api/rooms/garbage-collector.test.ts       | 21 ++++++++++++++-----
 2 files changed, 29 insertions(+), 5 deletions(-)

diff --git a/backend/tests/integration/api/rooms/delete-room.test.ts b/backend/tests/integration/api/rooms/delete-room.test.ts
index b0aa125..d8b0388 100644
--- a/backend/tests/integration/api/rooms/delete-room.test.ts
+++ b/backend/tests/integration/api/rooms/delete-room.test.ts
@@ -11,6 +11,9 @@ import {
 	sleep,
 	startTestServer
 } from '../../../helpers/request-helpers.js';
+import { RoomService } from '../../../../src/services/room.service.js';
+import { container } from '../../../../src/config/dependency-injector.config.js';
+import { setInternalConfig } from '../../../../src/config/internal-config.js';
 
 describe('Room API Tests', () => {
 	beforeAll(() => {
@@ -134,6 +137,16 @@ describe('Room API Tests', () => {
 				autoDeletionDate
 			});
 
+			const roomService = container.get(RoomService);
+			// Set MEETING_DEPARTURE_TIMEOUT to 1s to force the room to be closed immediately
+			setInternalConfig({
+				MEETING_DEPARTURE_TIMEOUT: '1s'
+			});
+			// Create livekit room with custom departure timeout
+			// This is needed to trigger the room_finished event
+			await roomService.createLivekitRoom(roomId);
+
+			// Join a participant to the room
 			await joinFakeParticipant(roomId, 'test-participant');
 
 			const response = await deleteRoom(roomId, { force: false });
diff --git a/backend/tests/integration/api/rooms/garbage-collector.test.ts b/backend/tests/integration/api/rooms/garbage-collector.test.ts
index c760aaa..3a70e31 100644
--- a/backend/tests/integration/api/rooms/garbage-collector.test.ts
+++ b/backend/tests/integration/api/rooms/garbage-collector.test.ts
@@ -12,6 +12,8 @@ import {
 	sleep,
 	startTestServer
 } from '../../../helpers/request-helpers.js';
+import { container } from '../../../../src/config/dependency-injector.config.js';
+import { RoomService } from '../../../../src/services/room.service.js';
 
 describe('Room Garbage Collector Tests', () => {
 	beforeAll(() => {
@@ -75,12 +77,21 @@ describe('Room Garbage Collector Tests', () => {
 	});
 
 	it('should delete a room after the last participant leaves when it was marked for deletion', async () => {
-		const createdRoom = await createRoom({
+		const { roomId } = await createRoom({
 			roomIdPrefix: 'test-gc-lifecycle',
 			autoDeletionDate: Date.now() + ms('1s')
 		});
 
-		await joinFakeParticipant(createdRoom.roomId, 'test-participant');
+		const roomService = container.get(RoomService);
+		// Set MEETING_DEPARTURE_TIMEOUT to 1s to force the room to be closed immediately
+		setInternalConfig({
+			MEETING_DEPARTURE_TIMEOUT: '1s'
+		});
+		// Create livekit room with custom departure timeout
+		// This is needed to trigger the room_finished event
+		await roomService.createLivekitRoom(roomId);
+
+		await joinFakeParticipant(roomId, 'test-participant');
 
 		// Wait for the auto-deletion date to pass
 		await sleep('1s');
@@ -88,7 +99,7 @@ describe('Room Garbage Collector Tests', () => {
 		// Should mark the room for deletion but not delete it yet
 		await runRoomGarbageCollector();
 
-		let response = await getRoom(createdRoom.roomId);
+		let response = await getRoom(roomId);
 		expect(response.status).toBe(200);
 		expect(response.body.markedForDeletion).toBe(true);
 		expect(response.body.autoDeletionDate).toBeTruthy();
@@ -97,10 +108,10 @@ describe('Room Garbage Collector Tests', () => {
 		await disconnectFakeParticipants();
 
 		// Wait to receive webhook room_finished
-		await sleep('4s');
+		await sleep('1s');
 
 		// Verify that the room is deleted
-		response = await getRoom(createdRoom.roomId);
+		response = await getRoom(roomId);
 		expect(response.status).toBe(404);
 	});