From a6fc920c7df13ced68b79fcb0fe292f078fbfa56 Mon Sep 17 00:00:00 2001 From: Carlos Santos <4a.santos@gmail.com> Date: Mon, 24 Mar 2025 13:05:44 +0100 Subject: [PATCH] backend: Rename withValidRecordingIdRequest to withValidRecordingId for consistency --- .../recording-validator.middleware.ts | 2 +- backend/src/routes/recording.routes.ts | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/backend/src/middlewares/request-validators/recording-validator.middleware.ts b/backend/src/middlewares/request-validators/recording-validator.middleware.ts index 04e170c..0870d5a 100644 --- a/backend/src/middlewares/request-validators/recording-validator.middleware.ts +++ b/backend/src/middlewares/request-validators/recording-validator.middleware.ts @@ -68,7 +68,7 @@ export const withValidStartRecordingRequest = (req: Request, res: Response, next next(); }; -export const withValidRecordingIdRequest = (req: Request, res: Response, next: NextFunction) => { +export const withValidRecordingId = (req: Request, res: Response, next: NextFunction) => { const { success, error, data } = GetRecordingSchema.safeParse({ recordingId: req.params.recordingId }); if (!success) { diff --git a/backend/src/routes/recording.routes.ts b/backend/src/routes/recording.routes.ts index b1d2edd..207fa6f 100644 --- a/backend/src/routes/recording.routes.ts +++ b/backend/src/routes/recording.routes.ts @@ -9,7 +9,7 @@ import { withRecordingEnabledAndCorrectPermissions, withValidGetRecordingsRequest, withValidRecordingBulkDeleteRequest, - withValidRecordingIdRequest, + withValidRecordingId, withValidStartRecordingRequest } from '../middlewares/index.js'; @@ -28,7 +28,7 @@ recordingRouter.post( recordingRouter.put( '/:recordingId', withAuth(participantTokenValidator), - /* withRecordingEnabledAndCorrectPermissions,*/ withValidRecordingIdRequest, + /* withRecordingEnabledAndCorrectPermissions,*/ withValidRecordingId, recordingCtrl.stopRecording ); @@ -36,10 +36,10 @@ recordingRouter.delete( '/:recordingId', withAuth(tokenAndRoleValidator(Role.ADMIN), participantTokenValidator), /*withRecordingEnabledAndCorrectPermissions,*/ - withValidRecordingIdRequest, + withValidRecordingId, recordingCtrl.deleteRecording ); -recordingRouter.get('/:recordingId', withValidRecordingIdRequest, recordingCtrl.getRecording); +recordingRouter.get('/:recordingId', withValidRecordingId, recordingCtrl.getRecording); recordingRouter.get('/', withValidGetRecordingsRequest, recordingCtrl.getRecordings); recordingRouter.delete('/', withValidRecordingBulkDeleteRequest, recordingCtrl.bulkDeleteRecordings); @@ -51,6 +51,6 @@ internalRecordingRouter.use(bodyParser.json()); internalRecordingRouter.get( '/:recordingId/stream', withAuth(participantTokenValidator), - /*withRecordingEnabledAndCorrectPermissions,*/ withValidRecordingIdRequest, + /*withRecordingEnabledAndCorrectPermissions,*/ withValidRecordingId, recordingCtrl.streamRecording );