neoris/openvidu
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

webcomponent: update event handling methods to use WebComponentEvent type for better type safety

Browse Source
This commit is contained in:
Carlos Santos 2025-05-20 11:37:36 +02:00
parent 7a81873285
commit af3697f94c
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
frontend/webcomponent/src/components/CommandsManager.ts
View File

@ -48,7 +48,7 @@ export class CommandsManager {
* @param callback Function to be called when the event is triggered * @param callback Function to be called when the event is triggered
* @returns The component instance for chaining * @returns The component instance for chaining
*/ */
public on(element: HTMLElement, eventName: string, callback: (detail: any) => void): this { public on(element: HTMLElement, eventName: WebComponentEvent, callback: (detail: any) => void): this {
if (!(Object.values(WebComponentEvent) as string[]).includes(eventName)) { if (!(Object.values(WebComponentEvent) as string[]).includes(eventName)) {
console.warn(`Event "${eventName}" is not supported.`); console.warn(`Event "${eventName}" is not supported.`);
return this; return this;
@ -83,7 +83,7 @@ export class CommandsManager {
* @param callback Function to be called when the event is triggered * @param callback Function to be called when the event is triggered
* @returns The component instance for chaining * @returns The component instance for chaining
*/ */
public once(element: HTMLElement, eventName: string, callback: (detail: any) => void): this { public once(element: HTMLElement, eventName: WebComponentEvent, callback: (detail: any) => void): this {
if (!(Object.values(WebComponentEvent) as string[]).includes(eventName)) { if (!(Object.values(WebComponentEvent) as string[]).includes(eventName)) {
console.warn(`Event "${eventName}" is not supported.`); console.warn(`Event "${eventName}" is not supported.`);
return this; return this;
@ -108,7 +108,7 @@ export class CommandsManager {
* @param callback Optional callback to remove (if not provided, removes all handlers for this event) * @param callback Optional callback to remove (if not provided, removes all handlers for this event)
* @returns The component instance for chaining * @returns The component instance for chaining
*/ */
public off(element: HTMLElement, eventName: string, callback?: (detail: any) => void): this { public off(element: HTMLElement, eventName: WebComponentEvent, callback?: (detail: any) => void): this {
if (!callback) { if (!callback) {
// Remove all handlers for this event // Remove all handlers for this event
const handlers = this.eventHandlers.get(eventName); const handlers = this.eventHandlers.get(eventName);

6
frontend/webcomponent/src/components/OpenViduMeet.ts
View File

@ -174,7 +174,7 @@ export class OpenViduMeet extends HTMLElement {
* @param callback Function to be called when the event is triggered * @param callback Function to be called when the event is triggered
* @returns The component instance for chaining * @returns The component instance for chaining
*/ */
public on(eventName: string, callback: (detail: any) => void): this { public on(eventName: WebComponentEvent, callback: (detail: any) => void): this {
this.commandsManager.on(this, eventName, callback); this.commandsManager.on(this, eventName, callback);
return this; return this;
} }
@ -185,7 +185,7 @@ export class OpenViduMeet extends HTMLElement {
* @param callback Function to be called when the event is triggered * @param callback Function to be called when the event is triggered
* @returns The component instance for chaining * @returns The component instance for chaining
*/ */
public once(eventName: string, callback: (detail: any) => void): this { public once(eventName: WebComponentEvent, callback: (detail: any) => void): this {
this.commandsManager.once(this, eventName, callback); this.commandsManager.once(this, eventName, callback);
return this; return this;
} }
@ -196,7 +196,7 @@ export class OpenViduMeet extends HTMLElement {
* @param callback Optional callback to remove (if not provided, removes all handlers for this event) * @param callback Optional callback to remove (if not provided, removes all handlers for this event)
* @returns The component instance for chaining * @returns The component instance for chaining
*/ */
public off(eventName: string, callback?: (detail: any) => void): this { public off(eventName: WebComponentEvent, callback?: (detail: any) => void): this {
this.commandsManager.off(this, eventName, callback); this.commandsManager.off(this, eventName, callback);
return this; return this;
} }