From b57f2d2eec30cac92dcffdf67e7c085df2e048c0 Mon Sep 17 00:00:00 2001
From: juancarmore <juancar_more2@hotmail.com>
Date: Sat, 19 Jul 2025 00:22:23 +0200
Subject: [PATCH] frontend: refactor WebComponentManagerService to improve
 initialization and closing logic

---
 .../services/webcomponent-manager.service.ts  | 50 +++++++++++++------
 1 file changed, 35 insertions(+), 15 deletions(-)

diff --git a/frontend/projects/shared-meet-components/src/lib/services/webcomponent-manager.service.ts b/frontend/projects/shared-meet-components/src/lib/services/webcomponent-manager.service.ts
index ecaac2e..bd226d5 100644
--- a/frontend/projects/shared-meet-components/src/lib/services/webcomponent-manager.service.ts
+++ b/frontend/projects/shared-meet-components/src/lib/services/webcomponent-manager.service.ts
@@ -1,5 +1,5 @@
 import { Injectable } from '@angular/core';
-import { AppDataService, MeetingService, ParticipantTokenService, RoomService } from '@lib/services';
+import { MeetingService, ParticipantTokenService, RoomService } from '@lib/services';
 import {
 	WebComponentCommand,
 	WebComponentEvent,
@@ -17,14 +17,15 @@ import { LoggerService, OpenViduService } from 'openvidu-components-angular';
 	providedIn: 'root'
 })
 export class WebComponentManagerService {
+	protected isInitialized = false;
+
 	protected parentDomain: string = '';
-	protected isListenerStarted = false;
 	protected boundHandleMessage: (event: MessageEvent) => Promise<void>;
+
 	protected log;
 
 	constructor(
 		protected loggerService: LoggerService,
-		protected appDataService: AppDataService,
 		protected participantService: ParticipantTokenService,
 		protected openviduService: OpenViduService,
 		protected roomService: RoomService,
@@ -34,13 +35,14 @@ export class WebComponentManagerService {
 		this.boundHandleMessage = this.handleMessage.bind(this);
 	}
 
-	startCommandsListener(): void {
-		if (this.isListenerStarted) return;
+	initialize() {
+		if (this.isInitialized) return;
 
-		this.isListenerStarted = true;
-		// Listen for messages from the iframe
-		window.addEventListener('message', this.boundHandleMessage);
-		// Send ready message to parent
+		this.log.d('Initializing service...');
+		this.isInitialized = true;
+		this.startCommandsListener();
+
+		// Send READY event to parent
 		this.sendMessageToParent(
 			{
 				event: WebComponentEvent.READY,
@@ -48,18 +50,36 @@ export class WebComponentManagerService {
 			},
 			'*'
 		);
+	}
+
+	close() {
+		if (!this.isInitialized) return;
+
+		this.log.d('Closing service...');
+		this.stopCommandsListener();
+
+		// Send CLOSED event to parent
+		this.sendMessageToParent({
+			event: WebComponentEvent.CLOSED,
+			payload: {}
+		});
+		this.isInitialized = false;
+	}
+
+	protected startCommandsListener() {
+		// Listen for messages from the iframe
+		window.addEventListener('message', this.boundHandleMessage);
 		this.log.d('Started commands listener');
 	}
 
-	stopCommandsListener(): void {
-		if (!this.isListenerStarted) return;
-		this.isListenerStarted = false;
+	protected stopCommandsListener() {
 		window.removeEventListener('message', this.boundHandleMessage);
 		this.log.d('Stopped commands listener');
 	}
 
 	sendMessageToParent(event: WebComponentOutboundEventMessage, targetOrigin: string = this.parentDomain) {
-		if (!this.appDataService.isEmbeddedMode()) return;
+		if (!this.isInitialized) return;
+
 		this.log.d('Sending message to parent:', event);
 		window.parent.postMessage(event, targetOrigin);
 	}
@@ -85,9 +105,9 @@ export class WebComponentManagerService {
 			return;
 		}
 
-		// Check if the room is connected before processing command
+		// Check if participant is connected to room before processing command
 		if (!this.openviduService.isRoomConnected()) {
-			this.log.w('Received command but room is not connected');
+			this.log.w('Received command but participant is not connected to the room');
 			return;
 		}