From b97da07bea142c9acb29e6d1d02835bcefc7aac5 Mon Sep 17 00:00:00 2001
From: juancarmore <juancar_more2@hotmail.com>
Date: Wed, 24 Sep 2025 12:53:14 +0200
Subject: [PATCH] frontend: pass secret parameter to downloadRecording method
 and update usage in ViewRecordingComponent

---
 .../pages/view-recording/view-recording.component.ts   | 10 ++++++----
 .../src/lib/services/recording.service.ts              |  4 ++--
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/frontend/projects/shared-meet-components/src/lib/pages/view-recording/view-recording.component.ts b/frontend/projects/shared-meet-components/src/lib/pages/view-recording/view-recording.component.ts
index b88f061..829b1b5 100644
--- a/frontend/projects/shared-meet-components/src/lib/pages/view-recording/view-recording.component.ts
+++ b/frontend/projects/shared-meet-components/src/lib/pages/view-recording/view-recording.component.ts
@@ -30,6 +30,8 @@ import { ViewportService } from 'openvidu-components-angular';
 export class ViewRecordingComponent implements OnInit, OnDestroy {
 	recording?: MeetRecordingInfo;
 	recordingUrl?: string;
+	secret?: string;
+
 	videoError = false;
 	isLoading = true;
 	hasError = false;
@@ -53,7 +55,7 @@ export class ViewRecordingComponent implements OnInit, OnDestroy {
 
 	private async loadRecording() {
 		const recordingId = this.route.snapshot.params['recording-id'];
-		const secret = this.route.snapshot.queryParams['secret'];
+		this.secret = this.route.snapshot.queryParams['secret'];
 
 		if (!recordingId) {
 			this.hasError = true;
@@ -62,10 +64,10 @@ export class ViewRecordingComponent implements OnInit, OnDestroy {
 		}
 
 		try {
-			this.recording = await this.recordingService.getRecording(recordingId, secret);
+			this.recording = await this.recordingService.getRecording(recordingId, this.secret);
 
 			if (this.recording.status === MeetRecordingStatus.COMPLETE) {
-				this.recordingUrl = this.recordingService.getRecordingMediaUrl(recordingId, secret);
+				this.recordingUrl = this.recordingService.getRecordingMediaUrl(recordingId, this.secret);
 			}
 		} catch (error) {
 			console.error('Error fetching recording:', error);
@@ -97,7 +99,7 @@ export class ViewRecordingComponent implements OnInit, OnDestroy {
 			return;
 		}
 
-		this.recordingService.downloadRecording(this.recording);
+		this.recordingService.downloadRecording(this.recording, this.secret);
 	}
 
 	openShareDialog() {
diff --git a/frontend/projects/shared-meet-components/src/lib/services/recording.service.ts b/frontend/projects/shared-meet-components/src/lib/services/recording.service.ts
index 6357213..6b07257 100644
--- a/frontend/projects/shared-meet-components/src/lib/services/recording.service.ts
+++ b/frontend/projects/shared-meet-components/src/lib/services/recording.service.ts
@@ -245,8 +245,8 @@ export class RecordingService {
 	 *
 	 * @param recording - The recording information containing the ID and filename
 	 */
-	downloadRecording(recording: MeetRecordingInfo) {
-		const recordingUrl = this.getRecordingMediaUrl(recording.recordingId);
+	downloadRecording(recording: MeetRecordingInfo, secret?: string) {
+		const recordingUrl = this.getRecordingMediaUrl(recording.recordingId, secret);
 		const link = document.createElement('a');
 		link.href = recordingUrl;
 		link.download = recording.filename || `${recording.recordingId}.mp4`;