frontend: enhance rooms lists component with improved loading states, search functionality, and empty filter messaging

This commit is contained in:
juancarmore 2025-08-15 23:07:11 +02:00
parent 1ac05d6157
commit cea5421012
5 changed files with 440 additions and 305 deletions

View File

@ -1,19 +1,46 @@
<!-- Loading Spinner --> @if (!loading && rooms.length === 0 && !showEmptyFilterMessage) {
@if (loading) { <!-- Empty State -->
<div class="loading-container"> <div class="no-rooms-state">
<mat-spinner diameter="40"></mat-spinner> <div class="empty-content">
<span>Loading rooms...</span> <h3>No rooms created yet</h3>
<p>No rooms found. Create your first room to start hosting meetings and manage your video conferences.</p>
<div class="getting-started-actions">
<button mat-button (click)="createRoom()" class="create-room-btn primary-button">
<mat-icon>add</mat-icon>
Create Your First Room
</button>
</div> </div>
} @else if (rooms.length > 0) { </div>
</div>
} @else {
<!-- Rooms Toolbar --> <!-- Rooms Toolbar -->
<mat-toolbar class="rooms-toolbar" id="rooms-toolbar"> <mat-toolbar class="rooms-toolbar" id="rooms-toolbar">
<!-- Left Section: Search --> <!-- Left Section: Search -->
<div class="toolbar-left" id="toolbar-left"> <div class="toolbar-left" id="toolbar-left">
@if (showSearchBox) {
<mat-form-field class="search-field" appearance="outline" id="search-field"> <mat-form-field class="search-field" appearance="outline" id="search-field">
<mat-label>Search rooms</mat-label> <mat-label>Search rooms</mat-label>
<input matInput [formControl]="nameFilterControl" placeholder="Search by room name" id="search-input" /> <input
<mat-icon matSuffix>search</mat-icon> matInput
[formControl]="nameFilterControl"
placeholder="Search by room name"
id="search-input"
(keydown.enter)="triggerSearch()"
/>
<button
mat-icon-button
matSuffix
class="search-btn"
(click)="triggerSearch()"
[disabled]="loading || !nameFilterControl.value"
matTooltip="Search"
id="search-btn"
>
<mat-icon>search</mat-icon>
</button>
</mat-form-field> </mat-form-field>
}
</div> </div>
<!-- Center Section: Batch Actions (visible when items selected) --> <!-- Center Section: Batch Actions (visible when items selected) -->
@ -36,10 +63,23 @@
<!-- Right Section: Actions --> <!-- Right Section: Actions -->
<div class="toolbar-right" id="toolbar-right"> <div class="toolbar-right" id="toolbar-right">
@if (hasActiveFilters()) {
<button
mat-icon-button
class="clear-btn"
(click)="clearFilters()"
[disabled]="loading"
matTooltip="Clear all filters"
id="clear-filters-btn"
>
<mat-icon>filter_alt_off</mat-icon>
</button>
}
<button <button
mat-icon-button mat-icon-button
class="refresh-btn" class="refresh-btn"
(click)="refresh.emit()" (click)="refreshRooms()"
[disabled]="loading" [disabled]="loading"
matTooltip="Refresh rooms" matTooltip="Refresh rooms"
id="refresh-btn" id="refresh-btn"
@ -76,6 +116,28 @@
</div> </div>
</mat-toolbar> </mat-toolbar>
<!-- Loading Spinner -->
@if (loading) {
<div class="loading-container">
<mat-spinner diameter="40"></mat-spinner>
<span>Loading rooms...</span>
</div>
} @else if (rooms.length === 0 && showEmptyFilterMessage) {
<!-- No rooms match the current filters -->
<div class="no-recordings-state">
<div class="empty-content">
<h3>No rooms match your search criteria and/or filters</h3>
<p>Try adjusting or clearing your filters to see more rooms.</p>
<div class="getting-started-actions">
<button mat-button (click)="clearFilters()" class="clear-filters-btn primary-button">
<mat-icon>filter_alt_off</mat-icon>
Clear Filters
</button>
</div>
</div>
</div>
} @else {
<!-- Rooms Table -->
<div class="table-container" id="table-container"> <div class="table-container" id="table-container">
<table mat-table [dataSource]="rooms" class="rooms-table" id="rooms-table"> <table mat-table [dataSource]="rooms" class="rooms-table" id="rooms-table">
<!-- Selection Column --> <!-- Selection Column -->
@ -133,7 +195,9 @@
> >
{{ getStatusIcon(room) }} {{ getStatusIcon(room) }}
</mat-icon> </mat-icon>
<span class="status-label" id="status-label-{{ room.roomId }}">{{ getRoomStatus(room) }}</span> <span class="status-label" id="status-label-{{ room.roomId }}">{{
getRoomStatus(room)
}}</span>
</div> </div>
</td> </td>
</ng-container> </ng-container>
@ -317,25 +381,17 @@
<!-- Load More Section --> <!-- Load More Section -->
@if (showLoadMore) { @if (showLoadMore) {
<div class="load-more-container" id="load-more-container"> <div class="load-more-container" id="load-more-container">
<button mat-button class="load-more-btn" (click)="loadMore.emit()" [disabled]="loading" id="load-more-btn"> <button
mat-button
class="load-more-btn"
(click)="loadMoreRooms()"
[disabled]="loading"
id="load-more-btn"
>
<mat-icon>expand_more</mat-icon> <mat-icon>expand_more</mat-icon>
<span>Load More Rooms</span> <span>Load More Rooms</span>
</button> </button>
</div> </div>
} }
} @else { }
<!-- Empty State -->
<div class="no-rooms-state">
<div class="empty-content">
<h3>No rooms created yet</h3>
<p>No rooms found. Create your first room to start hosting meetings and manage your video conferences.</p>
<div class="getting-started-actions">
<button mat-button (click)="createRoom()" class="create-room-btn primary-button">
<mat-icon>add</mat-icon>
Create Your First Room
</button>
</div>
</div>
</div>
} }

View File

@ -4,12 +4,22 @@
.rooms-toolbar { .rooms-toolbar {
@extend .ov-data-toolbar; @extend .ov-data-toolbar;
.toolbar-left {
::ng-deep .search-btn {
padding: var(--ov-meet-spacing-sm);
}
}
.toolbar-right { .toolbar-right {
gap: var(--ov-meet-spacing-sm); gap: var(--ov-meet-spacing-sm);
::ng-deep .refresh-btn { ::ng-deep .refresh-btn {
padding: var(--ov-meet-spacing-sm); padding: var(--ov-meet-spacing-sm);
} }
::ng-deep .clear-btn {
padding: var(--ov-meet-spacing-sm);
}
} }
} }
@ -251,10 +261,15 @@
} }
.getting-started-actions { .getting-started-actions {
display: flex; @extend .action-buttons;
flex-direction: column;
gap: var(--ov-meet-spacing-md); .create-room-btn {
align-items: center; @extend .refresh-btn;
}
.clear-filters-btn {
@extend .refresh-btn;
}
} }
} }

View File

@ -92,10 +92,12 @@ export interface RoomTableAction {
export class RoomsListsComponent implements OnInit, OnChanges { export class RoomsListsComponent implements OnInit, OnChanges {
// Input properties // Input properties
@Input() rooms: MeetRoom[] = []; @Input() rooms: MeetRoom[] = [];
@Input() showSearchBox = true;
@Input() showFilters = false; @Input() showFilters = false;
@Input() showSelection = true; @Input() showSelection = true;
@Input() showLoadMore = false; @Input() showLoadMore = false;
@Input() loading = false; @Input() loading = false;
@Input() initialFilters: { nameFilter: string; statusFilter: string } = { nameFilter: '', statusFilter: '' };
// Host binding for styling when rooms are selected // Host binding for styling when rooms are selected
@HostBinding('class.has-selections') @HostBinding('class.has-selections')
@ -106,13 +108,15 @@ export class RoomsListsComponent implements OnInit, OnChanges {
// Output events // Output events
@Output() roomAction = new EventEmitter<RoomTableAction>(); @Output() roomAction = new EventEmitter<RoomTableAction>();
@Output() filterChange = new EventEmitter<{ nameFilter: string; statusFilter: string }>(); @Output() filterChange = new EventEmitter<{ nameFilter: string; statusFilter: string }>();
@Output() loadMore = new EventEmitter<void>(); @Output() loadMore = new EventEmitter<{ nameFilter: string; statusFilter: string }>();
@Output() refresh = new EventEmitter<void>(); @Output() refresh = new EventEmitter<{ nameFilter: string; statusFilter: string }>();
// Filter controls // Filter controls
nameFilterControl = new FormControl(''); nameFilterControl = new FormControl('');
statusFilterControl = new FormControl(''); statusFilterControl = new FormControl('');
showEmptyFilterMessage = false; // Show message when no rooms match filters
// Selection state // Selection state
selectedRooms = signal<Set<string>>(new Set()); selectedRooms = signal<Set<string>>(new Set());
allSelected = signal(false); allSelected = signal(false);
@ -137,30 +141,39 @@ export class RoomsListsComponent implements OnInit, OnChanges {
ngOnChanges(changes: SimpleChanges) { ngOnChanges(changes: SimpleChanges) {
if (changes['rooms']) { if (changes['rooms']) {
// Update selected rooms based on current rooms
const validIds = new Set(this.rooms.map((r) => r.roomId)); const validIds = new Set(this.rooms.map((r) => r.roomId));
const filteredSelection = new Set([...this.selectedRooms()].filter((id) => validIds.has(id))); const filteredSelection = new Set([...this.selectedRooms()].filter((id) => validIds.has(id)));
this.selectedRooms.set(filteredSelection); this.selectedRooms.set(filteredSelection);
this.updateSelectionState(); this.updateSelectionState();
// Show message when no rooms match filters
if (this.rooms.length === 0 && this.hasActiveFilters()) {
this.showEmptyFilterMessage = true;
} else {
this.showEmptyFilterMessage = false;
}
} }
} }
// ===== INITIALIZATION METHODS ===== // ===== INITIALIZATION METHODS =====
private setupFilters() { private setupFilters() {
// Set up name filter with debounce // Set up initial filter values
this.nameFilterControl.valueChanges.pipe(debounceTime(300), distinctUntilChanged()).subscribe((value) => { this.nameFilterControl.setValue(this.initialFilters.nameFilter);
this.filterChange.emit({ this.statusFilterControl.setValue(this.initialFilters.statusFilter);
nameFilter: value || '',
statusFilter: this.statusFilterControl.value || '' // Set up name filter change detection
}); this.nameFilterControl.valueChanges.subscribe((value) => {
// Emit filter change if value is empty
if (!value) {
this.emitFilterChange();
}
}); });
// Set up status filter // Set up status filter change detection
this.statusFilterControl.valueChanges.subscribe((value) => { this.statusFilterControl.valueChanges.subscribe(() => {
this.filterChange.emit({ this.emitFilterChange();
nameFilter: this.nameFilterControl.value || '',
statusFilter: value || ''
});
}); });
} }
@ -261,8 +274,31 @@ export class RoomsListsComponent implements OnInit, OnChanges {
} }
} }
loadMoreRooms() {
const nameFilter = this.nameFilterControl.value || '';
const statusFilter = this.statusFilterControl.value || '';
this.loadMore.emit({ nameFilter, statusFilter });
}
refreshRooms() {
const nameFilter = this.nameFilterControl.value || '';
const statusFilter = this.statusFilterControl.value || '';
this.refresh.emit({ nameFilter, statusFilter });
}
// ===== FILTER METHODS ===== // ===== FILTER METHODS =====
triggerSearch() {
this.emitFilterChange();
}
private emitFilterChange() {
this.filterChange.emit({
nameFilter: this.nameFilterControl.value || '',
statusFilter: this.statusFilterControl.value || ''
});
}
hasActiveFilters(): boolean { hasActiveFilters(): boolean {
return !!(this.nameFilterControl.value || this.statusFilterControl.value); return !!(this.nameFilterControl.value || this.statusFilterControl.value);
} }

View File

@ -1,11 +1,10 @@
@if (isLoading) { <!-- Loading State -->
@if (showLoadingSpinner) { @if (isInitializing && showInitialLoader) {
<!-- Enhanced Loading State with delay -->
<div class="ov-page-loading"> <div class="ov-page-loading">
<div class="loading-content"> <div class="loading-content">
<div class="loading-header"> <div class="loading-header">
<div class="loading-title"> <div class="loading-title">
<mat-icon class="ov-room-icon loading-icon"> video_chat </mat-icon> <mat-icon class="ov-room-icon loading-icon">video_chat</mat-icon>
<h1>Loading Rooms</h1> <h1>Loading Rooms</h1>
</div> </div>
<p class="loading-subtitle">Please wait while we fetch your rooms...</p> <p class="loading-subtitle">Please wait while we fetch your rooms...</p>
@ -16,12 +15,14 @@
</div> </div>
</div> </div>
</div> </div>
} }
} @else {
@if (!isInitializing) {
<div class="ov-page-container ov-mb-xxl" id="rooms-page-container"> <div class="ov-page-container ov-mb-xxl" id="rooms-page-container">
<!-- Rooms Header -->
<div class="page-header" id="rooms-page-header"> <div class="page-header" id="rooms-page-header">
<div class="title" id="rooms-title"> <div class="title" id="rooms-title">
<mat-icon class="ov-room-icon" id="rooms-icon"> video_chat </mat-icon> <mat-icon class="ov-room-icon" id="rooms-icon">video_chat</mat-icon>
<h1 id="rooms-heading">Rooms</h1> <h1 id="rooms-heading">Rooms</h1>
</div> </div>
<p class="subtitle" id="rooms-subtitle"> <p class="subtitle" id="rooms-subtitle">
@ -29,16 +30,21 @@
</p> </p>
</div> </div>
<!-- Content -->
<div class="page-content" id="rooms-content"> <div class="page-content" id="rooms-content">
<ov-rooms-lists <ov-rooms-lists
id="rooms-list" id="rooms-list"
[rooms]="rooms()" [rooms]="rooms()"
[loading]="isLoading" [loading]="isLoading"
[showSearchBox]="true"
[showFilters]="false"
[showSelection]="true" [showSelection]="true"
[showLoadMore]="hasMoreRooms" [showLoadMore]="hasMoreRooms"
[initialFilters]="initialFilters"
(roomAction)="onRoomAction($event)" (roomAction)="onRoomAction($event)"
(loadMore)="loadMoreRooms()" (loadMore)="loadMoreRooms($event)"
(refresh)="refreshRooms()" (refresh)="refreshRooms($event)"
(filterChange)="refreshRooms($event)"
></ov-rooms-lists> ></ov-rooms-lists>
</div> </div>
</div> </div>

View File

@ -49,8 +49,16 @@ export class RoomsComponent implements OnInit {
// searchTerm = ''; // searchTerm = '';
rooms = signal<MeetRoom[]>([]); rooms = signal<MeetRoom[]>([]);
// Loading state
isInitializing = true;
showInitialLoader = false;
isLoading = false; isLoading = false;
showLoadingSpinner = false;
initialFilters = {
nameFilter: '',
statusFilter: ''
};
// Pagination // Pagination
hasMoreRooms = false; hasMoreRooms = false;
@ -69,7 +77,15 @@ export class RoomsComponent implements OnInit {
} }
async ngOnInit() { async ngOnInit() {
const delayLoader = setTimeout(() => {
this.showInitialLoader = true;
}, 200);
await this.loadRooms(); await this.loadRooms();
clearTimeout(delayLoader);
this.showInitialLoader = false;
this.isInitializing = false;
} }
async onRoomAction(action: RoomTableAction) { async onRoomAction(action: RoomTableAction) {
@ -101,24 +117,34 @@ export class RoomsComponent implements OnInit {
} }
} }
private async loadRooms() { private async loadRooms(filters?: { nameFilter: string; statusFilter: string }, refresh = false) {
const delayLoader = setTimeout(() => {
this.isLoading = true; this.isLoading = true;
const delaySpinner = setTimeout(() => {
this.showLoadingSpinner = true;
}, 200); }, 200);
try { try {
const roomFilters: MeetRoomFilters = { const roomFilters: MeetRoomFilters = {
maxItems: 50, maxItems: 50,
nextPageToken: this.nextPageToken nextPageToken: !refresh ? this.nextPageToken : undefined
}; };
// Apply room ID filter if provided
// if (filters?.nameFilter) {
// roomFilters.roomName = filters.nameFilter;
// }
const response = await this.roomService.listRooms(roomFilters); const response = await this.roomService.listRooms(roomFilters);
// TODO: Filter rooms // TODO: Filter rooms by status
if (!refresh) {
// Update rooms list // Update rooms list
const currentRooms = this.rooms(); const currentRooms = this.rooms();
this.rooms.set([...currentRooms, ...response.rooms]); this.rooms.set([...currentRooms, ...response.rooms]);
} else {
// Replace rooms list
this.rooms.set(response.rooms);
}
// TODO: Sort rooms // TODO: Sort rooms
// this.dataSource.data = this.rooms(); // this.dataSource.data = this.rooms();
@ -131,9 +157,8 @@ export class RoomsComponent implements OnInit {
this.notificationService.showAlert('Error loading rooms'); this.notificationService.showAlert('Error loading rooms');
this.log.e('Error loading rooms:', error); this.log.e('Error loading rooms:', error);
} finally { } finally {
clearTimeout(delayLoader);
this.isLoading = false; this.isLoading = false;
clearTimeout(delaySpinner);
this.showLoadingSpinner = false;
} }
} }
@ -188,16 +213,13 @@ export class RoomsComponent implements OnInit {
// } // }
// } // }
async loadMoreRooms() { async loadMoreRooms(filters?: { nameFilter: string; statusFilter: string }) {
if (!this.hasMoreRooms || this.isLoading) return; if (!this.hasMoreRooms || this.isLoading) return;
await this.loadRooms(); await this.loadRooms(filters);
} }
async refreshRooms() { async refreshRooms(filters?: { nameFilter: string; statusFilter: string }) {
this.rooms.set([]); await this.loadRooms(filters, true);
this.nextPageToken = undefined;
this.hasMoreRooms = false;
await this.loadRooms();
} }
private async createRoom() { private async createRoom() {