From cf1c4c5438ee125aa818fcaecbacff6ee035e5dc Mon Sep 17 00:00:00 2001 From: Carlos Santos <4a.santos@gmail.com> Date: Thu, 13 Mar 2025 20:06:16 +0100 Subject: [PATCH] Remove numParticipants from OpenViduMeetRoom and simplify accessRoomUrl handling in HomeComponent --- backend/src/services/room.service.ts | 3 +-- frontend/src/app/pages/home/home.component.ts | 5 +---- typings/src/room.ts | 1 - 3 files changed, 2 insertions(+), 7 deletions(-) diff --git a/backend/src/services/room.service.ts b/backend/src/services/room.service.ts index f8d8190..472a818 100644 --- a/backend/src/services/room.service.ts +++ b/backend/src/services/room.service.ts @@ -214,14 +214,13 @@ export class RoomService { livekitRoom: Room, roomOptions: OpenViduMeetRoomOptions ): OpenViduMeetRoom { - const { name: roomName, creationTime, numParticipants } = livekitRoom; + const { name: roomName, creationTime } = livekitRoom; const { preferences, expirationDate, roomNamePrefix, maxParticipants } = roomOptions; const openviduRoom: OpenViduMeetRoom = { roomName, roomNamePrefix, creationDate: Number(creationTime) * 1000, - numParticipants, maxParticipants, expirationDate, moderatorRoomUrl: `${baseUrl}/room/${roomName}?secret=${secureUid(10)}`, diff --git a/frontend/src/app/pages/home/home.component.ts b/frontend/src/app/pages/home/home.component.ts index 2d1a536..b656353 100644 --- a/frontend/src/app/pages/home/home.component.ts +++ b/frontend/src/app/pages/home/home.component.ts @@ -149,10 +149,7 @@ export class HomeComponent implements OnInit, OnDestroy { this.roomForm.get('roomNamePrefix')?.setValue(roomNamePrefix); - const isFirstParticipant = room.numParticipants === 0; - const accessRoomUrl = new URL(isFirstParticipant ? room.moderatorRoomUrl : room.publisherRoomUrl); - - + const accessRoomUrl = new URL(room.moderatorRoomUrl); const secret = accessRoomUrl.searchParams.get('secret'); const roomName = accessRoomUrl.pathname; diff --git a/typings/src/room.ts b/typings/src/room.ts index 4de918d..bec3e51 100644 --- a/typings/src/room.ts +++ b/typings/src/room.ts @@ -17,7 +17,6 @@ export type OpenViduMeetRoomOptions = BaseRoomOptions; export interface OpenViduMeetRoom extends BaseRoomOptions { roomName: string; creationDate: number; - numParticipants: number; moderatorRoomUrl: string; publisherRoomUrl: string; }