neoris/openvidu
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

frontend: enhance current password validation in admin credentials form and improve error handling

Browse Source
This commit is contained in:
juancarmore 2025-08-22 23:51:21 +02:00
parent 6d43e94889
commit e958fb2340
1 changed files with 25 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
frontend/projects/shared-meet-components/src/lib/pages/console/users-permissions/users-permissions.component.ts
View File

@ -1,3 +1,4 @@
import { HttpErrorResponse } from '@angular/common/http';
import { Component, OnInit, signal } from '@angular/core'; import { Component, OnInit, signal } from '@angular/core';
import { import {
AbstractControl, AbstractControl,
@ -76,8 +77,17 @@ export class UsersPermissionsComponent implements OnInit {
this.checkForAccessSettingsChanges(); this.checkForAccessSettingsChanges();
}); });
// Revalidate new password when current password changes // Clear invalid password error when user starts typing
this.adminCredentialsForm.get('currentPassword')?.valueChanges.subscribe(() => { this.adminCredentialsForm.get('currentPassword')?.valueChanges.subscribe(() => {
const control = this.adminCredentialsForm.get('currentPassword');
if (control?.errors?.['invalidPassword']) {
// Remove only the invalidPassword error, keep others
const errors = { ...control.errors };
delete errors['invalidPassword'];
control.setErrors(Object.keys(errors).length > 0 ? errors : null);
}
// Revalidate new password when current password changes
const newPasswordControl = this.adminCredentialsForm.get('newPassword'); const newPasswordControl = this.adminCredentialsForm.get('newPassword');
if (newPasswordControl?.value) { if (newPasswordControl?.value) {
newPasswordControl.updateValueAndValidity(); newPasswordControl.updateValueAndValidity();
@ -188,7 +198,17 @@ export class UsersPermissionsComponent implements OnInit {
this.showConfirmPassword.set(false); this.showConfirmPassword.set(false);
} catch (error) { } catch (error) {
console.error('Error saving admin credentials:', error); console.error('Error saving admin credentials:', error);
this.notificationService.showSnackbar('Failed to save admin credentials');
if ((error as HttpErrorResponse).status === 400) {
// Set error on current password field
const currentPasswordControl = this.adminCredentialsForm.get('currentPassword');
currentPasswordControl?.setErrors({ invalidPassword: true });
currentPasswordControl?.markAsTouched();
this.notificationService.showSnackbar('Invalid current password');
} else {
this.notificationService.showSnackbar('Failed to save admin credentials');
}
} }
} }
@ -224,6 +244,9 @@ export class UsersPermissionsComponent implements OnInit {
if (control.errors['required']) { if (control.errors['required']) {
return 'Current password is required'; return 'Current password is required';
} }
if (control.errors['invalidPassword']) {
return 'Current password is incorrect';
}
} }
return null; return null;