test: refactor recording tests to improve clarity and consistency

This commit is contained in:
Carlos Santos 2025-05-28 13:45:56 +02:00
parent b6ace8d4ad
commit f58e0fd111
2 changed files with 13 additions and 7 deletions

View File

@ -18,6 +18,7 @@ describe('Recording API Tests', () => {
beforeAll(async () => { beforeAll(async () => {
startTestServer(); startTestServer();
await deleteAllRecordings();
// Create a room and join a participant // Create a room and join a participant
context = await setupMultiRecordingsTestContext(1, 1, 1); context = await setupMultiRecordingsTestContext(1, 1, 1);
({ room, moderatorCookie, recordingId = '' } = context.getRoomByIndex(0)!); ({ room, moderatorCookie, recordingId = '' } = context.getRoomByIndex(0)!);

View File

@ -10,7 +10,7 @@ import {
deleteAllRecordings, deleteAllRecordings,
deleteAllRooms, deleteAllRooms,
disconnectFakeParticipants, disconnectFakeParticipants,
generateRecordingToken, generateRecordingTokenCookie,
getAllRecordings, getAllRecordings,
getAllRecordingsFromRoom, getAllRecordingsFromRoom,
startTestServer startTestServer
@ -61,7 +61,7 @@ describe('Recordings API Tests', () => {
const roomId = roomData.room.roomId; const roomId = roomData.room.roomId;
// Generate a recording token for the room // Generate a recording token for the room
const recordingCookie = await generateRecordingToken(roomId, roomData.publisherSecret); const recordingCookie = await generateRecordingTokenCookie(roomId, roomData.publisherSecret);
// Create a new room and start a recording // Create a new room and start a recording
roomData = await setupSingleRoomWithRecording(true); roomData = await setupSingleRoomWithRecording(true);
@ -102,11 +102,14 @@ describe('Recordings API Tests', () => {
const rooms = context.rooms; const rooms = context.rooms;
const response = await getAllRecordings({ maxItems: 3 }); const response = await getAllRecordings({ maxItems: 3 });
expectSuccessListRecordingResponse(response, 3, true, true, 3); expectSuccessListRecordingResponse(response, 3, true, true, 3);
response.body.recordings.forEach((recording: MeetRecordingInfo, i: number) => {
response.body.recordings.forEach((recording: MeetRecordingInfo) => {
const associatedRoom = rooms.find((r) => r.room.roomId === recording.roomId);
expect(associatedRoom).toBeDefined();
expectValidRecording( expectValidRecording(
recording, recording,
rooms[i].recordingId!, associatedRoom!.recordingId!,
rooms[i].room.roomId, associatedRoom!.room.roomId,
MeetRecordingStatus.COMPLETE MeetRecordingStatus.COMPLETE
); );
}); });
@ -116,10 +119,12 @@ describe('Recordings API Tests', () => {
expectSuccessListRecordingResponse(nextResponse, 3, false, false, 3); expectSuccessListRecordingResponse(nextResponse, 3, false, false, 3);
nextResponse.body.recordings.forEach((recording: MeetRecordingInfo, i: number) => { nextResponse.body.recordings.forEach((recording: MeetRecordingInfo, i: number) => {
const associatedRoom = rooms.find((r) => r.room.roomId === recording.roomId);
expectValidRecording( expectValidRecording(
recording, recording,
rooms[3 + i].recordingId!, associatedRoom!.recordingId!,
rooms[3 + i].room.roomId, associatedRoom!.room.roomId,
MeetRecordingStatus.COMPLETE MeetRecordingStatus.COMPLETE
); );
}); });