openvidu/meet-ce/backend/src/services/participant-name.service.ts
Carlos Santos 3d4f04feb1 Migrate to pnpm
chore: migrate project to pnpm and update workspace configuration

- Added pnpm workspace configuration in pnpm-workspace.yaml to manage packages.
- Updated prepare.sh script to use pnpm for installing and building packages.
- Modified testapp/package.json scripts to use pnpm instead of npm.
- Enhanced tsconfig.client.json and tsconfig.json with additional options and exclusions.
- Updated typings README.md to reflect the use of pnpm for installation and building.

streamline build process in prepare script and update dependency installation

Refactor code structure for improved readability and maintainability

refactor: optimize Dockerfile for better layer caching and dependency installation

refactor: migrate typings from '@lib/typings/ce' to '@openvidu-meet/typings'

- Updated imports across multiple components and services to use the new '@openvidu-meet/typings' package.
- Removed legacy typings references and adjusted paths in the frontend and webcomponent projects.
- Cleaned up the typings package structure and added build scripts for TypeScript.
- Removed the sync-types.sh script as it is no longer needed with the new structure.
- Updated README and package.json files to reflect the new package name and structure.
feat: add nodemon configuration for API documentation updates and enhance development scripts

feat: implement type checking in watch mode and update development scripts

feat: enhance development scripts with wait-for-typings and watch-typings utilities

fix: remove obsolete sync:backend script and enhance dev script with preserveWatchOutput option

feat: enhance development scripts with typings guard and improve watch behavior

Refactors build and dev scripts

Simplifies and consolidates build and development-related scripts for improved maintainability.

- Updates the build process to be more streamlined.
- Improves the development workflow by consolidating common tasks.
- Removes redundant scripts.

Replaces prepare script with meet script

Replaces the old `prepare.sh` script with a new `meet.sh` script to provide a more user-friendly and comprehensive interface for building and managing the project.

- Integrates command-line arguments for different build targets.
- Includes documentation generation for web components and REST APIs.
- Provides improved error handling and user feedback.
- Simplifies the build process with `pnpm`.

chore: update typescript version to 5.9.2 across multiple package.json files
refactor: replace constructor injection with inject function for AppDataService

feat: add commands to build webcomponent and run unit tests

meet.sh: add end-to-end testing support for webcomponent with optional Playwright browser installation

chore: update pnpm version to 10 and streamline test commands in workflows

meet.sh: rename build_webcomponent_only to build_webcomponent and streamline dependency installation

gitignore: add test-results directory to ignore list

meet.sh: rename build_webcomponent_only to build_webcomponent for consistency

Updated pnpm-lock.yml

refactor: streamline build scripts and enhance service start options in meet.sh

ci: update OpenVidu Meet actions to use meet-pnpm-migration version

refactor: update import paths for WebComponentCommand and WebComponentEvent to use shared typings

fix: add moduleNameMapper for typings path in jest configuration

fix: correct action version syntax for OpenVidu Meet setup in workflow

fix: update typings imports to use shared @openvidu-meet/typings package

fix: add skip-install and skip-typings options to meet.sh and update workflows

meet.sh: add development mode command and update start services options

fix: format code in meeting.component.ts and remove unused export in public-api.ts

added openvidu-components-angular to the local workspace and watch for changes in dev mode

fix: update Node.js action to v5 and streamline build steps in wc-unit-test.yaml

fix: remove pnpm install from build scripts in package.json

fix: update backend unit test workflow and add test unit command in meet.sh

fix: update unit test command in package.json to use pnpm exec

Updates import path for LiveKit permissions

Updates the import path for LiveKit permissions to align with the new typings package location, ensuring the test suite remains functional after the project's dependencies are migrated.

fix: remove redundant dependency installation and build steps in start_services function

fix: update Node.js setup action version and adjust OpenVidu actions for pnpm migration

fix: update tsconfig.json to exclude specific type declaration paths

fix: remove deprecated dependencies and update openapi-generate-html version

fix: update build messages and streamline start commands for production and CI modes

fix: update OpenVidu Meet and Testapp actions to use main branch and streamline pre-startup commands

Refactors type import for auth mode

Updates the import path for the authentication transport mode type.

This change ensures consistency across the application by using a centralized type definition.

Refactors backend integration tests

Streamlines the backend integration test workflow.

Consolidates test jobs for better organization and efficiency.
Leverages matrix testing for recordings API with different storage providers.
Improves AWS runner management for recording tests.
Adds artifact cleanup to prevent storage bloat.

Sets up Node.js and pnpm

Adds Node.js and pnpm setup steps to the integration test workflow.

This enables the use of pnpm for managing dependencies during integration tests.

Refactors test commands to use pnpm exec

Updates the test commands in package.json to use `pnpm exec`
for running Jest.

This ensures that the Jest CLI is executed within the pnpm
managed environment, resolving potential path and dependency
issues.

Refactors imports to use the new typings package

Updates imports to use the new `@openvidu-meet/typings` package.
Removes now-unnecessary module name mappings.

This change is part of the pnpm migration, ensuring correct
resolution of shared types.

Enhances backend integration tests and updates Node.js setup

Simplifies integration tests execution

Updates integration test scripts to streamline execution.

- Uses a single, parameterized script to run all backend integration tests.
- Removes redundant prefixes from test script names.

Refactors jest configuration to include moduleNameMapper for improved module resolution

Updates Jest integration test commands to use experimental VM modules and adjusts TypeScript root directory settings for better output structure

Ensures OpenVidu Meet logs are uploaded

Guarantees OpenVidu Meet logs are uploaded as artifacts, regardless of test outcome.

Moves log upload to ensure consistent capture, and does so for all test scenarios.

Commented backend integration tests

Fix build script to specify TypeScript configuration file

Refactor integration test command to use pnpm bin for jest execution

Update integration test commands to use relative paths for Jest execution

Revert "Commented backend integration tests"

This reverts commit 1da8cddb55e29036c2a816244f4bc8b665ede581.

Change log upload condition to trigger on failure for OpenVidu Meet logs

Add caching step for OpenVidu local deployment images in backend integration tests

Revert "Add caching step for OpenVidu local deployment images in backend integration tests"

This reverts commit bf4692d168c671100a88c09853a460ec5417979d.

Enhance AWS runner setup with storage provider matrix and update job names for clarity

Refactor AWS runner setup to separate jobs for S3, ABS, and GCS, enhancing clarity and maintainability

Update README.md to enhance structure and clarity, including detailed sections on prerequisites, getting started, development, and documentation.

Refactor Dockerfile and entrypoint script, remove deprecated image creation scripts, and enhance meet.sh with Docker build functionality and base href support

Update README.md to reflect changes in Docker image build commands using meet.sh

Update package.json to correct versioning and remove redundant entries

Added browser sync for live reloading

chore: update @typescript-eslint packages to version 8.46.1 in frontend and pnpm-lock.yaml

fix: correct argument skipping logic and ensure typings are built in install_dependencies function

Adapt project structure

backend: add TypeScript type annotations for Router instances in route files

fix: update path for nodemon configuration in dev:rest-api-docs script

fix: update paths in webcomponent documentation generation scripts

fix: update Dockerfile and entrypoint script for correct directory structure and improve error handling

fix: update .dockerignore and Dockerfile for improved directory handling and permissions; add backend type checker script

Added all tests files

Updates OpenVidu Meet action refs to main

Updates the OpenVidu Meet GitHub Action references
in the CI workflows to point to the `main` branch.

This ensures that the workflows use the latest version
of the action.
2025-10-15 17:42:04 +02:00

315 lines
11 KiB
TypeScript

import { inject, injectable } from 'inversify';
import { RedisKeyName } from '../models/redis.model.js';
import { LoggerService, RedisService } from './index.js';
import ms from 'ms';
import INTERNAL_CONFIG from '../config/internal-config.js';
@injectable()
export class ParticipantNameService {
private readonly MAX_CONCURRENT_NAME_REQUESTS = Number(INTERNAL_CONFIG.PARTICIPANT_MAX_CONCURRENT_NAME_REQUESTS);
private readonly PARTICIPANT_NAME_TTL = ms(INTERNAL_CONFIG.PARTICIPANT_NAME_RESERVATION_TTL);
constructor(
@inject(RedisService) protected redisService: RedisService,
@inject(LoggerService) protected logger: LoggerService
) {}
/**
* Reserves a unique participant name for a room using atomic operations.
* If the requested name is taken, it generates alternatives with incremental suffixes.
*
* @param roomId - The room identifier
* @param requestedName - The desired participant name
* @returns Promise<string> - The reserved unique name
* @throws Error if unable to reserve a unique name after max retries
*/
async reserveUniqueName(roomId: string, requestedName: string): Promise<string> {
const participantsKey = `${RedisKeyName.ROOM_PARTICIPANTS}${roomId}`;
// Normalize the base name for case-insensitive comparisons
const normalizedBaseName = requestedName.toLowerCase();
// First, try to reserve the exact requested name
const reservedOriginal = await this.tryReserveName(participantsKey, normalizedBaseName);
if (reservedOriginal) {
this.logger.verbose(`Reserved original name '${requestedName}' for room '${roomId}'`);
return requestedName;
}
// If original name is taken, generate alternatives with atomic counter
for (let attempt = 1; attempt <= this.MAX_CONCURRENT_NAME_REQUESTS; attempt++) {
const alternativeName = await this.generateAlternativeName(roomId, normalizedBaseName, attempt);
const reserved = await this.tryReserveName(participantsKey, alternativeName);
if (reserved) {
this.logger.verbose(
`Reserved alternative name '${alternativeName}' for room '${roomId}' (attempt ${attempt})`
);
// Return alternative name with original case
const suffix = alternativeName.replace(`${normalizedBaseName}_`, '');
return `${requestedName}_${suffix}`;
}
}
throw new Error(
`Unable to reserve unique name for '${requestedName}' in room '${roomId}' after ${this.MAX_CONCURRENT_NAME_REQUESTS} attempts`
);
}
/**
* Releases a reserved participant name, making it available for others.
*
* @param roomId - The room identifier
* @param participantName - The name to release
*/
/**
* Releases a reserved participant name, making it available for others.
* Also returns the number suffix to the available pool for reuse.
*
* @param roomId - The room identifier
* @param participantName - The name to release
*/
async releaseName(roomId: string, participantName: string): Promise<void> {
const participantsKey = `${RedisKeyName.ROOM_PARTICIPANTS}${roomId}`;
// Normalize the name for case-insensitive checks
const normalizedName = participantName.toLowerCase();
try {
await this.redisService.delete(`${participantsKey}:${normalizedName}`);
// If this is a numbered variant (e.g., "Alice_2"), return the number to the pool
const numberMatch = participantName.match(/^(.+)_(\d+)$/);
if (numberMatch) {
const baseName = numberMatch[1];
const number = parseInt(numberMatch[2], 10);
await this.returnNumberToPool(roomId, baseName, number);
}
this.logger.verbose(`Released name '${participantName}' for room '${roomId}'`);
} catch (error) {
this.logger.warn(`Error releasing name '${participantName}' for room '${roomId}':`, error);
}
}
/**
* Checks if a participant name is currently reserved in a room.
*
* @param roomId - The room identifier
* @param participantName - The name to check
* @returns Promise<boolean> - True if the name is reserved
*/
async isNameReserved(roomId: string, participantName: string): Promise<boolean> {
// Normalize the name for case-insensitive checks
const normalizedName = participantName.toLowerCase();
const participantsKey = `${RedisKeyName.ROOM_PARTICIPANTS}${roomId}`;
return await this.redisService.exists(`${participantsKey}:${normalizedName}`);
}
/**
* Gets all currently reserved names in a room.
*
* @param roomId - The room identifier
* @returns Promise<string[]> - Array of reserved participant names
*/
async getReservedNames(roomId: string): Promise<string[]> {
const participantsKey = `${RedisKeyName.ROOM_PARTICIPANTS}${roomId}`;
const pattern = `${participantsKey}:*`;
try {
const keys = await this.redisService.getKeys(pattern);
return keys.map((key) => key.replace(`${participantsKey}:`, ''));
} catch (error) {
this.logger.error(`Error getting reserved names for room '${roomId}':`, error);
return [];
}
}
/**
* Cleans up expired participant reservations for a room.
* This should be called periodically or when a room is cleaned up.
*
* @param roomId - The room identifier
*/
async cleanupExpiredReservations(roomId: string): Promise<void> {
const participantsKey = `${RedisKeyName.ROOM_PARTICIPANTS}${roomId}`;
const participantsPoolKey = `${RedisKeyName.PARTICIPANT_NAME_POOL}${roomId}`;
const pattern = `${participantsKey}:*`;
const poolPattern = `${participantsPoolKey}:*`;
try {
const [participantKeys, poolKeys] = await Promise.all([
this.redisService.getKeys(pattern),
this.redisService.getKeys(poolPattern)
]);
this.logger.verbose(
`Found ${participantKeys.length} participant reservations to check for room '${roomId}'`
);
// Redis TTL will automatically clean up expired keys, but we can force cleanup if needed
const promises = participantKeys.map((key) => this.redisService.delete(key));
await Promise.all(promises);
this.logger.verbose(
`Cleaned up ${participantKeys.length} expired participant names reservations for room '${roomId}'`
);
// Clean up expired participant name numbers from the pool
this.logger.verbose(`Found ${poolKeys.length} participant name numbers to check for room '${roomId}'`);
const poolPromises = poolKeys.map((key) => this.redisService.delete(key));
await Promise.all(poolPromises);
this.logger.verbose(`Cleaned up ${poolKeys.length} expired participant name numbers for room '${roomId}'`);
} catch (error) {
this.logger.error(`Error cleaning up reservations for room '${roomId}':`, error);
}
}
/**
* Attempts to atomically reserve a specific name using Redis SET with NX (not exists) option.
*
* @private
* @param participantsKey - The Redis key prefix for participants
* @param name - The name to reserve
* @returns Promise<boolean> - True if reservation was successful
*/
private async tryReserveName(participantsKey: string, name: string): Promise<boolean> {
// Normalize the name for case-insensitive checks
const normalizedName = name.toLowerCase();
const nameKey = `${participantsKey}:${normalizedName}`;
const timestamp = Date.now().toString();
try {
return await this.redisService.setIfNotExists(nameKey, timestamp, this.PARTICIPANT_NAME_TTL);
} catch (error) {
this.logger.warn(`Error trying to reserve name '${name}':`, error);
return false;
}
}
/**
* Generates an alternative name using a pool of available numbers.
* First tries to get a number from the available pool, then generates the next sequential number.
*
* @private
* @param roomId - The room identifier
* @param baseName - The base name to append number to
* @param fallbackSuffix - Fallback suffix if Redis fails
* @returns Promise<string> - The generated alternative name
*/
private async generateAlternativeName(roomId: string, baseName: string, fallbackSuffix: number): Promise<string> {
try {
// Normalize the base name for case-insensitive checks
const normalizedBaseName = baseName.toLowerCase();
// First try to get an available number from the pool
const availableNumber = await this.getNumberFromPool(roomId, normalizedBaseName);
if (availableNumber !== null) {
return `${baseName}_${availableNumber}`;
}
// If no number available in pool, find the next sequential number
const nextNumber = await this.findNextAvailableNumber(roomId, baseName);
return `${baseName}_${nextNumber}`;
} catch (error) {
this.logger.warn(`Error generating alternative name, using fallback:`, error);
// Fallback to simple incremental suffix if Redis fails
return `${baseName}_${fallbackSuffix}`;
}
}
/**
* Gets the smallest available number from the pool for reuse.
*
* @private
* @param roomId - The room identifier
* @param baseName - The base name
* @returns Promise<number | null> - Available number or null if pool is empty
*/
private async getNumberFromPool(roomId: string, baseName: string): Promise<number | null> {
const poolKey = `${RedisKeyName.PARTICIPANT_NAME_POOL}${roomId}:${baseName}`;
try {
// Get the smallest number from the sorted set and remove it atomically
const results = await this.redisService.popMinFromSortedSet(poolKey, 1);
if (results.length > 0) {
const number = parseInt(results[0], 10);
this.logger.verbose(`Reusing number ${number} from pool for '${baseName}' in room '${roomId}'`);
return number;
}
return null;
} catch (error) {
this.logger.warn(`Error getting number from pool:`, error);
return null;
}
}
/**
* Finds the next available sequential number by checking existing participants.
*
* @private
* @param roomId - The room identifier
* @param baseName - The base name
* @returns Promise<number> - The next available number
*/
private async findNextAvailableNumber(roomId: string, baseName: string): Promise<number> {
const participantsKey = `${RedisKeyName.ROOM_PARTICIPANTS}${roomId}`;
const pattern = `${participantsKey}:${baseName}_*`;
try {
const existingKeys = await this.redisService.getKeys(pattern);
const usedNumbers = new Set<number>();
// Extract all used numbers
for (const key of existingKeys) {
const name = key.replace(`${participantsKey}:`, '');
const numberMatch = name.match(/^.+_(\d+)$/);
if (numberMatch) {
usedNumbers.add(parseInt(numberMatch[1], 10));
}
}
// Find the smallest available number starting from 1
let nextNumber = 1;
while (usedNumbers.has(nextNumber)) {
nextNumber++;
}
this.logger.verbose(`Generated new sequential number ${nextNumber} for '${baseName}' in room '${roomId}'`);
return nextNumber;
} catch (error) {
this.logger.warn(`Error finding next available number:`, error);
// Fallback to timestamp-based number if everything fails
return Date.now() % 10000;
}
}
/**
* Returns a number to the available pool for reuse.
*
* @private
* @param roomId - The room identifier
* @param baseName - The base name
* @param number - The number to return to pool
*/
private async returnNumberToPool(roomId: string, baseName: string, number: number): Promise<void> {
const poolKey = `${RedisKeyName.PARTICIPANT_NAME_POOL}${roomId}:${baseName}`;
try {
// Add number to sorted set (score = number for natural ordering)
await this.redisService.addToSortedSet(poolKey, number, number.toString());
// Set TTL on pool key to prevent memory leaks
await this.redisService.setExpiration(poolKey, this.PARTICIPANT_NAME_TTL);
this.logger.verbose(`Returned number ${number} to pool for '${baseName}' in room '${roomId}'`);
} catch (error) {
this.logger.warn(`Error returning number to pool:`, error);
}
}
}