diff --git a/src/views/Publication/Add.js b/src/views/Publication/Add.js index dd7b98e..965307c 100644 --- a/src/views/Publication/Add.js +++ b/src/views/Publication/Add.js @@ -10,10 +10,7 @@ import useMediaQuery from '@mui/material/useMediaQuery'; import Backdrop from '@mui/material/Backdrop'; import Button from '@mui/material/Button'; import CircularProgress from '@mui/material/CircularProgress'; -import Divider from '@mui/material/Divider'; import Grid from '@mui/material/Grid'; -import Link from '@mui/material/Link'; -import Stack from '@mui/material/Stack'; import Tab from '@mui/material/Tab'; import Tabs from '@mui/material/Tabs'; import TextField from '@mui/material/TextField'; @@ -33,6 +30,7 @@ import PaperFooter from '../../misc/PaperFooter'; import ProcessControl from '../../misc/controls/Process'; import SourceControl from '../../misc/controls/Source'; import Services from './Services'; +import TabContent from './TabContent'; import TabPanel from '../../misc/TabPanel'; import TabsVerticalGrid from '../../misc/TabsVerticalGrid'; @@ -43,17 +41,6 @@ const useStyles = makeStyles((theme) => ({ gridContainer: { marginTop: '0.5em', }, - serviceDescription: { - margin: '1em 0em 1em 0em', - }, - serviceIcon: { - fontSize: '4rem!important', - maxHeight: 64, - marginTop: '-0.065em', - }, - serviceName: { - marginTop: '-.2rem', - }, buttonGroup: { marginTop: '0.5em', marginBottom: '-0.5em', @@ -261,7 +248,6 @@ export default function Add(props) { let serviceList = []; let ServiceControl = null; - let ServiceIcon = null; let serviceSkills = null; let service = {}; @@ -325,8 +311,6 @@ export default function Add(props) { } ServiceControl = service.component; - ServiceIcon = service.icon; - serviceSkills = helper.conflateServiceSkills(service.requires, $skills); } @@ -393,19 +377,8 @@ export default function Add(props) { Encoding} value="encoding" /> - - - - - - - {service.name} - - v{service.version} - - - - + + {service.description} @@ -426,35 +399,10 @@ export default function Add(props) { onChange={handleServiceChange} /> - - - - - - Maintainer:{' '} - - {service.author.maintainer.name} - - - - + - - - - - - - {service.name} - - v{service.version} - - - - - - + Process @@ -463,35 +411,10 @@ export default function Add(props) { - - - - - - Maintainer:{' '} - - {service.author.maintainer.name} - - - - + - - - - - - - {service.name} - - v{service.version} - - - - - - + Source @@ -504,35 +427,10 @@ export default function Add(props) { onChange={handleControlChange('source')} /> - - - - - - Maintainer:{' '} - - {service.author.maintainer.name} - - - - + - - - - - - - {service.name} - - v{service.version} - - - - - - + Encoding @@ -575,18 +473,7 @@ export default function Add(props) { onChange={handleProcessing('audio')} /> - - - - - - Maintainer:{' '} - - {service.author.maintainer.name} - - - - + diff --git a/src/views/Publication/Edit.js b/src/views/Publication/Edit.js index 80e2837..3bbf53f 100644 --- a/src/views/Publication/Edit.js +++ b/src/views/Publication/Edit.js @@ -8,10 +8,8 @@ import makeStyles from '@mui/styles/makeStyles'; import Backdrop from '@mui/material/Backdrop'; import Button from '@mui/material/Button'; import CircularProgress from '@mui/material/CircularProgress'; -import Divider from '@mui/material/Divider'; import Grid from '@mui/material/Grid'; import Link from '@mui/material/Link'; -import Stack from '@mui/material/Stack'; import Tab from '@mui/material/Tab'; import Tabs from '@mui/material/Tabs'; import TextField from '@mui/material/TextField'; @@ -34,6 +32,7 @@ import ProcessControl from '../../misc/controls/Process'; import ProcessModal from '../../misc/modals/Process'; import Services from './Services'; import SourceControl from '../../misc/controls/Source'; +import TabContent from './TabContent'; import TabPanel from '../../misc/TabPanel'; import TabsVerticalGrid from '../../misc/TabsVerticalGrid'; @@ -46,17 +45,6 @@ const useStyles = makeStyles((theme) => ({ marginLeft: 10, wordWrap: 'anywhere', }, - serviceDescription: { - margin: '1em 0em 1em 0em', - }, - serviceIcon: { - fontSize: '4rem!important', - maxHeight: 64, - marginTop: '-0.065em', - }, - serviceName: { - marginTop: '-.2rem', - }, })); export default function Edit(props) { @@ -384,7 +372,6 @@ export default function Edit(props) { } const ServiceControl = $service.component; - const ServiceIcon = $service.icon; const title = $settings.name.length === 0 ? $service.name : $settings.name; @@ -409,19 +396,8 @@ export default function Edit(props) { Encoding} value="encoding" /> - - - - - - - {$service.name} - - v{$service.version} - - - - + + {$service.description} @@ -436,35 +412,10 @@ export default function Edit(props) { - - - - - - Maintainer:{' '} - - {$service.author.maintainer.name} - - - - + - - - - - - - {$service.name} - - v{$service.version} - - - - - - + Process @@ -501,35 +452,10 @@ export default function Edit(props) { )} - - - - - - Maintainer:{' '} - - {$service.author.maintainer.name} - - - - + - - - - - - - {$service.name} - - v{$service.version} - - - - - - + Source @@ -538,35 +464,10 @@ export default function Edit(props) { - - - - - - Maintainer:{' '} - - {$service.author.maintainer.name} - - - - + - - - - - - - {$service.name} - - v{$service.version} - - - - - - + Encoding @@ -611,18 +512,7 @@ export default function Edit(props) { onChange={handleEncoding('audio')} /> - - - - - - Maintainer:{' '} - - {$service.author.maintainer.name} - - - - + diff --git a/src/views/Publication/TabContent.js b/src/views/Publication/TabContent.js new file mode 100644 index 0000000..721d02d --- /dev/null +++ b/src/views/Publication/TabContent.js @@ -0,0 +1,65 @@ +import React from 'react'; +import PropTypes from 'prop-types'; + +import { Trans } from '@lingui/macro'; + +import makeStyles from '@mui/styles/makeStyles'; +import Divider from '@mui/material/Divider'; +import Grid from '@mui/material/Grid'; +import Link from '@mui/material/Link'; +import Stack from '@mui/material/Stack'; +import Typography from '@mui/material/Typography'; + +const useStyles = makeStyles((theme) => ({ + serviceIcon: { + fontSize: '4rem!important', + maxHeight: 64, + marginTop: '-0.065em', + }, + serviceName: { + marginTop: '-.2rem', + }, +})); + +export default function TabContent(props) { + const classes = useStyles(); + + return ( + + + + + + + {props.service.name} + + v{props.service.version} + + + + + + + {props.children} + + + + + + Maintainer:{' '} + + {props.service.author.maintainer.name} + + + + + ); +} + +TabContent.defaultProps = { + service: null, +}; + +TabContent.propTypes = { + service: PropTypes.object.isRequired, +};