neoris/openvidu-livekit-tutorials
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

android: CustomSdpObserver: Drop custom method "log"; use Log.e for failures

Browse Source 
Having a custom "log()" method didn't bring many advantages, and
actually lacked needed flexibility. We'd like to log success messages
to "debug", but failure messages to the "error" level.
This commit is contained in:
Juan Navarro 2022-05-18 13:10:40 +02:00
parent fcb783c3ad
commit 81b7c492d1
1 changed files with 8 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
openvidu-android/app/src/main/java/io/openvidu/openvidu_android/observers/CustomSdpObserver.java
View File

@ -7,33 +7,29 @@ import org.webrtc.SessionDescription;
public class CustomSdpObserver implements SdpObserver {
private String tag;
private final String tag;
public CustomSdpObserver(String tag) {
this.tag = "SdpObserver-" + tag;
}
private void log(String s) {
Log.d(tag, s);
}
@Override
public void onCreateSuccess(SessionDescription sessionDescription) {
log("onCreateSuccess " + sessionDescription);
public void onCreateSuccess(SessionDescription sdp) {
Log.d(this.tag, "onCreateSuccess, SDP: " + sdp.toString());
}
@Override
public void onSetSuccess() {
log("onSetSuccess ");
Log.d(this.tag, "onSetSuccess");
}
@Override
public void onCreateFailure(String s) {
log("onCreateFailure " + s);
public void onCreateFailure(String error) {
Log.e(this.tag, "onCreateFailure, error: " + error);
}
@Override
public void onSetFailure(String s) {
log("onSetFailure " + s);
public void onSetFailure(String error) {
Log.e(this.tag, "onSetFailure, error: " + error);
}
}