backend: Reorder middleware for recording routes to improve validation flow

This commit is contained in:
Carlos Santos 2025-04-03 17:20:03 +02:00
parent 7e62417ed7
commit 9e3644ab06

View File

@ -22,42 +22,42 @@ recordingRouter.use(bodyParser.json());
// Recording Routes // Recording Routes
recordingRouter.post( recordingRouter.post(
'/', '/',
withValidStartRecordingRequest,
withRecordingEnabled, withRecordingEnabled,
withAuth(participantTokenValidator), withAuth(participantTokenValidator),
withCorrectPermissions, withCorrectPermissions,
withValidStartRecordingRequest,
recordingCtrl.startRecording recordingCtrl.startRecording
); );
recordingRouter.put( recordingRouter.put(
'/:recordingId', '/:recordingId',
withValidRecordingId,
withRecordingEnabled, withRecordingEnabled,
withAuth(participantTokenValidator), withAuth(participantTokenValidator),
withCorrectPermissions, withCorrectPermissions,
withValidRecordingId,
recordingCtrl.stopRecording recordingCtrl.stopRecording
); );
recordingRouter.delete( recordingRouter.delete(
'/:recordingId', '/:recordingId',
withValidRecordingId,
withAuth(apiKeyValidator, tokenAndRoleValidator(UserRole.ADMIN)), withAuth(apiKeyValidator, tokenAndRoleValidator(UserRole.ADMIN)),
withValidRecordingId,
recordingCtrl.deleteRecording recordingCtrl.deleteRecording
); );
recordingRouter.get( recordingRouter.get(
'/:recordingId', '/:recordingId',
withValidRecordingId,
withAuth(apiKeyValidator, tokenAndRoleValidator(UserRole.ADMIN)), withAuth(apiKeyValidator, tokenAndRoleValidator(UserRole.ADMIN)),
withValidRecordingId,
recordingCtrl.getRecording recordingCtrl.getRecording
); );
recordingRouter.get( recordingRouter.get(
'/', '/',
withValidGetRecordingsRequest,
withAuth(apiKeyValidator, tokenAndRoleValidator(UserRole.ADMIN)), withAuth(apiKeyValidator, tokenAndRoleValidator(UserRole.ADMIN)),
withValidGetRecordingsRequest,
recordingCtrl.getRecordings recordingCtrl.getRecordings
); );
recordingRouter.delete( recordingRouter.delete(
'/', '/',
withValidRecordingBulkDeleteRequest,
withAuth(apiKeyValidator, tokenAndRoleValidator(UserRole.ADMIN)), withAuth(apiKeyValidator, tokenAndRoleValidator(UserRole.ADMIN)),
withValidRecordingBulkDeleteRequest,
recordingCtrl.bulkDeleteRecordings recordingCtrl.bulkDeleteRecordings
); );
@ -68,7 +68,7 @@ internalRecordingRouter.use(bodyParser.json());
internalRecordingRouter.get( internalRecordingRouter.get(
'/:recordingId/stream', '/:recordingId/stream',
withValidRecordingId,
withAuth(tokenAndRoleValidator(UserRole.ADMIN)), withAuth(tokenAndRoleValidator(UserRole.ADMIN)),
withValidRecordingId,
recordingCtrl.streamRecording recordingCtrl.streamRecording
); );