neoris/openvidu
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove numParticipants from OpenViduMeetRoom and simplify accessRoomUrl handling in HomeComponent

Browse Source
This commit is contained in:
Carlos Santos 2025-03-13 20:06:16 +01:00
parent 6f86890209
commit cf1c4c5438
3 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
backend/src/services/room.service.ts
View File

@ -214,14 +214,13 @@ export class RoomService {
livekitRoom: Room, livekitRoom: Room,
roomOptions: OpenViduMeetRoomOptions roomOptions: OpenViduMeetRoomOptions
): OpenViduMeetRoom { ): OpenViduMeetRoom {
const { name: roomName, creationTime, numParticipants } = livekitRoom; const { name: roomName, creationTime } = livekitRoom;
const { preferences, expirationDate, roomNamePrefix, maxParticipants } = roomOptions; const { preferences, expirationDate, roomNamePrefix, maxParticipants } = roomOptions;
const openviduRoom: OpenViduMeetRoom = { const openviduRoom: OpenViduMeetRoom = {
roomName, roomName,
roomNamePrefix, roomNamePrefix,
creationDate: Number(creationTime) * 1000, creationDate: Number(creationTime) * 1000,
numParticipants,
maxParticipants, maxParticipants,
expirationDate, expirationDate,
moderatorRoomUrl: `${baseUrl}/room/${roomName}?secret=${secureUid(10)}`, moderatorRoomUrl: `${baseUrl}/room/${roomName}?secret=${secureUid(10)}`,

5
frontend/src/app/pages/home/home.component.ts
View File

@ -149,10 +149,7 @@ export class HomeComponent implements OnInit, OnDestroy {
this.roomForm.get('roomNamePrefix')?.setValue(roomNamePrefix); this.roomForm.get('roomNamePrefix')?.setValue(roomNamePrefix);
const isFirstParticipant = room.numParticipants === 0; const accessRoomUrl = new URL(room.moderatorRoomUrl);
const accessRoomUrl = new URL(isFirstParticipant ? room.moderatorRoomUrl : room.publisherRoomUrl);
const secret = accessRoomUrl.searchParams.get('secret'); const secret = accessRoomUrl.searchParams.get('secret');
const roomName = accessRoomUrl.pathname; const roomName = accessRoomUrl.pathname;

1
typings/src/room.ts
View File

@ -17,7 +17,6 @@ export type OpenViduMeetRoomOptions = BaseRoomOptions;
export interface OpenViduMeetRoom extends BaseRoomOptions { export interface OpenViduMeetRoom extends BaseRoomOptions {
roomName: string; roomName: string;
creationDate: number; creationDate: number;
numParticipants: number;
moderatorRoomUrl: string; moderatorRoomUrl: string;
publisherRoomUrl: string; publisherRoomUrl: string;
} }